Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <153754740781.17872.7869536526927736855.stgit@warthog.procyon.org.uk>
 <153754746514.17872.4993763624097980573.stgit@warthog.procyon.org.uk>
In-Reply-To: <153754746514.17872.4993763624097980573.stgit@warthog.procyon.org.uk>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Thu, 14 Mar 2019 08:46:31 +0100
Message-ID: <CAMuHMdUo7QA+xtWWoyBtFHghwYYp4XUWeHYRM2Mt5QXq+ACTww@mail.gmail.com>
Subject: Re: [PATCH 07/34] vfs: Add configuration parser helpers [ver #12]
To:     David Howells <dhowells@redhat.com>
Cc:     Al Viro <viro@zeniv.linux.org.uk>,
        "torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        Linux FS Devel <linux-fsdevel@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        mszeredi@redhat.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi David,

On Fri, Sep 21, 2018 at 6:33 PM David Howells <dhowells@redhat.com> wrote:
> Because the new API passes in key,value parameters, match_token() cannot be
> used with it.  Instead, provide three new helpers to aid with parsing:

> --- a/fs/Kconfig
> +++ b/fs/Kconfig
> @@ -8,6 +8,13 @@ menu "File systems"
>  config DCACHE_WORD_ACCESS
>         bool
>
> +config VALIDATE_FS_PARSER
> +       bool "Validate filesystem parameter description"
> +       default y
> +       help
> +         Enable this to perform validation of the parameter description for a
> +         filesystem when it is registered.
> +

When would I want to disable this?

It seems this option was introduced in "ver #10" of your patch series,
without being mentioned in the changelog for that version.

Thanks!

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds