Received: by 2002:ac0:950c:0:0:0:0:0 with SMTP id f12csp3624196imc; Thu, 14 Mar 2019 01:11:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqwKnIgtAGa4565S8YYWWawhBsbCdAPzrm0GL3Dth9iecq1sUtDOfPTl5W+85uvFLMB9WvXh X-Received: by 2002:a17:902:1025:: with SMTP id b34mr50976849pla.306.1552551087716; Thu, 14 Mar 2019 01:11:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552551087; cv=none; d=google.com; s=arc-20160816; b=UEUTURv9n9xVV4IJYXmxFr8Fjy8eB9mRoeFXZ8A9nvn1wpwOYtwhKOg0BOycw4K9PI GPrBhA9myxLtLy+HAhjsInP0XTjAJdiuIX17NIPRal70sVVYcEsfcF25agoi4ePsdfLP 2rXF3LIWABJIBYB381pGCMDS2G2i0SP/7IxtEGZKOXNs2Wdq//cxJPJOrtj2ceInKa9s Fc+2M7eUrzxd7j9T1LhQvBuqG2jpFagdSoSpuF2Ysm7kgwXDAdq3I0Di8UaL/MgYipM1 j7uabsq4GETAb/GPnF0tEq2ZgW5W3PcOJWrwfGDke8sxHQod+xWU4FjkZStYuSG0VvxZ gwTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=WJnCbhVRzn6ZVCVZJ9q4XRN92IY5Me+bA8niol+IEJw=; b=XXBihIti7mF7IJJXq9pEXQjsVI9huVhoVrVWCWC5CiTjQTIwJECIjgaB12ReMRn4GF vHu+CBaOjVWfBmDNOCpLAyz5PiSiz7/aYz6YV+WwsFmhvE1NAYvHE3EuaNfOxwk+5Ld6 8TN7xIYyBpuXVT1Jwd49xeMfxYdHTJ2NoqRFpPOZ+s+bGaPato+VI9aM1j7XL6dfPqEb 8vEuRaXmBoHhgNDDZvE26+7uinXbfBw5okulTiORnsIKIp7OCeVjb7EkiayafCswY9p5 T07sMnKEJnowyRBtoxx+WHqBqT3KTRIHR3IKG0dcLBj75EdFEadWliW/klSBQ+Vd/kfC GZ0w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g11si5114743plo.125.2019.03.14.01.11.12; Thu, 14 Mar 2019 01:11:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727166AbfCNIKZ (ORCPT + 99 others); Thu, 14 Mar 2019 04:10:25 -0400 Received: from mail-ua1-f67.google.com ([209.85.222.67]:33986 "EHLO mail-ua1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726284AbfCNIKZ (ORCPT ); Thu, 14 Mar 2019 04:10:25 -0400 Received: by mail-ua1-f67.google.com with SMTP id a42so1619130uad.1; Thu, 14 Mar 2019 01:10:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WJnCbhVRzn6ZVCVZJ9q4XRN92IY5Me+bA8niol+IEJw=; b=RaZ4GRmvLh6DiACqoNMO/ygykrAY1fyCC+28VCLrq4os8yBeQko6f3AWZTuZx552Oa i4CYOKPGayI7g2n/jzioO0pe+AUGXdMhhjB2UjVeLb4ZavUMw73YS7tAe3xlog6gALHx S0Vr16i6MrHlKk23QxaWwQiBjPRVFedbeBY6nLymzZjQmiDN9ZEv2PuO8wg3OC2gS1K8 kkltpl3+bjjeXqRivCbjgd6WZZucuQS8TAn2i3U0qssaLCRldO0S7uGRUAKzopUySoFO eOhnUYpJy6GYniNSf7NUkC5r9RlvCCWlji7ABp7rEnWY3BpYy1bvQEb00XG75MDKBDB3 kmGQ== X-Gm-Message-State: APjAAAXvUhG+/7xwb27jIGMZRKEgNLKkmRxVOIU8pHBfzxUlU7GV5zAC 5BPDxAdInqLFwWJr3Dka59sA8WmjvDaoV+tUcIxrZBin X-Received: by 2002:a9f:2f0b:: with SMTP id x11mr24069123uaj.78.1552551024158; Thu, 14 Mar 2019 01:10:24 -0700 (PDT) MIME-Version: 1.0 References: <20190314080741.31983-1-kjlu@umn.edu> In-Reply-To: <20190314080741.31983-1-kjlu@umn.edu> From: Geert Uytterhoeven Date: Thu, 14 Mar 2019 09:10:12 +0100 Message-ID: Subject: Re: [PATCH v2] pci: pcie-rcar: fix a potential NULL pointer dereference To: Kangjie Lu Cc: pakki001@umn.edu, Simon Horman , Lorenzo Pieralisi , Bjorn Helgaas , linux-pci , Linux-Renesas , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 14, 2019 at 9:08 AM Kangjie Lu wrote: > In case __get_free_pages fails and returns NULL, the fix returns > -ENOMEM and releases resources to avoid NULL pointer dereference. > > Signed-off-by: Kangjie Lu Please keep my Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds