Received: by 2002:ac0:950c:0:0:0:0:0 with SMTP id f12csp3670964imc; Thu, 14 Mar 2019 02:33:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqwUXWtMzdQd+2ez31O+sg28n8MhURVhbqj6Ta2KsE6iv/kYWKk0zz4wwzWPhOz8lMOz7kps X-Received: by 2002:a63:cd03:: with SMTP id i3mr35775989pgg.172.1552556004681; Thu, 14 Mar 2019 02:33:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552556004; cv=none; d=google.com; s=arc-20160816; b=HMJYp3GDj2A57vKk/uwXOsSErwL+pynIIfJ724HJna0EkmBUoHmNI5X7Z8IbnnZb5+ /BLeFl3oVtfXjyl9yLlnaS3v4qnkh3xRjR6vyu/gFJ7F+Gntg4VlKyk9imzstGnXdXjH 8eqaU+HViSVy3+Xo24i6q9UnthMxOjxMSAVSkhPGqAZ2oIWmdb/ZmMYBoa2hbqZ2qyO1 UuwAgOF1Pf82hvlijBafzX39eMf2WKNvh12ELgRkWcI9boBEKOd30V6UmlFvzU+8LVef L0tzvzlutgd5StZ5gg//DveW12IaZ+apAVW4GRAGsoF0F4jEjDc1YIZhBmsYb4ez90uO 0u+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=ugqtJ+r1UGwnkxjDiz/nPRC6OPlMM8XBPm8j5iDOkYU=; b=g3LVhfipPx/H0MopypzrNTBKWLgdSuabKHApEob5Px0Zi36wSmC1PxxUIGf4u3TJke GcU9bfYHpx8ew2Qcab6OoAGoQWDU7i06+++ZCnoZx60cZZdgIGEiA2EJw4GYCVSBVrh+ Sxf889oBAO7SzoaHbZ+lUubVssioEbbzLtRXtWsL6/krCnBsXep23frnx+SY8SFBlFuk Hv+j/auh9DMRvu7tIpEvkxbsIwy2KIfdi+kZjcHMjDQ3J4tDmjtMf0GF25fBkiC7RR1e 4dMHKKLNI6EIFaSGmeRcskQHjRJJMVAgZ8A7OhAg88g0Jbzh2wXJjT/zPH44g2ZroRTM /nSQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 31si14364229plc.190.2019.03.14.02.33.09; Thu, 14 Mar 2019 02:33:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727186AbfCNJbO (ORCPT + 99 others); Thu, 14 Mar 2019 05:31:14 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:38871 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726421AbfCNJbN (ORCPT ); Thu, 14 Mar 2019 05:31:13 -0400 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1h4Mhj-00033j-L5; Thu, 14 Mar 2019 10:31:11 +0100 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1h4Mhj-0001V0-CK; Thu, 14 Mar 2019 10:31:11 +0100 Date: Thu, 14 Mar 2019 10:31:11 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Rasmus Villemoes Cc: Pavel Machek , Jacek Anaszewski , LKML , linux-leds@vger.kernel.org Subject: Re: [PATCH 2/4] leds: netdev trigger: factor out middle part of device_name_store Message-ID: <20190314093111.7ivkdg7ozk4vylio@pengutronix.de> References: <20190311144227.GA4404@amd> <20190313202615.22883-1-linux@rasmusvillemoes.dk> <20190313202615.22883-3-linux@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190313202615.22883-3-linux@rasmusvillemoes.dk> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Wed, Mar 13, 2019 at 09:26:13PM +0100, Rasmus Villemoes wrote: > +static void set_device(struct led_netdev_data *trigger_data, > + const char *buf, size_t size) "set_device" is a very generic name. Can you please prefix it with "ledtrig_netdev_"? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |