Received: by 2002:ac0:950c:0:0:0:0:0 with SMTP id f12csp3685867imc; Thu, 14 Mar 2019 02:59:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqx7oMl5XiOvTx4HGjcGQHMkj67KjswykBNfaXjnA5dfJ2VummQbSZaZdCA6CV6E1I1MpwIF X-Received: by 2002:a65:4843:: with SMTP id i3mr8313953pgs.176.1552557577540; Thu, 14 Mar 2019 02:59:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552557577; cv=none; d=google.com; s=arc-20160816; b=oNHwXOktN8u/GF66g1HIkP4WLL+dvZg2Cd255aZvGD68snsR4JD3URl5c/25yVAUff GoDQJ7g8tGgyVEHYileBvc7MuaA+qK7hPrLcPacXnuGfob/dXtOooAFVrSTUqjVZ8ll6 XZotFOLGcZToxbguJ0GtVCTZLNWOwXJHenstu3pUmFu2584vMZG3VJIZ3Lp7l1fwbXZD x7HHOzImGHxcg5CNa4BTz8uOZ2EdZRtdj2dkULQpF+MkVqTMW/AzBixWLePrDmd+KfYW TD7aGeChwN8u5PlbeMwffba7Ok8jblNcsvrjyOG6P49XuKqi/RwYqMToh1iZhWWb1/ks K3mQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=NuSK0qOPLXxH7vhF0A67emmli0VyceoxlDDTT3FCfac=; b=IUiu6PZjEzWNDWxNg/okZ+oqVSqZPGHghLgJl5hDZS1VTBuldvUdx9WK92fYFN6VWl CBYchwDJeXiH7yYrhh5FgRks43/3GxDAHx5XzT/Fu/jgxWs+n3r69yBvHFDm/kRmf1oD /a4w0JVVYLGb1HpeQ/pkTtSHD4yn1PSg5EWnDZtHGKXU9pbbwN+V7Z+tT/8Z6QTD5uDJ Ewx3JYDOqCwUJks3qk2abmBUb3/yNknToi6SlsxiKazsBvAYKNygWpD07E42z2SFlxWr 3ecOb3oTarRUCuffAxk7DA5/nqBfEuj3PYKcNHOMUCqF3A6kCPhJCjqMkbkFiebBwGRP 6YWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@rasmusvillemoes.dk header.s=google header.b=bNu4Ji+1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u7si13225877pls.237.2019.03.14.02.59.22; Thu, 14 Mar 2019 02:59:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@rasmusvillemoes.dk header.s=google header.b=bNu4Ji+1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727218AbfCNJ6A (ORCPT + 99 others); Thu, 14 Mar 2019 05:58:00 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:37342 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726697AbfCNJ57 (ORCPT ); Thu, 14 Mar 2019 05:57:59 -0400 Received: by mail-lj1-f195.google.com with SMTP id a17so4235556ljd.4 for ; Thu, 14 Mar 2019 02:57:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=NuSK0qOPLXxH7vhF0A67emmli0VyceoxlDDTT3FCfac=; b=bNu4Ji+16FXSqNVd2X6tyw2n1bEq8Gi+CACP2GwVjOxPUcgsgl0SO7r1Mxln0OMDFr N62zKvkajrRJOdMXvvhAH4UrZGcGMcp2D1tHW6nEQBFdUIEHmHyJNLb8147ItktBzcgd XMOrFXwfwd5lU37g+woqdhOekkVmeSWVeLs/I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=NuSK0qOPLXxH7vhF0A67emmli0VyceoxlDDTT3FCfac=; b=YCkz592/j3On2mnTCmFKEkzbh1I7/2hr8lwZPOMIZgfULBE/n02d3/MOOqaHTxi/4Q nb8f9RcKZmhoJ8eivOhHQn5XZ2RrdMvFWh/KDeGEOxZlFyicbIwF82nSUKaUgjLqXH9e 5Yy4fBMvkUr7Xe7MsbymjkmT3oXQcG670uLM8NqyfQeJpAD4+4PQ3aiBZMginxcsa5pH 6+K+CpwsjN71kUSkR7gFQeMv6yxfa8BQn0Kjk1b/2m5U8bcLOiQbrHjXAo3kuXuIIOVw n2bBh5ML9tvzF1q8f/KKtJd27LHby5s+T8dW7ubpGEJHE2zx12vod1v7ri+562q1KJjc pCig== X-Gm-Message-State: APjAAAXoKVyBHcZquLc78Yp9s8cbbexa+M4To8CXrx3phS9fB5Xz8YON hpLCxAK/F5iRu/MsCmnwEoSm9w== X-Received: by 2002:a2e:90cd:: with SMTP id o13mr14743771ljg.153.1552557477304; Thu, 14 Mar 2019 02:57:57 -0700 (PDT) Received: from [172.16.11.26] ([81.216.59.226]) by smtp.gmail.com with ESMTPSA id q2sm1302809ljb.86.2019.03.14.02.57.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Mar 2019 02:57:56 -0700 (PDT) Subject: Re: [PATCH 2/4] leds: netdev trigger: factor out middle part of device_name_store To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= Cc: Pavel Machek , Jacek Anaszewski , LKML , linux-leds@vger.kernel.org References: <20190311144227.GA4404@amd> <20190313202615.22883-1-linux@rasmusvillemoes.dk> <20190313202615.22883-3-linux@rasmusvillemoes.dk> <20190314093111.7ivkdg7ozk4vylio@pengutronix.de> From: Rasmus Villemoes Message-ID: Date: Thu, 14 Mar 2019 10:57:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190314093111.7ivkdg7ozk4vylio@pengutronix.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/03/2019 10.31, Uwe Kleine-König wrote: > Hello, > > On Wed, Mar 13, 2019 at 09:26:13PM +0100, Rasmus Villemoes wrote: >> +static void set_device(struct led_netdev_data *trigger_data, >> + const char *buf, size_t size) > > "set_device" is a very generic name. Can you please prefix it with > "ledtrig_netdev_"? Sure. Will do next round.