Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 14 Mar 2019 09:37:46 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Joel Fernandes <joel@joelfernandes.org>
Cc:     "Paul E. McKenney" <paulmck@linux.ibm.com>,
        linux-kernel@vger.kernel.org, rcu@vger.kernel.org,
        jiangshanlai@gmail.com, dipankar@in.ibm.com,
        mathieu.desnoyers@efficios.com, josh@joshtriplett.org,
        luto@kernel.org, byungchul.park@lge.com
Subject: Re: [PATCH tip/core/rcu 06/19] rcu: Add warning to detect
 half-interrupts
Message-ID: <20190314093746.028e57f1@gandalf.local.home>
In-Reply-To: <20190314093657.2c1a3485@gandalf.local.home>
References: <20180829222047.319-6-paulmck@linux.vnet.ibm.com>
        <20190311133939.GA29747@google.com>
        <20190311222903.GR13351@linux.ibm.com>
        <20190312150514.GB249405@google.com>
        <20190312152034.GZ13351@linux.ibm.com>
        <20190313150948.GA84821@google.com>
        <20190313112726.01d974fc@gandalf.local.home>
        <20190313155155.GN13351@linux.ibm.com>
        <20190313125125.1a1fb2f3@gandalf.local.home>
        <20190313180730.GU13351@linux.ibm.com>
        <20190314123159.GB101545@google.com>
        <20190314093657.2c1a3485@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 14 Mar 2019 09:36:57 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Thu, 14 Mar 2019 08:31:59 -0400
> Joel Fernandes <joel@joelfernandes.org> wrote:
> 
> > Oh thanks for pointing that out. Yes it does work for me. I agree with the
> > lockdep API addition and others could benefit from it too. I will incorporate
> > the lockdep API addition into the RCU patch, but let me know if I should
> > rather split it.  
> 
> I'd recommend splitting it (adding the lockdep_assert in a patch by
> itself), but make sure that patch Cc's the lockdep maintainers and
> explains the reason for adding it. Might as well Cc the lockdep
> maintainers on the entire series too.
>

Feel free to add "Suggested-by: Steven Rostedt (VMware) <rostedt@goodmis.org>"
on that patch too.

-- Steve