Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 14 Mar 2019 16:49:10 +0100
From:   Oscar Salvador <osalvador@suse.de>
To:     David Hildenbrand <david@redhat.com>
Cc:     xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Juergen Gross <jgross@suse.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Julien Grall <julien.grall@arm.com>,
        Matthew Wilcox <willy@infradead.org>,
        Nadav Amit <namit@vmware.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        akpm@linux-foundation.org, linux-mm@kvack.org
Subject: Re: [PATCH v1] xen/balloon: Fix mapping PG_offline pages to user
 space
Message-ID: <20190314154907.wcwh5ricj6v7p23v@d104.suse.de>
References: <20190314154025.21128-1-david@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190314154025.21128-1-david@redhat.com>
User-Agent: NeoMutt/20170421 (1.8.2)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Mar 14, 2019 at 04:40:25PM +0100, David Hildenbrand wrote:
> @@ -646,6 +647,7 @@ void free_xenballooned_pages(int nr_pages, struct page **pages)
>  
>  	for (i = 0; i < nr_pages; i++) {
>  		if (pages[i])
> +			__SetPageOffline(pages[i]);
>  			balloon_append(pages[i]);

didn't you forget {} there? ;-)

>  	}
>  
> -- 
> 2.17.2
> 

-- 
Oscar Salvador
SUSE L3