Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-Id: <5C8A77FD020000780021EC87@prv1-mh.provo.novell.com>
Date:   Thu, 14 Mar 2019 09:49:17 -0600
From:   "Jan Beulich" <JBeulich@suse.com>
To:     "David Hildenbrand" <david@redhat.com>
Cc:     "Julien Grall" <julien.grall@arm.com>,
        "Andrew Cooper" <andrew.cooper3@citrix.com>,
        "Matthew Wilcox" <willy@infradead.org>,
        "Stefano Stabellini" <sstabellini@kernel.org>,
        <linux-mm@kvack.org>, <akpm@linux-foundation.org>,
        "xen-devel" <xen-devel@lists.xenproject.org>,
        "Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
        "Juergen Gross" <jgross@suse.com>, <linux-kernel@vger.kernel.org>,
        "Nadav Amit" <namit@vmware.com>
Subject: Re: [Xen-devel] [PATCH v1] xen/balloon: Fix mapping PG_offline
 pages to user space
References: <20190314154025.21128-1-david@redhat.com>
In-Reply-To: <20190314154025.21128-1-david@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 8BIT
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

>>> On 14.03.19 at 16:40, <david@redhat.com> wrote:
> --- a/drivers/xen/balloon.c
> +++ b/drivers/xen/balloon.c
> @@ -604,6 +604,7 @@ int alloc_xenballooned_pages(int nr_pages, struct page **pages)
>  	while (pgno < nr_pages) {
>  		page = balloon_retrieve(true);
>  		if (page) {
> +			__ClearPageOffline(page);
>  			pages[pgno++] = page;

While this one's fine, ...

> @@ -646,6 +647,7 @@ void free_xenballooned_pages(int nr_pages, struct page **pages)
>  
>  	for (i = 0; i < nr_pages; i++) {
>  		if (pages[i])
> +			__SetPageOffline(pages[i]);
>  			balloon_append(pages[i]);
>  	}

... I think you want to add a pair of braces here.

Jan