Received: by 2002:ac0:950c:0:0:0:0:0 with SMTP id f12csp3952662imc; Thu, 14 Mar 2019 08:54:51 -0700 (PDT) X-Google-Smtp-Source: APXvYqyQjmYEtfxZ5XgiQUb+pm1ueDGU7MvL3EydknhMzyGESl2sDo+mVfPhKhOJVid+vUBxMJAD X-Received: by 2002:a62:6d81:: with SMTP id i123mr49612346pfc.235.1552578890939; Thu, 14 Mar 2019 08:54:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552578890; cv=none; d=google.com; s=arc-20160816; b=REZcj7RrI/lalErab49CDJM3VxhdFQB4m03lZdlTvWR4gnk6EbSzVP1QI1PG2Bsx2J i+CkIEB4Zlz9AKiKsMQTqTRUDl59cJqQOgGrgxoCK8hPbuzLIJgSQDqkAN5t2zVQ3QVC wBhxIxaB+/prR6AhZBzazlswzIaWjQee85AODOq62HJWa7+bADD3bWSErsEYAgtl3OkF N/tmQCjSDXP33Okftpnaph2Q2FhHukvtWYuBGLcyQIR7t/EUfUnvaCqjiYBK2fhn0qgt OCzLYLbFVJGKde0TFaxA/F9jUzzfMQHBt/cG8WSCxPPwhwkn1quxB0bc/kmMmqcLsFEM uVcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:in-reply-to:subject:cc:to :from:dkim-signature; bh=Lnj13rR0ecnnQ8FeiqxHVUJkOqCrxg3GN407eFSZnH4=; b=i62hQ8TchmyRR+5O77fylrFDo21GQ3G6i6QGBeuNx3H/qjMR0/OvIHJmBB0hCzjObr DiG9ipZ71Qdcy2Uwe9orlOj8lRsloqRz6AfKIODHC0yEH340607RkTF60k9nZvFKogUj HcE/LKL0WTlATNnsxdBAM28x8jkWgaRCua96KNbi3OY+B2AwCX6ntIVNIfv7KjAFs7D5 rHb436xBnXLkQGu7/UKHzfXypouwtKOiKFje3nEnbXuzof06Yrai9afSC0e2yGncO3wy gE9c4840R99hBghdyypHZC5QkKVIXnHHiJc0Kfa/kQR5Pod+T3lSqccztIdJ8ail9yHM 8AtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=pnwi0gUj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b8si14787545pla.290.2019.03.14.08.54.36; Thu, 14 Mar 2019 08:54:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=pnwi0gUj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727131AbfCNPxp (ORCPT + 99 others); Thu, 14 Mar 2019 11:53:45 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:34714 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726431AbfCNPxo (ORCPT ); Thu, 14 Mar 2019 11:53:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=Lnj13rR0ecnnQ8FeiqxHVUJkOqCrxg3GN407eFSZnH4=; b=pnwi0gUjLger Tlq2UVI5agdDOqtTwFgi9Igd6+ArB8QEVa/HS6WNqmOi1KLkPMSahfDXhdoOPDZoBQX92rPSMahEs O0ZVgsS3/J/YtACMG9XViDvCfFsgrp0VMf0lAzrS/f8jt86RVZfETom+PdI7JlKqGxnyHvizk8FPe zqAyU=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1h4Sfp-0002g1-3F; Thu, 14 Mar 2019 15:53:37 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id 8C6091126E64; Thu, 14 Mar 2019 15:53:36 +0000 (GMT) From: Mark Brown To: Arnd Bergmann Cc: Peter Ujfalusi , Mark Brown , Mark Brown , alsa-devel@alsa-project.org, Tony Lindgren , Liam Girdwood , linux-kernel@vger.kernel.org, Peter Ujfalusi , Vinod Koul , dmaengine@vger.kernel.org, linux-omap@vger.kernel.org, Jarkko Nikula , alsa-devel@alsa-project.org Subject: Applied "ASoC: ti: remove compat dma probing" to the asoc tree In-Reply-To: <20190307151646.1016966-1-arnd@arndb.de> X-Patchwork-Hint: ignore Message-Id: <20190314155336.8C6091126E64@debutante.sirena.org.uk> Date: Thu, 14 Mar 2019 15:53:36 +0000 (GMT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch ASoC: ti: remove compat dma probing has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From 642aafea8889b712fe8e57aaa706d6c05d295059 Mon Sep 17 00:00:00 2001 From: Arnd Bergmann Date: Thu, 7 Mar 2019 16:16:08 +0100 Subject: [PATCH] ASoC: ti: remove compat dma probing After running into a link error: sound/soc/ti/edma-pcm.o:(.rodata+0x18): undefined reference to `edma_filter_fn' I checked all users of this, and they have new-style 'dma_slave_map' tables, so none of them should still need it. Removing the associated lines simplifies the code and avoids the build-time dependency on the respective dmaengine drivers. Acked-by: Peter Ujfalusi Signed-off-by: Arnd Bergmann Signed-off-by: Mark Brown --- sound/soc/ti/edma-pcm.c | 5 +---- sound/soc/ti/sdma-pcm.c | 9 +++------ 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/sound/soc/ti/edma-pcm.c b/sound/soc/ti/edma-pcm.c index 59e588abe54b..fdffb801b185 100644 --- a/sound/soc/ti/edma-pcm.c +++ b/sound/soc/ti/edma-pcm.c @@ -23,7 +23,6 @@ #include #include #include -#include #include "edma-pcm.h" @@ -43,14 +42,12 @@ static const struct snd_pcm_hardware edma_pcm_hardware = { static const struct snd_dmaengine_pcm_config edma_dmaengine_pcm_config = { .pcm_hardware = &edma_pcm_hardware, .prepare_slave_config = snd_dmaengine_pcm_prepare_slave_config, - .compat_filter_fn = edma_filter_fn, .prealloc_buffer_size = 128 * 1024, }; int edma_pcm_platform_register(struct device *dev) { - return devm_snd_dmaengine_pcm_register(dev, &edma_dmaengine_pcm_config, - SND_DMAENGINE_PCM_FLAG_COMPAT); + return devm_snd_dmaengine_pcm_register(dev, &edma_dmaengine_pcm_config, 0); } EXPORT_SYMBOL_GPL(edma_pcm_platform_register); diff --git a/sound/soc/ti/sdma-pcm.c b/sound/soc/ti/sdma-pcm.c index 21a9c2499d48..a236350beb10 100644 --- a/sound/soc/ti/sdma-pcm.c +++ b/sound/soc/ti/sdma-pcm.c @@ -11,7 +11,6 @@ #include #include #include -#include #include "sdma-pcm.h" @@ -31,7 +30,6 @@ static const struct snd_pcm_hardware sdma_pcm_hardware = { static const struct snd_dmaengine_pcm_config sdma_dmaengine_pcm_config = { .pcm_hardware = &sdma_pcm_hardware, .prepare_slave_config = snd_dmaengine_pcm_prepare_slave_config, - .compat_filter_fn = omap_dma_filter_fn, .prealloc_buffer_size = 128 * 1024, }; @@ -39,13 +37,12 @@ int sdma_pcm_platform_register(struct device *dev, char *txdmachan, char *rxdmachan) { struct snd_dmaengine_pcm_config *config; - unsigned int flags = SND_DMAENGINE_PCM_FLAG_COMPAT; + unsigned int flags = 0; /* Standard names for the directions: 'tx' and 'rx' */ if (!txdmachan && !rxdmachan) return devm_snd_dmaengine_pcm_register(dev, - &sdma_dmaengine_pcm_config, - flags); + &sdma_dmaengine_pcm_config, 0); config = devm_kzalloc(dev, sizeof(*config), GFP_KERNEL); if (!config) @@ -65,7 +62,7 @@ int sdma_pcm_platform_register(struct device *dev, config->chan_names[0] = txdmachan; config->chan_names[1] = rxdmachan; - return devm_snd_dmaengine_pcm_register(dev, config, flags); + return devm_snd_dmaengine_pcm_register(dev, config, 0); } EXPORT_SYMBOL_GPL(sdma_pcm_platform_register); -- 2.20.1