Received: by 2002:ac0:950c:0:0:0:0:0 with SMTP id f12csp4021831imc; Thu, 14 Mar 2019 10:24:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqz60yktDMAuybzidFw9QtqYcuLmZeSLl6IDarDkGKtAcK2idJNitZHyijfdqEKXVEdugtqQ X-Received: by 2002:a17:902:1121:: with SMTP id d30mr7579131pla.104.1552584249286; Thu, 14 Mar 2019 10:24:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552584249; cv=none; d=google.com; s=arc-20160816; b=1Jv3jF8DUVRBgZJC7WQ1hvOy4UDbVlmY6J96wMPAok3zBoKoyNEUf6/LogemOAgNXN EOYmflT5Up+gFj/nDmIMauFpyfk9nwelSVTkcFrYOaGrwug7ydDOZ7x8819460/1dnlO GfA3XRc8ZwaUNiEzz1CLDsfO9/MTJbucV182RDs6NlDFcUnsc0RqLDKrlzKcQ1PVyxwB 8r5VAwNRPnyTbXXjO6epZF338j1GEHrgwF772FOQ75bSIFINHy1VP4nMo6mSkYG0tVoq bp4UntPLlkWtZZZRlLsXRzrxX/MjV1oDV2xI+dNj5NM5dfJMSkzESI+W5ykG3nXVanml MUzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=z8CbQxiza2dzwdEkJdPXuIJcsxegcaVvYz7Xlbqt+TA=; b=DeKIBCjsBIk3vU8v/peg4X666MaFdrGA1UVUSd5cYFi2457gJxou/bePs8XBnd5AoS iE1arTO4A35fIVhNAupc67FmRERxhP56VdlrA60GjEuUr45Mm5Z9OGjjmIBN1YiCPe/0 pjpZip+Ar/1eueIZrowDqKxa3r1nkXzmikpsi+8G/2DTFWiITGabASsEV6bpHb9f6q+6 waFW34iG1UOv3gNwaY86M6bES2mTCR+lJi1TenU2dGQg/642gvSJtcSZIoIzR8VLm+U1 nlqtJ6KYzY9363Cvmged06lnpIuN0FAkfdmjHgmBtwvC1PEmIEGaF69Trbi1RgJ/zoe+ sKcQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ba1si7051599plb.331.2019.03.14.10.23.53; Thu, 14 Mar 2019 10:24:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727552AbfCNRXO (ORCPT + 99 others); Thu, 14 Mar 2019 13:23:14 -0400 Received: from lilium.sigma-star.at ([109.75.188.150]:53174 "EHLO lilium.sigma-star.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727012AbfCNRXO (ORCPT ); Thu, 14 Mar 2019 13:23:14 -0400 Received: from localhost (localhost [127.0.0.1]) by lilium.sigma-star.at (Postfix) with ESMTP id 06E4C1802DF6C; Thu, 14 Mar 2019 18:16:18 +0100 (CET) From: Richard Weinberger To: linux-mtd@lists.infradead.org Cc: linux-fscrypt@vger.kernel.org, jaegeuk@kernel.org, tytso@mit.edu, linux-unionfs@vger.kernel.org, miklos@szeredi.hu, amir73il@gmail.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, paullawrence@google.com, Richard Weinberger Subject: [PATCH 3/4] ubifs: Simplify fscrypt_get_encryption_info() error handling Date: Thu, 14 Mar 2019 18:15:58 +0100 Message-Id: <20190314171559.27584-4-richard@nod.at> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190314171559.27584-1-richard@nod.at> References: <20190314171559.27584-1-richard@nod.at> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org fscrypt_get_encryption_info() does not return -ENOKEY, there is no need to handle this case. Signed-off-by: Richard Weinberger --- fs/ubifs/dir.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c index 5767b373a8ff..b0cb913697c5 100644 --- a/fs/ubifs/dir.c +++ b/fs/ubifs/dir.c @@ -526,7 +526,7 @@ static int ubifs_readdir(struct file *file, struct di= r_context *ctx) =20 if (encrypted) { err =3D fscrypt_get_encryption_info(dir); - if (err && err !=3D -ENOKEY) + if (err) return err; =20 err =3D fscrypt_fname_alloc_buffer(dir, UBIFS_MAX_NLEN, &fstr); @@ -794,7 +794,7 @@ static int ubifs_unlink(struct inode *dir, struct den= try *dentry) =20 if (ubifs_crypt_is_encrypted(dir)) { err =3D fscrypt_get_encryption_info(dir); - if (err && err !=3D -ENOKEY) + if (err) return err; } =20 @@ -904,7 +904,7 @@ static int ubifs_rmdir(struct inode *dir, struct dent= ry *dentry) =20 if (ubifs_crypt_is_encrypted(dir)) { err =3D fscrypt_get_encryption_info(dir); - if (err && err !=3D -ENOKEY) + if (err) return err; } =20 --=20 2.21.0