Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 14 Mar 2019 18:27:35 +0100
From:   Tomasz Duszynski <tduszyns@gmail.com>
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     Jonathan Cameron <jic23@kernel.org>,
        Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        Tomasz Duszynski <tduszyns@gmail.com>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: pms7003: sleect IIO_TRIGGERED_BUFFER
Message-ID: <20190314172733.GA23693@arch>
References: <20190314090118.312040-1-arnd@arndb.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20190314090118.312040-1-arnd@arndb.de>
User-Agent: Mutt/1.11.4 (2019-03-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Mar 14, 2019 at 10:00:52AM +0100, Arnd Bergmann wrote:
> Without IIO_TRIGGERED_BUFFER, this driver fails to link:

Good catch, thanks (btw, perhaps typo in subject can be fixed before
applying patch).

Acked-by: Tomasz Duszynski <tduszyns@gmail.com>

>
> drivers/iio/chemical/pms7003.o: In function `pms7003_probe':
> pms7003.c:(.text+0x21c): undefined reference to `devm_iio_triggered_buffer_setup'
> pms7003.c:(.text+0x21c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `devm_iio_triggered_buffer_setup'
>
> Fixes: a1d642266c14 ("iio: chemical: add support for Plantower PMS7003 sensor")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/iio/chemical/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/chemical/Kconfig b/drivers/iio/chemical/Kconfig
> index d5d146e9e372..6f253092a523 100644
> --- a/drivers/iio/chemical/Kconfig
> +++ b/drivers/iio/chemical/Kconfig
> @@ -64,6 +64,7 @@ config IAQCORE
>  config PMS7003
>  	tristate "Plantower PMS7003 particulate matter sensor"
>  	depends on SERIAL_DEV_BUS
> +	select IIO_TRIGGERED_BUFFER
>  	help
>  	  Say Y here to build support for the Plantower PMS7003 particulate
>  	  matter sensor.
> --
> 2.20.0
>