Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Andrey Abramov <st5pub@yandex.ru>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        George Spelvin <lkml@sdf.org>
Cc:     "geert@linux-m68k.org" <geert@linux-m68k.org>,
        "13@sdf.org" <13@sdf.org>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "daniel.wagner@siemens.com" <daniel.wagner@siemens.com>,
        "dchinner@redhat.com" <dchinner@redhat.com>,
        "don.mullis@gmail.com" <don.mullis@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux@rasmusvillemoes.dk" <linux@rasmusvillemoes.dk>
In-Reply-To: <20190314121811.GY9224@smile.fi.intel.com>
References: <cover.1552097842.git.lkml@sdf.org>
         <dc6cc09e71f8687ff2ef4cbfc2b11accc9aba8aa.1552097842.git.lkml@sdf.org>
         <20190309140653.GO9224@smile.fi.intel.com>
         <201903091553.x29FrfMR018600@sdf.org>
         <20190314092958.GV9224@smile.fi.intel.com>
         <201903141009.x2EA9q1Z025888@sdf.org>
         <CAMuHMdW0jd-oNtgBf=aHfzVoBbVh0OJYC6ELhDv3VrcGwUECwA@mail.gmail.com>
         <201903141153.x2EBrtKi000133@sdf.org> <20190314121811.GY9224@smile.fi.intel.com>
Subject: Re: [PATCH 1/5] lib/sort: Make swap functions more generic
MIME-Version: 1.0
Date:   Thu, 14 Mar 2019 22:59:55 +0300
Message-Id: <1145741552593595@sas2-2074c606c35d.qloud-c.yandex.net>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset=utf-8
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> Pistols at dawn?

> swap_bytes
> swap_4byte_words
> swap_8byte_words
or
>  swap_bytes / swap_ints / swap_longs
>  swap_1 / swap_4 / swap_8

Yes, in my opinion, swap_bytes / swap_ints / swap_longs are the most readable because we have both swap_ints and swap_longs functions (in one file near each other), so I don't think that there will be any confusion about size. 
But actually, it doesn't matter which name will you take, because the meaning of each, in my opinion, is obvious enough, so I don't mind about any of these options.

-- 
With Best Regards,
Andrey Abramov