Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190314064525.15756-1-kjlu@umn.edu>
In-Reply-To: <20190314064525.15756-1-kjlu@umn.edu>
From:   Vaibhav Agarwal <vaibhav.sr@gmail.com>
Date:   Fri, 15 Mar 2019 10:49:46 +0530
Message-ID: <CAAs364_6MpywkbsFdZrT5TEdrD8+u1eTmg-8_KY0dypy_PgMxQ@mail.gmail.com>
Subject: Re: [PATCH] greybus: audio_manager: fix a missing check of ida_simple_get
To:     Kangjie Lu <kjlu@umn.edu>
Cc:     pakki001@umn.edu, Mark Greer <mgreer@animalcreek.com>,
        Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        greybus-dev@lists.linaro.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Mar 14, 2019 at 12:15 PM Kangjie Lu <kjlu@umn.edu> wrote:
>
> ida_simple_get could fail. The fix inserts a check for its
> return value.
>
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
> ---
>  drivers/staging/greybus/audio_manager.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/staging/greybus/audio_manager.c b/drivers/staging/greybus/audio_manager.c
> index d44b070d8862..c2a4af4c1d06 100644
> --- a/drivers/staging/greybus/audio_manager.c
> +++ b/drivers/staging/greybus/audio_manager.c
> @@ -45,6 +45,9 @@ int gb_audio_manager_add(struct gb_audio_manager_module_descriptor *desc)
>         int err;
>
>         id = ida_simple_get(&module_id, 0, 0, GFP_KERNEL);
> +       if (id < 0)
> +               return id;
> +
>         err = gb_audio_manager_module_create(&module, manager_kset,
>                                              id, desc);
>         if (err) {

Reviewed-by: Vaibhav Agarwal <vaibhav.sr@gmail.com>

--
./va