Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 15 Mar 2019 10:09:50 +0100
From:   Peter Zijlstra <peterz@infradead.org>
To:     Thomas =?iso-8859-1?Q?M=FCller?= <thomas@mathtm.de>
Cc:     linux-kernel@vger.kernel.org
Subject: Re: disabling secondary CPU hangs / system fails to suspend with
 kernel 4.19+
Message-ID: <20190315090950.GT5996@hirez.programming.kicks-ass.net>
References: <5c48095e-028a-404f-aaa1-964f83c83817@mathtm.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <5c48095e-028a-404f-aaa1-964f83c83817@mathtm.de>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Mar 14, 2019 at 04:17:28PM +0100, Thomas M?ller wrote:
> Hi,
> 
> starting with kernel 4.19 my Lenovo ThinkPad X1 Carbon 5th no longer properly suspends.
> 
> This is 100% reproducible and git bisect points to the following commit:
> > [be45bf5395e0886a93fc816bbe41a008ec2e42e2] watchdog/softlockup: Fix cpu_stop_queue_work() double-queue bug
> > be45bf5395e0886a93fc816bbe41a008ec2e42e2 is the first bad commit
> > commit be45bf5395e0886a93fc816bbe41a008ec2e42e2
> > Author: Peter Zijlstra <peterz@infradead.org>
> > Date:   Fri Jul 13 12:42:08 2018 +0200
> > 
> >     watchdog/softlockup: Fix cpu_stop_queue_work() double-queue bug
> >     
> >     When scheduling is delayed for longer than the softlockup interrupt
> >     period it is possible to double-queue the cpu_stop_work, causing list
> >     corruption.
> >     
> >     Cure this by adding a completion to track the cpu_stop_work's
> >     progress.
> >     
> >     Reported-by: kernel test robot <lkp@intel.com>
> >     Tested-by: Rong Chen <rong.a.chen@intel.com>
> >     Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> >     Cc: Linus Torvalds <torvalds@linux-foundation.org>
> >     Cc: Peter Zijlstra <peterz@infradead.org>
> >     Cc: Thomas Gleixner <tglx@linutronix.de>
> >     Fixes: 9cf57731b63e ("watchdog/softlockup: Replace "watchdog/%u" threads with cpu_stop_work")
> >     Link: http://lkml.kernel.org/r/20180713104208.GW2494@hirez.programming.kicks-ass.net
> >     Signed-off-by: Ingo Molnar <mingo@kernel.org>
> > 
> > :040000 040000 6aca2dbb84bc33fe442b18b3d0a135c27adff7b9 2710af12d32e4b98df07768716689b213bce45fc M      kernel
> 
> The bugzilla reports have some additional details:
> * https://bugzilla.redhat.com/show_bug.cgi?id=1671504
> * https://bugzilla.kernel.org/show_bug.cgi?id=202679
> * https://bugzilla.kernel.org/show_bug.cgi?id=202137
> 
> I'm happy to provide additional information or test a patch or two (as long as it doesn't
> eat up my notebook ;))

I obviously cannot reproduce :/ Both cpu-hotplug and suspend works just
fine on my test boxes. I even tried my thinkpad (x240) and that too goes
to sleep and wakes up just fine.

What .config do you have? And what, if anything do you see on the
console when it goes funny?

I think you wrote that hot-un-plug never completes? Is there anything in
dmesg when it's stuck in:

  echo 0 > /sys/devices/system/cpu/cpu1/online

?