Received: by 2002:ac0:a874:0:0:0:0:0 with SMTP id c49csp373896ima; Fri, 15 Mar 2019 04:56:22 -0700 (PDT) X-Google-Smtp-Source: APXvYqxtuu2FsL9ji7gRuHAwsUhDbLAaEEt1JkhvFUPXqpLmvwytvfHIL5slqPWeLbaNJKAau4p5 X-Received: by 2002:a63:e553:: with SMTP id z19mr3001097pgj.331.1552650982534; Fri, 15 Mar 2019 04:56:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552650982; cv=none; d=google.com; s=arc-20160816; b=Z910oTpwYV0T6q24sn61GpfC+Vmd1QjOnxFjDk8Xbbmx0I27rhMAzs8sZ3rcFYoooG ZzQy1MykFsQpoiDUgApZz94lcx+l8NyEt8vgBNSsSerYSH1WH5iyYmP+YSpkel8E+afE Bbcn5vRZQLo8G7P9LG+9NlPrn3qwtee04sw9fmgr8GnLeDKd6xHaV9PnNaDd+732svmh cHapwMUEOfCDU3t2Y3u4im6EglGTnZemA9J52bNjAOx8bw6+PzApboqZlCGpUKj7O+fe RUJhQoYS1/qm1iPV8/8FgkhahZ6tLnlp32Dlxqo3z28mQumaORSS2wIiWErOohHgJvNG EQTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organisation:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ko5Fw2oGT6v4aDnn2Wx/jCWgQbXT9GR0wyKEcqhi4TM=; b=F81frM0BJNwBxGoGHSERmdZU+lvxKBWMaz8kHMYdo8/8z9ZbFRmTsStjwtZeSHjNit wQrPhZMJG7sSOjB3JTGHkVNGUbTbsTveNfZHq+QIzE5niiCcQZCz4JHJSxx/ZJy/3ebw Gl6zYyw96V53H9AhfLeezyNXvR2m9Z8W2LmncNm4JRDxHdfFEgektQkDoYpOnB/vgB46 bdZ814K3ADgIpXh76VNngvpFOa9pECmEFbuPjWZ8fSMa+58WIW0QwlsKlxJE4RyPCvVH GzweeiQ/tHi3mvCxUf7MzMkLTcXW+8LqltsgObO88n0gs5MZN0AG3I0uBkXE8/cniU0z e5/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@verge.net.au header.s=mail header.b=BQv2h3bo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u17si1749907pfm.82.2019.03.15.04.56.07; Fri, 15 Mar 2019 04:56:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@verge.net.au header.s=mail header.b=BQv2h3bo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728105AbfCOLyL (ORCPT + 99 others); Fri, 15 Mar 2019 07:54:11 -0400 Received: from kirsty.vergenet.net ([202.4.237.240]:35689 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726996AbfCOLyL (ORCPT ); Fri, 15 Mar 2019 07:54:11 -0400 Received: from reginn.horms.nl (watermunt.horms.nl [80.127.179.77]) by kirsty.vergenet.net (Postfix) with ESMTPA id 764A625BE91; Fri, 15 Mar 2019 22:54:08 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=verge.net.au; s=mail; t=1552650848; bh=Xs2Ph133XYLhEoYXMwjQPOrR2LlELLZNfoVn2ClUQUs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BQv2h3boxdUCOD8wKLfWWRCDjUy0u9Jt+laaMGIzRKgAd74QpWlNRe0Ur0dkZko7s y5zfoUaf49JLWo37HgXEoQpNQDRQ4AEVZ6Xfv9zFSC2aEmgV1eiSTm93cL39tyoa8s 5MOGFn3zBhCS9h8e0KIdP6cVKTg3mpIiV9ygGdsA= Received: by reginn.horms.nl (Postfix, from userid 7100) id CEBCA9403F2; Fri, 15 Mar 2019 12:54:06 +0100 (CET) Date: Fri, 15 Mar 2019 12:54:06 +0100 From: Simon Horman To: Kangjie Lu Cc: Lorenzo Pieralisi , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] pci: pcie-rcar: fix a potential NULL pointer dereference Message-ID: <20190315115406.h7pgtvnzzl6ytavr@verge.net.au> References: <20190315072943.22923-1-kjlu@umn.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190315072943.22923-1-kjlu@umn.edu> Organisation: Horms Solutions BV User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 15, 2019 at 02:29:43AM -0500, Kangjie Lu wrote: > In case __get_free_pages fails and returns NULL, the fix returns > -ENOMEM and releases resources to avoid NULL pointer dereference. > > Signed-off-by: Kangjie Lu > Reviewed-by: Geert Uytterhoeven Reviewed-by: Simon Horman