Received: by 2002:ac0:a874:0:0:0:0:0 with SMTP id c49csp692147ima;
        Fri, 15 Mar 2019 11:55:12 -0700 (PDT)
X-Google-Smtp-Source: APXvYqwfjADxoTY5C1FA7npjU2xl8IJcsyBc9LpjtLb3RwT37dk2wlzWkiN5n/WuUARZIAcbByMa
X-Received: by 2002:a62:5959:: with SMTP id n86mr5493015pfb.237.1552676112569;
        Fri, 15 Mar 2019 11:55:12 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1552676112; cv=none;
        d=google.com; s=arc-20160816;
        b=cGwIMmOU7XfmUj5zRLz1PB7vxVOE46RravGRfbwENmyQIdzpSgDSGDFscHjFRZKcRn
         TDVFntz6GTIEG3i2S62mSdoafGEOmj+ZFaB6oiXXrA8n8Hqmmi+oNW9fRuQMFvANnwaL
         Ui6FUsT2gWoFnR7fY8iUl9PSB5VsHZ95mRAivK952f6/xX0krDwqBT/MZ3yBIjKyWROO
         cF0dKTzWq3o+feAfbPCJgtJ4XiSfXqoC51AYqYdFEcYvlkSTxhy5kp43/6NTQpPNYXhI
         bP3CIUOd1yn9cuMuj8HOWLNtpojybWi8GKtf1BSbOzkr4FfbjnsdOP4baNdaPuINnq/o
         cIEA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:from:subject:cc:to:message-id:date;
        bh=lh74V/MKnAQIe4rirPf2cqb4EhNDQLGxzs+s0YulKpU=;
        b=M9jInoS0zWfXlDB9MmRfrXPxdxbJNx7h3LbFmI+r3XhyN/Q5TrMuO1y7CnOqn5R5z8
         yr+0Q3ApYLMtFaYC1BJLFbQqDt1uShZlyMBFir9zyd0mGJRARplU5ysqG0KEkzs4nvYt
         cK5OC70Rtc+1qdihltBXCRCChcvrOAUuuYFW5wKtrkGYvlxfWVswD4DGy5yd4Igm/mAy
         bBi6hUg2ZdClEDpyR4dJIYD3tF2NNlGIb52RY3JZR7PFcGkGP1qEFwsf5Igbchge9kAT
         OSBwKX4Au2qMsg8bbvx0dcOrjpNWdnm6JQCMbJYgtiwNwrLLXSQkeTY4B7rL4rA2eYTm
         7m2Q==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id e10si2438578pgm.298.2019.03.15.11.54.57;
        Fri, 15 Mar 2019 11:55:12 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726833AbfCOSyN (ORCPT <rfc822;schlichte.alexander@gmail.com>
        + 99 others); Fri, 15 Mar 2019 14:54:13 -0400
Received: from shards.monkeyblade.net ([23.128.96.9]:60462 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725956AbfCOSyM (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 15 Mar 2019 14:54:12 -0400
Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 1526614D9FA65;
        Fri, 15 Mar 2019 11:54:12 -0700 (PDT)
Date:   Fri, 15 Mar 2019 11:54:11 -0700 (PDT)
Message-Id: <20190315.115411.1313963626415405289.davem@davemloft.net>
To:     jeremy@azazel.net
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vti4: ipip tunnel deregistration fixes.
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20190314161333.6550-1-jeremy@azazel.net>
References: <20190314161333.6550-1-jeremy@azazel.net>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 15 Mar 2019 11:54:12 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Jeremy Sowden <jeremy@azazel.net>
Date: Thu, 14 Mar 2019 16:13:33 +0000

> If tunnel registration failed during module initialization, the module
> would fail to deregister the IPPROTO_COMP protocol and would attempt to
> deregister the tunnel.
> 
> The tunnel was not deregistered during module-exit.
> 
> Fixes: d9ee3444014e ("vti4: Fix a ipip packet processing bug in 'IPCOMP' virtual tunnel")
> Signed-off-by: Jeremy Sowden <jeremy@azazel.net>

Please resubmit and properly CC: the IPSEC maintainer (as per
MAINTAINERS) on all of your vti changes.

Thank you.