Received: by 2002:ac0:a874:0:0:0:0:0 with SMTP id c49csp736134ima; Fri, 15 Mar 2019 12:58:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqwsBrmMJgmErBzW/pyN7ZqyRZ2CHvLdixMFNCB89XrMXftqbps/9yx8Wv1I/iG0MyDnhZQd X-Received: by 2002:a63:d70a:: with SMTP id d10mr5098243pgg.286.1552679920079; Fri, 15 Mar 2019 12:58:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552679920; cv=none; d=google.com; s=arc-20160816; b=DSte17rc7LsdojkC9NwVnXKQB84FhGN4cyJeG4M144HF+0wYhYPgUVG6pIgX5OfTZe 4gI7qDGOsM3BN4KyWW99GJ0SUKewvNAAZRhKIWBBdK3k4w+qRucBFlRehpwV326V3OTR tI56M3ynn6X5xzPFZVwIxUyX/aCWx3N2dPtaP9mO0A0Fze+CjamcqbxVEnbby2ATKsGc 8AT31uuFD/iKjm9d/t8w4hyu6htXZ3wPGEiNZW5GHoFx983rcadxNTg1Erhiauvw/zeG EVb77kO8NxqlNtrqIFiNpSq1SUaIKg3cTryblXqLRGqE+w36BLmAfCxFzlhhcew9SshD z7XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=Clk15eiNhmAw54HoYpcsn0kut7Zgwf0dAEOj5MPSBxw=; b=o1lwJ3SR2Y+KarA0rFAx0UE9ZcZ6hvbVM2DddkxPuZ7BPCEcBLQpaSmo7Bh6OUxGRm xX1YsqC2nxqCr72eE8kP+SmyTkEz4f7DXhB8N0CJOumO7YYMVaCMVjqi8uGAe4AXUH23 f2pakeXtyXZpbdMicZz6e19+/xmBR1AEgnlNAc02EuKYlV6jyKLPCJD7aBFXDbypRxXV tGLBEvaVnyM//WLY95mA3D/X6JxixKDqvB6dMsQol/6fkSALv+NeclOHiS+ntx5WnBg6 YmFaoLQULUC22BruCOuO11Xc2beOVRK6tEdJZxfO6irupQeENJsxpN6jHscQyCu+xcsc MNLQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c2si2462841pll.317.2019.03.15.12.58.25; Fri, 15 Mar 2019 12:58:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726465AbfCOT4j (ORCPT + 99 others); Fri, 15 Mar 2019 15:56:39 -0400 Received: from mga05.intel.com ([192.55.52.43]:26446 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725929AbfCOT4j (ORCPT ); Fri, 15 Mar 2019 15:56:39 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Mar 2019 12:56:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,483,1544515200"; d="scan'208";a="134722102" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by fmsmga007.fm.intel.com with ESMTP; 15 Mar 2019 12:56:36 -0700 Received: from andy by smile with local (Exim 4.92) (envelope-from ) id 1h4swV-0004X8-77; Fri, 15 Mar 2019 21:56:35 +0200 Date: Fri, 15 Mar 2019 21:56:35 +0200 From: Andy Shevchenko To: Andrey Abramov Cc: Geert Uytterhoeven , George Spelvin , Andrew Morton , Daniel Wagner , Dave Chinner , Don Mullis , Linux Kernel Mailing List , Rasmus Villemoes Subject: Re: [PATCH 4/5] lib/list_sort: Simplify and remove MAX_LIST_LENGTH_BITS Message-ID: <20190315195635.GI9224@smile.fi.intel.com> References: <20190314091041.GU9224@smile.fi.intel.com> <201903150433.x2F4X9oT024601@sdf.org> <201903151023.x2FANDVY013031@sdf.org> <201903151659.x2FGxi3R012970@sdf.org> <23331552675987@myt2-66bcb87429e6.qloud-c.yandex.net> <20190315190614.GH9224@smile.fi.intel.com> <69031552677833@myt1-e20b74e6250c.qloud-c.yandex.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <69031552677833@myt1-e20b74e6250c.qloud-c.yandex.net> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 15, 2019 at 10:23:53PM +0300, Andrey Abramov wrote: > 15.03.2019, 22:06, "Andy Shevchenko" : > > It makes harder to read and understand the code. One needs spend deciseconds / > > seconds to catch instead of santiseconds of time. > > If it is true for someone (for example, for me it is almost as readable > as a simple size_t), then I agree with Geert who said: "use size_t everywhere". We already spent too much on bikeshedding here. -- With Best Regards, Andy Shevchenko