Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 15 Mar 2019 15:05:54 -0700
From:   Stanislav Fomichev <sdf@fomichev.me>
To:     Ivan Vecera <ivecera@redhat.com>
Cc:     netdev@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        "open list:BPF (Safe dynamic programs and tools)" 
        <bpf@vger.kernel.org>, open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] selftests: bpf: modify urandom_read and link it
 non-statically
Message-ID: <20190315220554.GA7431@mini-arch.hsd1.ca.comcast.net>
References: <20190315200414.32346-1-ivecera@redhat.com>
 <20190315200847.GC5481@mini-arch.hsd1.ca.comcast.net>
 <2dcdc11c-4d04-4b0e-ddb7-04d969d04651@redhat.com>
 <20190315205652.GD5481@mini-arch.hsd1.ca.comcast.net>
 <1595006055.9467881.1552686646726.JavaMail.zimbra@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1595006055.9467881.1552686646726.JavaMail.zimbra@redhat.com>
User-Agent: Mutt/1.11.3 (2019-02-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 03/15, Ivan Vecera wrote:
> 
> ----- Stanislav Fomichev <sdf@fomichev.me> wrote:
> > On 03/15, Ivan Vecera wrote:
> > > On 15. 03. 19 21:08, Stanislav Fomichev wrote:
> > > > On 03/15, Ivan Vecera wrote:
> > > > > After some experiences I found that urandom_read does not need to be
> > > > > linked statically. When the 'read' syscall call is moved to separate
> > > > > non-inlined function then bpf_get_stackid() is able to find
> > > > > the executable in stack trace and extract its build_id from it.
> > > > But why? Do you have some problems with it being linked statically?
> > > > 
> > > Dependency... you don't need to install static glibc to compile the bpf
> > > samples. Shared libc is available everytime.
> > Oh, the distros that do -devel _and_ -static packages :-)
> > 
> > So your patch essentially adds a call, that leaves a trace on the stack
> > with our build-id. I guess that works as well.
> 
> Without that additional call this does not work and build_id selftest fails.
Oh, yeah, I was just trying to clarify why it fails without -static and why
your patch makes it work for non-static :-)
You can put more details in the commit message; you'd have to resubmit
whenever net-next/bpf-next opens anyway.

> 
> I.