Received: by 2002:ac0:950e:0:0:0:0:0 with SMTP id f14csp131393imc; Fri, 15 Mar 2019 19:14:06 -0700 (PDT) X-Google-Smtp-Source: APXvYqzfbFFReulh4bFKL3wfrMXyS/MOOnIVLmpyUI71SCr7fF7akIJIxibrQ3NHq8jluDb2Sugq X-Received: by 2002:a65:5c01:: with SMTP id u1mr6472044pgr.197.1552702446538; Fri, 15 Mar 2019 19:14:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552702446; cv=none; d=google.com; s=arc-20160816; b=KELHibzzu2BfUrQI9/ejyk+vhiRT6BiO0yACyeArGEP/S8pqM1SQmvknwvH5ZP3JMZ FMSzMipgRQIisziPa2iafrKLuODzubtj9upaOpvYW/IHtUdKsMG/tEUa6YFnLlTJwZaO Mdu0WpEm1dESAdryxdIk7NEMdGiqNWMPhewqJnXdZOylN3Ek7CXN4ZSnKS2qvWuGp4fI sCnxNNQxSVBrt5E8xsJcEorNdLgKOVzCLYS1EiSbk2cIgLqm5xLyCBJsATcaWhAh0CQn 9rVl2TuNTpYmskAhFYPNpawxbhYmUy4KjlY7TRe812bexxJYnBSWmvcJ1uzOGyD0/o5K DufQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=JHBZKH3Jy7ARadEyMRlSjyeitnQMzq6bw+SZjLu97T4=; b=dvYmJ17la7FTruigbeC9S5yTggjs/IBFly9ZPFfFhXdBvnbcWW7dBMxik4p3b4Di/5 5wmGDcy2y2hkS4i0gvLJsPzx4FkE9JfxomkCOsLh5gsvx81+vF6z8pyXZPruS5u09mcV LAvEGfQvD732PAYEUgjulBpQx6aWymmqZWdt59rkfhSyiTO2izc65jeMdsbJygYc+9sS 6kjsLS7mx66RUaXDTpqaXxdqhFPg0SHuOa6jpnpYdO5Qxp6njKlnCFv1UlQyEqW8xB23 a9De3e56iNpB9vUQK5EJ2fMZ/umD13Qz9qidDia6HsA/eETk147jO4oJUX49hYr4oN5q CL2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=cvZjHPzL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cv7si3452850plb.322.2019.03.15.19.13.51; Fri, 15 Mar 2019 19:14:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=cvZjHPzL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726720AbfCPCMd (ORCPT + 99 others); Fri, 15 Mar 2019 22:12:33 -0400 Received: from mail-yw1-f65.google.com ([209.85.161.65]:44079 "EHLO mail-yw1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726444AbfCPCMd (ORCPT ); Fri, 15 Mar 2019 22:12:33 -0400 Received: by mail-yw1-f65.google.com with SMTP id c4so8774548ywa.11; Fri, 15 Mar 2019 19:12:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=JHBZKH3Jy7ARadEyMRlSjyeitnQMzq6bw+SZjLu97T4=; b=cvZjHPzL+ZpMXLZHfshjz+WcEKjG8JIs8iUsnlyf6KaFo/+NROx0+dvSdXcj8n3oBE OHNwsRBK5jmZ1jWcbkhUnXu2EsAoeQizFYd5j740JffadIxgLrgu5w8gUL3gD0nYtgsm tH5VD0OpEWyP0RnP9+Rqss60a9vBL43L49mjtNyByLNK7ESCW81VHXlvjEYq0Cu+Y7Yj aj18QO1QINDgCxZGkk20E4irozODjFR7Akdr8e1YeBeNxGVaqiZl5zDmPLfQAjxcpNI1 kwSb8Dko6+iDDoPbn0p2w7RavnBmrSm5Q4M39iO5f0QSQFLxjtOFKBE6dULFPXOSj8dz +AZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=JHBZKH3Jy7ARadEyMRlSjyeitnQMzq6bw+SZjLu97T4=; b=XlOoYC5f6aJUvmOCSNQWxK1G7hD01VfAdq1hnakojdbRqZSfUbZXIG6YH1ov6HA0uF gaOOmexXCKV9ZW4nnuhekEknlaQNKRWGQSDChxOfVn0VXmPii5NpVVH1Gn/ZfgUgjfpt vHiDV3P8vk8Plw1gDsbvixW0qNELsnw58UACguO9NHI9VUh/XQtyhcdx4tBsxDhFs/hw g5ZxwbphUxfepevDZcnY0/reaHmgprLzpnw4HEuGUpizf6lxYHv36ohF7ogtIrk2iqey 6zi5wRTy+/x93jZVnVQG3KyeS6BqZ68Nh1IhznKEIbPYbcN1jLdUjhzPD3UIj8diqrHO eeRA== X-Gm-Message-State: APjAAAUBRKEXWkaBWdhlmhRTqzS0Tl5xZRVKUZnsHAJXnZJcpYsDy+Ut gAEklmPk9zCDEtiyYCecBZU= X-Received: by 2002:a0d:eec3:: with SMTP id x186mr5567903ywe.264.1552702352187; Fri, 15 Mar 2019 19:12:32 -0700 (PDT) Received: from renatolg ([186.220.21.102]) by smtp.gmail.com with ESMTPSA id l123sm1408447ywb.59.2019.03.15.19.12.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 15 Mar 2019 19:12:31 -0700 (PDT) Date: Fri, 15 Mar 2019 23:12:27 -0300 From: Renato Lui Geh To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, knaack.h@gmx.de, pmeerw@pmeerw.net, gregkh@linuxfoundation.org, stefan.popa@analog.com, alexandru.Ardelean@analog.com, giuliano.belinassi@usp.br, robh+dt@kernel.org, mark.rutland@arm.com Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com, devicetree@vger.kernel.org Subject: [PATCH v5 01/11] staging: iio: ad7780: add gain & filter gpio support Message-ID: <2687836c5b442990ee50d4efe787a3927c750bbc.1552700652.git.renatogeh@gmail.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Previously, the AD7780 driver only supported gpio for the 'powerdown' pin. This commit adds suppport for the 'gain' and 'filter' pin. Signed-off-by: Renato Lui Geh Signed-off-by: Giuliano Belinassi Co-developed-by: Giuliano Belinassi --- Changes in v3: - Renamed ad7780_chip_info's filter to odr - Renamed ad778x_filter to ad778x_odr_avail - Changed vref variable from unsigned int to unsigned long long to avoid overflow - Removed unnecessary AD_SD_CHANNEL macro Changes in v4: - Removed useless macro - Added default case for switch to suppress warning - Removed chunks belonging to filter reading, adding these as a patch for itself Changes in v5: - ad778x_odr_avail moved to filter patch - Split gain reading to its own patch - Init GPIOs in a separate function drivers/staging/iio/adc/ad7780.c | 114 ++++++++++++++++++++++++++----- 1 file changed, 96 insertions(+), 18 deletions(-) diff --git a/drivers/staging/iio/adc/ad7780.c b/drivers/staging/iio/adc/ad7780.c index c4a85789c2db..07e5e35c92a3 100644 --- a/drivers/staging/iio/adc/ad7780.c +++ b/drivers/staging/iio/adc/ad7780.c @@ -39,6 +39,9 @@ #define AD7170_PATTERN (AD7780_PAT0 | AD7170_PAT2) #define AD7170_PATTERN_MASK (AD7780_PAT0 | AD7780_PAT1 | AD7170_PAT2) +#define AD7780_GAIN_MIDPOINT 64 +#define AD7780_FILTER_MIDPOINT 13350 + struct ad7780_chip_info { struct iio_chan_spec channel; unsigned int pattern_mask; @@ -50,7 +53,10 @@ struct ad7780_state { const struct ad7780_chip_info *chip_info; struct regulator *reg; struct gpio_desc *powerdown_gpio; - unsigned int gain; + struct gpio_desc *gain_gpio; + struct gpio_desc *filter_gpio; + unsigned int gain; + unsigned int int_vref_mv; struct ad_sigma_delta sd; }; @@ -104,8 +110,10 @@ static int ad7780_read_raw(struct iio_dev *indio_dev, voltage_uv = regulator_get_voltage(st->reg); if (voltage_uv < 0) return voltage_uv; - *val = (voltage_uv / 1000) * st->gain; + voltage_uv /= 1000; + *val = voltage_uv * st->gain; *val2 = chan->scan_type.realbits - 1; + st->int_vref_mv = voltage_uv; return IIO_VAL_FRACTIONAL_LOG2; case IIO_CHAN_INFO_OFFSET: *val = -(1 << (chan->scan_type.realbits - 1)); @@ -115,6 +123,50 @@ static int ad7780_read_raw(struct iio_dev *indio_dev, return -EINVAL; } +static int ad7780_write_raw(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, + int val, + int val2, + long m) +{ + struct ad7780_state *st = iio_priv(indio_dev); + const struct ad7780_chip_info *chip_info = st->chip_info; + unsigned long long vref; + unsigned int full_scale, gain; + + if (!chip_info->is_ad778x) + return -EINVAL; + + switch (m) { + case IIO_CHAN_INFO_SCALE: + if (val != 0) + return -EINVAL; + + vref = st->int_vref_mv * 1000000LL; + full_scale = 1 << (chip_info->channel.scan_type.realbits - 1); + gain = DIV_ROUND_CLOSEST(vref, full_scale); + gain = DIV_ROUND_CLOSEST(gain, val2); + st->gain = gain; + if (gain < AD7780_GAIN_MIDPOINT) + gain = 0; + else + gain = 1; + gpiod_set_value(st->gain_gpio, gain); + break; + case IIO_CHAN_INFO_SAMP_FREQ: + if (1000*val + val2/1000 < AD7780_FILTER_MIDPOINT) + val = 0; + else + val = 1; + gpiod_set_value(st->filter_gpio, val); + break; + default: + break; + } + + return 0; +} + static int ad7780_postprocess_sample(struct ad_sigma_delta *sigma_delta, unsigned int raw_sample) { @@ -125,13 +177,6 @@ static int ad7780_postprocess_sample(struct ad_sigma_delta *sigma_delta, ((raw_sample & chip_info->pattern_mask) != chip_info->pattern)) return -EIO; - if (chip_info->is_ad778x) { - if (raw_sample & AD7780_GAIN) - st->gain = 1; - else - st->gain = 128; - } - return 0; } @@ -173,8 +218,47 @@ static const struct ad7780_chip_info ad7780_chip_info_tbl[] = { static const struct iio_info ad7780_info = { .read_raw = ad7780_read_raw, + .write_raw = ad7780_write_raw, }; +static int ad7780_init_gpios(struct device *dev, struct ad7780_state *st) +{ + int ret; + + st->powerdown_gpio = devm_gpiod_get_optional(dev, + "powerdown", + GPIOD_OUT_LOW); + if (IS_ERR(st->powerdown_gpio)) { + ret = PTR_ERR(st->powerdown_gpio); + dev_err(dev, "Failed to request powerdown GPIO: %d\n", ret); + return ret; + } + + if (!st->chip_info->is_ad778x) + return 0; + + + st->gain_gpio = devm_gpiod_get_optional(dev, + "adi,gain", + GPIOD_OUT_HIGH); + if (IS_ERR(st->gain_gpio)) { + ret = PTR_ERR(st->gain_gpio); + dev_err(dev, "Failed to request gain GPIO: %d\n", ret); + return ret; + } + + st->filter_gpio = devm_gpiod_get_optional(dev, + "adi,filter", + GPIOD_OUT_HIGH); + if (IS_ERR(st->filter_gpio)) { + ret = PTR_ERR(st->filter_gpio); + dev_err(dev, "Failed to request filter GPIO: %d\n", ret); + return ret; + } + + return 0; +} + static int ad7780_probe(struct spi_device *spi) { struct ad7780_state *st; @@ -212,15 +296,9 @@ static int ad7780_probe(struct spi_device *spi) indio_dev->num_channels = 1; indio_dev->info = &ad7780_info; - st->powerdown_gpio = devm_gpiod_get_optional(&spi->dev, - "powerdown", - GPIOD_OUT_LOW); - if (IS_ERR(st->powerdown_gpio)) { - ret = PTR_ERR(st->powerdown_gpio); - dev_err(&spi->dev, "Failed to request powerdown GPIO: %d\n", - ret); - goto error_disable_reg; - } + ret = ad7780_init_gpios(&spi->dev, st); + if (ret) + goto error_cleanup_buffer_and_trigger; ret = ad_sd_setup_buffer_and_trigger(indio_dev); if (ret) -- 2.21.0