Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jernej =?utf-8?B?xaBrcmFiZWM=?= <jernej.skrabec@siol.net>
To:     Vinod Koul <vkoul@kernel.org>
Cc:     Rob Herring <robh+dt@kernel.org>, maxime.ripard@bootlin.com,
        wens@csie.org, mark.rutland@arm.com, dan.j.williams@intel.com,
        dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-sunxi@googlegroups.com
Subject: Re: [PATCH 1/6] dt-bindings: arm64: allwinner: h6: Add binding for DMA controller
Date:   Sat, 16 Mar 2019 12:27:38 +0100
Message-ID: <1976600.rIVPXpSncm@jernej-laptop>
In-Reply-To: <20190316105711.GG5348@vkoul-mobl>
References: <20190307165829.9086-1-jernej.skrabec@siol.net> <20190307165829.9086-2-jernej.skrabec@siol.net> <20190316105711.GG5348@vkoul-mobl>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Dne sobota, 16. marec 2019 ob 11:57:11 CET je Vinod Koul napisal(a):
> On 07-03-19, 17:58, Jernej Skrabec wrote:
> > DMA in H6 is similar to other DMA controller, except it is first which
> > supports more than 32 request sources and has 16 channels. It also needs
> > additional clock to be enabled.
> 
> Please see DT folks on this patch, when in doubt, use get_maintainers.pl
> Need an ack on this patch before applying

They are already in CC.

> 
> > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> > ---
> > 
> >  Documentation/devicetree/bindings/dma/sun6i-dma.txt | 9 +++++++--
> >  1 file changed, 7 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/dma/sun6i-dma.txt
> > b/Documentation/devicetree/bindings/dma/sun6i-dma.txt index
> > 7fccc20d8331..cae31f4e77ba 100644
> > --- a/Documentation/devicetree/bindings/dma/sun6i-dma.txt
> > +++ b/Documentation/devicetree/bindings/dma/sun6i-dma.txt
> > 
> > @@ -28,12 +28,17 @@ Example:
> >  	};
> >  
> >  -------------------------------------------------------------------------
> >  -----> 
> > -For A64 DMA controller:
> > 
> > +For A64 and H6 DMA controller:
> >  Required properties:
> > -- compatible:	"allwinner,sun50i-a64-dma"
> > +- compatible:	Must be one of
> > +		  "allwinner,sun50i-a64-dma"
> > +		  "allwinner,sun50i-h6-dma"
> > 
> >  - dma-channels: Number of DMA channels supported by the controller.
> >  
> >  		Refer to Documentation/devicetree/bindings/dma/dma.txt
> > 
> > +- clocks:	In addition to parent AHB clock, it should also contain mbus
> > +		clock (H6 only)
> > +- clock-names:	Should contain "bus" and "mbus" (H6 only)
> > 
> >  - all properties above, i.e. reg, interrupts, clocks, resets and
> >  #dma-cells
> >  
> >  Optional properties: