Received: by 2002:ac0:950e:0:0:0:0:0 with SMTP id f14csp634864imc; Sat, 16 Mar 2019 11:01:26 -0700 (PDT) X-Google-Smtp-Source: APXvYqyNNZt3VqUr4SD7Eh4Ymp/sduVHIQuvo8Leqd39h7ZVjDrHBEEx4rxRWUaAv0gWS9N7m6Kp X-Received: by 2002:aa7:90c1:: with SMTP id k1mr10334530pfk.202.1552759286357; Sat, 16 Mar 2019 11:01:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552759286; cv=none; d=google.com; s=arc-20160816; b=aOhDLbQgMLc7eRoA7BI3ff52+Zy7d0mqhdzOACge2dPyMH6xGex5Efir3oKDXNXFer hFHPTQ6bYW/AT0f/Q9f9mm1Tlf14KS36QR+8GEPGgzStQz26+dE2Ce1/fDbgcKf+SEWQ IJVx5R5+tjIk8yBOTldOYgEF2Kp6UqpFdBOPP+lSXWEOKoGXxUq/BELv9PZ86eivBJHM nPr9QNf35BwvZR6cq2h1HoHaK5SLOoHJLJjcPooxT1pa8Mo2D8aoUFmgN3e+xhxRvERG ecuxrUASIzwP2i3wxXmeGgvyUANVbK1C/ATV5mMet7E8GKeC/YbppEhBECWTZEocaxTj Qydw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=y1KWqgI146pcCdR1U2CQh3JRG48myF0xT/kFf++SZRs=; b=YgGE2eBowfoA4oRE8Z5f5CKGm1ZCyVFmnh01r7RF/PN+hl/+Lk7lYKm7W2cv9gAssh xwgWrMNyhl9EyEKSDlgprqLh0lWF329AYozVk0Pv555ExghoZbUyLK1YRxUzeqNpH1ll HxgLSe4fmnAIprNuIPPzoJIHlcRWpxTXZ3Zsmy4hvX+AvMY8fdDyZOvMlp0v7Gt38fLM k1w6XM+z1W36sCt5P0q6XpQu/H+dBK3XTY66rbsH0llZX+zhyVJYsYa2FONcpmXv1rd7 mWLxQCVTuccwuiZmmFWlkMD3juHxJtCdx/QuD4dSnIkVAnkkFCs4T5skEYI+uc2cRr8K /YHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=Coq92k1U; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r11si4550258pgp.433.2019.03.16.11.01.10; Sat, 16 Mar 2019 11:01:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=Coq92k1U; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727126AbfCPSAY (ORCPT + 99 others); Sat, 16 Mar 2019 14:00:24 -0400 Received: from mail-vs1-f65.google.com ([209.85.217.65]:44819 "EHLO mail-vs1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726466AbfCPSAY (ORCPT ); Sat, 16 Mar 2019 14:00:24 -0400 Received: by mail-vs1-f65.google.com with SMTP id b8so7226700vsq.11 for ; Sat, 16 Mar 2019 11:00:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=y1KWqgI146pcCdR1U2CQh3JRG48myF0xT/kFf++SZRs=; b=Coq92k1UdoV5Q253tI8ums9wCkyCqFEN3X7Ant4Okl6f1FVMmVeLNyT88lpfOsYYHp m7boY9BdRcNA6TztSAc3SmEjZOU3cqBGizSS6dFShpFvBCHj9QfGc0sudpXraek+kf5u 0Dm+BnzXD2PF8fPHQUp315YZfEQZr6knDW6OkHhX8csU/feRgnhSICEQ9NkWv8QWW5iy vGAMW5gWcAIRu+8G1q6V7PD2XLM1UxU+DXc1yK4ATZ6qrmgldBu1sIOFRWvt30FBBeTs A8B+gCMYc75LlARyp9pV+JmiKDg+qig+y1WImaBSKJIGrhtklGqoOL+AlDxEizsFxX4V gcHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=y1KWqgI146pcCdR1U2CQh3JRG48myF0xT/kFf++SZRs=; b=Fn2txHD6j48Dkoz2Sqso4YR2FcdsjZ9WqPa+iIBYUfwmPoJNUV//rKiVfzWSRiVex6 qK5acN6N5Yp4NfVAloLMuYUiuYNerTtO6zM0Jms2iz13Ue20tmDhpOvwGwZpq/zdPz/p gqpwutvrcMATEuwP9gqMNZr5YKyR2XH2kERZ7W6CiC7QiM0Qq1NJP8WIh44bmX02DJjn GZAI/99cGJjWzrhLqECfVhKlcjpweiYtGa61ipruODtSsUagwm8mw+4IMgiISewLkTRc gKHgk14rHLuvg68IfiAkztowVQaQ0JU07NPSwEY91miIpHhvbByWURHPD4fwhufoFPqI A9Fw== X-Gm-Message-State: APjAAAWP5knw1yUnxeQ77z8TOtiAj1XDAcqTATWGUT12xEosjcbhoMyH tDtUoVGUCKJmoVeFrIBK5ueD3MaiptFn9UYsAPF18g== X-Received: by 2002:a67:cc2:: with SMTP id 185mr136686vsm.77.1552759222160; Sat, 16 Mar 2019 11:00:22 -0700 (PDT) MIME-Version: 1.0 References: <20190312080532.GE5721@dhcp22.suse.cz> <20190312163741.GA2762@sultan-box.localdomain> <20190314204911.GA875@sultan-box.localdomain> <20190314231641.5a37932b@oasis.local.home> <20190315180306.sq3z645p3hygrmt2@brauner.io> <20190315181324.GA248160@google.com> <20190315182426.sujcqbzhzw4llmsa@brauner.io> <20190315184903.GB248160@google.com> In-Reply-To: From: Daniel Colascione Date: Sat, 16 Mar 2019 11:00:10 -0700 Message-ID: Subject: Re: [RFC] simple_lmk: Introduce Simple Low Memory Killer for Android To: Suren Baghdasaryan Cc: Joel Fernandes , Christian Brauner , Steven Rostedt , Sultan Alsawaf , Tim Murray , Michal Hocko , Greg Kroah-Hartman , =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= , Todd Kjos , Martijn Coenen , Ingo Molnar , Peter Zijlstra , LKML , "open list:ANDROID DRIVERS" , linux-mm , kernel-team Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 16, 2019 at 10:31 AM Suren Baghdasaryan wrote: > > On Fri, Mar 15, 2019 at 11:49 AM Joel Fernandes wrote: > > > > On Fri, Mar 15, 2019 at 07:24:28PM +0100, Christian Brauner wrote: > > [..] > > > > why do we want to add a new syscall (pidfd_wait) though? Why not just use > > > > standard poll/epoll interface on the proc fd like Daniel was suggesting. > > > > AFAIK, once the proc file is opened, the struct pid is essentially pinned > > > > even though the proc number may be reused. Then the caller can just poll. > > > > We can add a waitqueue to struct pid, and wake up any waiters on process > > > > death (A quick look shows task_struct can be mapped to its struct pid) and > > > > also possibly optimize it using Steve's TIF flag idea. No new syscall is > > > > needed then, let me know if I missed something? > > > > > > Huh, I thought that Daniel was against the poll/epoll solution? > > > > Hmm, going through earlier threads, I believe so now. Here was Daniel's > > reasoning about avoiding a notification about process death through proc > > directory fd: http://lkml.iu.edu/hypermail/linux/kernel/1811.0/00232.html > > > > May be a dedicated syscall for this would be cleaner after all. > > Ah, I wish I've seen that discussion before... > syscall makes sense and it can be non-blocking and we can use > select/poll/epoll if we use eventfd. Thanks for taking a look. > I would strongly advocate for > non-blocking version or at least to have a non-blocking option. Waiting for FD readiness is *already* blocking or non-blocking according to the caller's desire --- users can pass options they want to poll(2) or whatever. There's no need for any kind of special configuration knob or non-blocking option. We already *have* a non-blocking option that works universally for everything. As I mentioned in the linked thread, waiting for process exit should work just like waiting for bytes to appear on a pipe. Process exit status is just another blob of bytes that a process might receive. A process exit handle ought to be just another information source. The reason the unix process API is so awful is that for whatever reason the original designers treated processes as some kind of special kind of resource instead of fitting them into the otherwise general-purpose unix data-handling API. Let's not repeat that mistake. > Something like this: > > evfd = eventfd(0, EFD_NONBLOCK | EFD_CLOEXEC); > // register eventfd to receive death notification > pidfd_wait(pid_to_kill, evfd); > // kill the process > pidfd_send_signal(pid_to_kill, ...) > // tend to other things Now you've lost me. pidfd_wait should return a *new* FD, not wire up an eventfd. Why? Because the new type FD can report process exit *status* information (via read(2) after readability signal) as well as this binary yes-or-no signal *that* a process exited, and this capability is useful if you want to the pidfd interface to be a good general-purpose process management facility to replace the awful wait() family of functions. You can't get an exit status from an eventfd. Wiring up an eventfd the way you've proposed also complicates wait-causality information, complicating both tracing and any priority inheritance we might want in the future (because all the wakeups gets mixed into the eventfd and you can't unscramble an egg). And for what? What do we gain by using an eventfd? Is the reason that exit.c would be able to use eventfd_signal instead of poking a waitqueue directly? How is that better? With an eventfd, you've increased path length on process exit *and* complicated the API for no reason. > ... > // wait for the process to die > poll_wait(evfd, ...); > > This simplifies userspace Not relative to an exit handle it doesn't. >, allows it to wait for multiple events using > epoll So does a process exit status handle. > and I think kernel implementation will be also quite simple > because it already implements eventfd_signal() that takes care of > waitqueue handling. What if there are multiple eventfds registered for the death of a process? In any case, you need some mechanism to find, upon process death, a list of waiters, then wake each of them up. That's either a global search or a search in some list rooted in a task-related structure (either struct task or one of its friends). Using an eventfd here adds nothing, since upon death, you need this list search regardless, and as I mentioned above, eventfd-wiring just makes the API worse. > If pidfd_send_signal could be extended to have an optional eventfd > parameter then we would not even have to add a new syscall. There is nothing wrong with adding a new system call. I don't know why there's this idea circulating that adding system calls is something we should bend over backwards to avoid. It's cheap, and support-wise, kernel interface is kernel interface. Sending a signal has *nothing* to do with wiring up some kind of notification and there's no reason to mingle it with some kind of event registration.