Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190315075500.27747-1-longli@linuxonhyperv.com> <20190315075500.27747-2-longli@linuxonhyperv.com>
In-Reply-To: <20190315075500.27747-2-longli@linuxonhyperv.com>
From:   Pavel Shilovsky <piastryyy@gmail.com>
Date:   Sat, 16 Mar 2019 11:03:33 -0700
Message-ID: <CAKywueTOHQq8iEiQRHer7yGstvKEF7SrSgNqmETYV73uEgqA+A@mail.gmail.com>
Subject: Re: [Patch v2 2/2] CIFS: Fix an issue with re-sending rdata when
 transport returning -EAGAIN
To:     Long Li <longli@microsoft.com>
Cc:     Steve French <sfrench@samba.org>,
        linux-cifs <linux-cifs@vger.kernel.org>,
        samba-technical <samba-technical@lists.samba.org>,
        Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

=D0=BF=D1=82, 15 =D0=BC=D0=B0=D1=80. 2019 =D0=B3. =D0=B2 00:56, Long Li <lo=
ngli@linuxonhyperv.com>:
>
> From: Long Li <longli@microsoft.com>
>
> When sending a rdata, transport may return -EAGAIN. In this case
> we should re-obtain credits because the session may have been
> reconnected.
>
> Change in v2: adjust_credits before re-sending
>
> Signed-off-by: Long Li <longli@microsoft.com>
> ---
>  fs/cifs/file.c | 71 +++++++++++++++++++++++++++++++++-------------------=
------
>  1 file changed, 41 insertions(+), 30 deletions(-)
>
> diff --git a/fs/cifs/file.c b/fs/cifs/file.c
> index 321df1d27422..9d90cc07e38b 100644
> --- a/fs/cifs/file.c
> +++ b/fs/cifs/file.c
> @@ -3347,44 +3347,55 @@ static int cifs_resend_rdata(struct cifs_readdata=
 *rdata,
>         struct TCP_Server_Info *server =3D
>                 tlink_tcon(rdata->cfile->tlink)->ses->server;
>
> -       /*
> -        * Wait for credits to resend this rdata.
> -        * Note: we are attempting to resend the whole rdata not in segme=
nts
> -        */
>         do {
> -               rc =3D server->ops->wait_mtu_credits(server, rdata->bytes=
,
> +               if (rdata->cfile->invalidHandle) {
> +                       rc =3D cifs_reopen_file(rdata->cfile, true);
> +                       if (rc =3D=3D -EAGAIN)
> +                               continue;
> +                       else if (rc)
> +                               break;
> +               }
> +
> +               /*
> +                * Wait for credits to resend this rdata.
> +                * Note: we are attempting to resend the whole rdata not =
in
> +                * segments
> +                */
> +               do {
> +                       rc =3D server->ops->wait_mtu_credits(server, rdat=
a->bytes,
>                                                 &rsize, &credits);
>
> -               if (rc)
> -                       goto out;
> +                       if (rc)
> +                               goto fail;
>
> -               if (rsize < rdata->bytes) {
> -                       add_credits_and_wake_if(server, &credits, 0);
> -                       msleep(1000);
> -               }
> -       } while (rsize < rdata->bytes);
> +                       if (rsize < rdata->bytes) {
> +                               add_credits_and_wake_if(server, &credits,=
 0);
> +                               msleep(1000);
> +                       }
> +               } while (rsize < rdata->bytes);
> +               rdata->credits =3D credits;
>
> -       rdata->credits =3D credits;
> -       rc =3D -EAGAIN;
> -       while (rc =3D=3D -EAGAIN) {
> -               rc =3D 0;
> -               if (rdata->cfile->invalidHandle)
> -                       rc =3D cifs_reopen_file(rdata->cfile, true);
> -               if (!rc)
> -                       rc =3D server->ops->async_readv(rdata);
> -       }
> +               rc =3D adjust_credits(server, &rdata->credits, rdata->byt=
es);
> +               if (!rc) {
> +                       if (rdata->cfile->invalidHandle)
> +                               rc =3D -EAGAIN;
> +                       else
> +                               rc =3D server->ops->async_readv(rdata);
> +               }
>
> -       if (!rc) {
> -               /* Add to aio pending list */
> -               list_add_tail(&rdata->list, rdata_list);
> -               return 0;
> -       }
> +               /* If the read was successfully sent, we are done */
> +               if (!rc) {
> +                       /* Add to aio pending list */
> +                       list_add_tail(&rdata->list, rdata_list);
> +                       return 0;
> +               }
>
> -       add_credits_and_wake_if(server, &rdata->credits, 0);
> -out:
> -       kref_put(&rdata->refcount,
> -               cifs_uncached_readdata_release);
> +               /* Roll back credits and retry if needed */
> +               add_credits_and_wake_if(server, &rdata->credits, 0);
> +       } while (rc =3D=3D -EAGAIN);
>
> +fail:
> +       kref_put(&rdata->refcount, cifs_uncached_readdata_release);
>         return rc;
>  }
>
> --
> 2.14.1
>

Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>

--
Best regards,
Pavel Shilovsky