Received: by 2002:ac0:950e:0:0:0:0:0 with SMTP id f14csp667687imc; Sat, 16 Mar 2019 12:03:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqwKYDmL/udS46x/Qa2Pli3ydHGZLlIRrSsxse6bvs3jlq85+rSZY8Wy2BYyQIl2oSZP9OsD X-Received: by 2002:a63:3fc8:: with SMTP id m191mr9754516pga.240.1552763011319; Sat, 16 Mar 2019 12:03:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552763011; cv=none; d=google.com; s=arc-20160816; b=E5Ps1taXg6UDPUJkzn8YQScsCCSO5LGIVhYh6eAh5WwwpK2jE0I3TJFFLbGxnGKwuq hIgjbazE1rrc0miDeQcV9JGiKWm8Xe8kSYbiHzT66UuKS2HLc6qQ5JUS30w+4Bb8pMD1 nSQ8S+UYWpDumfl8y0Utg/7HXzBBUiMtmN0e0c01B4IRUv+u4heCJO2s+BITYv4HiHz/ +ZlD8zuJDefZk16/XpqPsnY9TOUmLX+boVjicvQA2GACc5W1R7NIv/VhTQzr9oy+dz4P 1uYgJYyHO4xyCYCzpgNDDwgVTisNd/zWDaYmnJirLFdqt74S6NiZDUGEoE529kl29g6a ZP3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=i+SQwH322yJvf3ngjcYOioo49D9EyoY/sG76PLp/kJU=; b=xveOyYAqNcRg6DgMejV9uZ9ATboNsbuLGmLsc4IHNeKnrYAe/AqY6seUSbXWJmJsxk ASZpw/A4z7nZQHocXE+9TWeTiDVxIzRvfJzU3PqmeNPoa5kZYQRkz5yQmBS/pDNu2qTF +R1M0jLhnGGpv+n95kjOzA5Mt+i3QQimk2dpBsA4rKA8tzQP9Lqr5qbf+qOmPm+4nON/ ix4WiSek0EDtPXEhfXP54LFX00TVZGaaakx40O+YMs66l71B/d6W/EQdgY7GGa665Dgq N+M8xk2EHesdIQiRUZlDP56GSHAU2W9u3i+h5E8aU0sCU/mx15Oma9kidYLMroVrYaLL i+fA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=TyZdF7jC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c24si5078814pfo.11.2019.03.16.12.03.16; Sat, 16 Mar 2019 12:03:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=TyZdF7jC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727241AbfCPTBK (ORCPT + 99 others); Sat, 16 Mar 2019 15:01:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:54036 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726493AbfCPTBK (ORCPT ); Sat, 16 Mar 2019 15:01:10 -0400 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3A20B218FC for ; Sat, 16 Mar 2019 19:01:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552762869; bh=yPEKZ/ogjKX5/biN/Bau0WOdp5dHwfTZBX0iP0x1HDM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=TyZdF7jCdUeOFZhtv3YLYD4lAdIL8MDDOP7RmsurpOUE6QVOTW4ni2T1G+oztHZQW 3BILe0ERlLOYVDXzE71ju7e4OJoZfhnMCSwtqS8oSSKzJL9dEMYqYLuKCt4nuY2HqW jRmMhIf2XTyW33Mm781YExYHq0CSlrIzpibU0GU0= Received: by mail-wr1-f44.google.com with SMTP id p1so12833993wrs.8 for ; Sat, 16 Mar 2019 12:01:09 -0700 (PDT) X-Gm-Message-State: APjAAAW/5UcANXP/eVI0j4aJZuN1AENCAHV6kJlkzfgeu0xbk+ODmkFX ycNWnmaGqArSBTuC5+0ABYUy0p6qWNddHiKtO/YjfA== X-Received: by 2002:adf:e710:: with SMTP id c16mr6328520wrm.176.1552762867811; Sat, 16 Mar 2019 12:01:07 -0700 (PDT) MIME-Version: 1.0 References: <1552596361-8967-1-git-send-email-tedheadster@gmail.com> In-Reply-To: <1552596361-8967-1-git-send-email-tedheadster@gmail.com> From: Andy Lutomirski Date: Sat, 16 Mar 2019 12:00:49 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/2] x86/CPU: Use correct Cyrix-specific macros To: Matthew Whitehead Cc: LKML , Thomas Gleixner , Ingo Molnar , Andrew Lutomirski Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 14, 2019 at 1:46 PM Matthew Whitehead wrote: > > Replace the incorrect Cyrix-specific macro calls with the correct > setCx86() and getCx86() calls. Also remove the unused setCx86_old(), > getCx86_old() and their related comments in the code. > > Matthew Whitehead (2): > x86/CPU: Use correct macros for Cyrix calls on Geode processors > x86/CPU: Remove {get,set}Cx86_old macros used for Cyrix processors This series looks reasonable to me. Also, Matthew seems to be the best tester around for this old hardware, so, if he says it works, I believe him :) I certainly can't test this stuff. --Andy