Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190309154307.23039-1-ar@cs.msu.ru> <20190309154307.23039-2-ar@cs.msu.ru>
In-Reply-To: <20190309154307.23039-2-ar@cs.msu.ru>
From:   Masahiro Yamada <yamada.masahiro@socionext.com>
Date:   Sun, 17 Mar 2019 12:02:57 +0900
Message-ID: <CAK7LNASRctWUMXG5PSUSG2FMGkQV7jNNcUieUKzxho9r81TU1A@mail.gmail.com>
Subject: Re: [PATCH v2 2/3] scripts/package/mkdebian: avoid implicit effects
To:     Arseny Maslennikov <ar@cs.msu.ru>
Cc:     Michal Marek <michal.lkml@markovi.net>,
        Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Ben Hutchings <ben@decadent.org.uk>,
        Riku Voipio <riku.voipio@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Mar 10, 2019 at 12:44 AM Arseny Maslennikov <ar@cs.msu.ru> wrote:
>
> * The man page for dpkg-source(1) notes:
>
> >      -b, --build directory [format-specific-parameters]
> >             Build  a  source  package  (--build since dpkg 1.17.14).
> >             <...>
> >
> >             dpkg-source will build the source package with the first
> >             format found in this ordered list: the format  indicated
> >             with  the  --format  command  line  option,  the  format
> >             indicated in debian/source/format, =E2=80=9C1.0=E2=80=9D.  =
The  fallback
> >             to =E2=80=9C1.0=E2=80=9D is deprecated and will be removed =
at some point
> >             in the future, you should always  document  the  desired
> >             source   format  in  debian/source/format.  See  section
> >             SOURCE PACKAGE FORMATS for an extensive  description  of
> >             the various source package formats.
>
>   Thus it would be more foolproof to explicitly use 1.0 (as we always
>   did) than to rely on dpkg-source's defaults.
>
> * In a similar vein, debian/rules is not made executable by mkdebian,
>   and dpkg-source warns about that but still silently fixes the file.
>   Let's be explicit once again.
>
> Signed-off-by: Arseny Maslennikov <ar@cs.msu.ru>
> ---


Applied to linux-kbuild. Thanks.


>  scripts/package/mkdebian | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/package/mkdebian b/scripts/package/mkdebian
> index f030961c5165..d276eb671a27 100755
> --- a/scripts/package/mkdebian
> +++ b/scripts/package/mkdebian
> @@ -132,7 +132,9 @@ else
>          echo >&2 "Install lsb-release or set \$KDEB_CHANGELOG_DIST expli=
citly"
>  fi
>
> -mkdir -p debian/
> +mkdir -p debian/source/
> +echo "1.0" > debian/source/format
> +
>  echo $debarch > debian/arch
>
>  # Generate a simple changelog template
> @@ -221,5 +223,6 @@ clean:
>
>  binary: binary-arch
>  EOF
> +chmod +x debian/rules
>
>  exit 0
> --
> 2.20.1
>


--=20
Best Regards
Masahiro Yamada