Received: by 2002:ac0:950e:0:0:0:0:0 with SMTP id f14csp1000605imc; Sun, 17 Mar 2019 00:45:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqz2F7Ti8LRS+Q1FYr1bVSKn6o/ZcBCRdIhHg21SyqEOMLN11BDDWb6s7UCTnE0Zi2HieE4u X-Received: by 2002:a17:902:b201:: with SMTP id t1mr13630167plr.55.1552808707958; Sun, 17 Mar 2019 00:45:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552808707; cv=none; d=google.com; s=arc-20160816; b=k5QAaSsJUcC3nFDrdOLVeHZLLYRwbM44ZQ4tes2/Vx8WiR8L1YG7FFbbYzsSeTY4GI 2/EoXxbtHcitS9Ko+3PiBLeFk1zTkpfiRSRIBGn8a47sssOzUY7GKWAK8RNJcw2kqzwz /E7ZUFPqiN7VMw9G7hk/OlGFckK3/QyKQFwoVCkx+dzVc6rZsMfQCO03cn4ozWngKXgr 4uqZZHzLGrZnd/HGt9asHwCcpmx5JVUfZYkYolw2qUdAqcHLuV7nah4QfxHPJEASTJEM zR/sqBnq3/bkKg0XqyrTPWHSJJ0KDU/BUGe4S9WA/ugP/p3+62jWq8pTWzD/X6Vzlg3g JRyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=qBlieml8JV5qXCvbnd2yHyjLyj5GfAx2T1af6JZYS4A=; b=J5lqBYr9n/zrXo2SXaxCUmFZ0wKFEH9sXUxIsVsqrdPVsQDq7whmefGMnB1ci2k6CZ OUu0P8qGVsskhJeSgQKvnXu40n+QqiKUn0VADWU4k/DYBbobn0bMKnY777mbcTG7j2h4 kFzPat1tDhJahcatxNTzcnrgkITPrwci4Y3r77sYYYUrcsC6HHrSmFbJ13tH2Nj8Zthn tBPFIUGYTnz1OfDWLJf/58ARsy5A3ej8fk/lG3vFgHhHEZ91ccHV4uu6onwT5SJYRyz8 1Ffu4kJNmzpJ6YBJ458+n0gl6JLukMh9ZUE29ZLoH/V0KrGEC70Fjh2bOMTRSagxciQm /tpg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=O3N0rFL8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u1si6329897pgp.378.2019.03.17.00.44.52; Sun, 17 Mar 2019 00:45:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=O3N0rFL8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726599AbfCQHoE (ORCPT + 99 others); Sun, 17 Mar 2019 03:44:04 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:45829 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725903AbfCQHoE (ORCPT ); Sun, 17 Mar 2019 03:44:04 -0400 Received: by mail-lj1-f194.google.com with SMTP id y6so3056222ljd.12 for ; Sun, 17 Mar 2019 00:44:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=qBlieml8JV5qXCvbnd2yHyjLyj5GfAx2T1af6JZYS4A=; b=O3N0rFL8vK+kPO8sqaolbYCCp2nG8348hMeHe3LEYlbQ2w5/dAe1lnHmKeXL6S6jVF 1DQw1sw6192noKpm+jYlVdgO9yNnR19Fe9E/SSoqqduD2f9tQPx1mJ6iqnDoOe50TIya M2I7Nk451/hMkg2svR7zcqeANFED8FPvBc5rlhm/0D0ajseTFkUaH9lxCHFRwDFGdzbO teshJCUnfsRyFctEKOmgjS5KKdoxDfr6ClcA0VwAlbNGrEtIZXgnsE3oxPFm0k8xlQzW fbRoqRkQKR0RPIrUyTWEeVqsQPgNrOY3J6VSbeLF8A8osdS3O0XI5rkrP4HbnYd/uugG ve0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=qBlieml8JV5qXCvbnd2yHyjLyj5GfAx2T1af6JZYS4A=; b=FeRTidujxaB5f9rNBYSYpm7b2d9cPcwbeakTqufLwiX9K4sLQ4qBbL0DzTD2ZwvlEN WZdWzmSIpPZhzCeMDVxbFjUfBlJK6TcGm844x1kLy4vy8Y3pV4UPicxOsvu1rzx3Si8e K8FZT33TIqm6y8WEjE7L1G305mgnAS4ITj+KSo9BmjtuDaqIjSGHgx60jRoja2JhPYnr O8YKpZ4BZ6PNPPpncmHi7postsD4Rt/30GsnWtw56lg1eR/y18V4pZVNLlM5sGWoI9gD de8ESdT/9i/WcTc59OO2Ok7D5Qo4UesmYSKinDQu1Z4r7w5Cj8KOape0kox01WZ/+/y+ cN/A== X-Gm-Message-State: APjAAAXKTSexv6Y4N7CWZvIftsREtMKYEfbpnyML/J2SgWa6h3fbcrop eCYW/MufMAnNVJrwVxCWaD1UoEY8M1kwO6Dsn78= X-Received: by 2002:a2e:731a:: with SMTP id o26mr1815344ljc.69.1552808642231; Sun, 17 Mar 2019 00:44:02 -0700 (PDT) MIME-Version: 1.0 References: <20190301184816.784-1-mans@mansr.com> <20190301184816.784-3-mans@mansr.com> In-Reply-To: From: Miguel Ojeda Date: Sun, 17 Mar 2019 08:43:51 +0100 Message-ID: Subject: Re: [PATCH 3/3] auxdisplay: charlcd: make backlight initial state configurable To: =?UTF-8?B?TcOlbnMgUnVsbGfDpXJk?= Cc: Andy Shevchenko , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 12, 2019 at 4:48 PM M=C3=A5ns Rullg=C3=A5rd wr= ote: > > The current code unconditionally flashes the light once. I though it > best to keep that behaviour as default, even if it's not seen as ideal. Sent into -next. If no one else says anything after a few days, I will send the series for -rc2. By the way, what about the other comment Andy mentioned? i.e. "defined(_OFF)" (in case you missed to answer it). Cheers, Miguel