Received: by 2002:ac0:950e:0:0:0:0:0 with SMTP id f14csp1291685imc; Sun, 17 Mar 2019 09:32:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqy94w2Q4zWKgdfgBebMlW4x5XHnBUh2/t3VSuZrm2ufZsU3Rzaui3WmfwZ9N8pd+BXYdDpT X-Received: by 2002:a62:d281:: with SMTP id c123mr14637813pfg.210.1552840324265; Sun, 17 Mar 2019 09:32:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552840324; cv=none; d=google.com; s=arc-20160816; b=mot62r17A82G1kAdCLpoxbq1DPDghMFn4RlnqU6bVG9xYsMSA+4fQ/klfliRhmjMWe kuyQQwWx7gRjJmtrCVVm+h4tszh1zdYrPMBLux3OodwhyGs+qNyVV/qkm/GWLTxwSi0+ TLXXsDKpcKLjc79Cj1ZheQezr/3AJXdpYBLWxn5jWpNOr3fipLzM4+ARUHq0LdmboB8E WCoUoCO+1oXkIC1zVE9mPmnrEkUB+qPnHoXc/dbCnN2TnaF/WXF6Iu7NEl9uNRttAvOs ZKPvQsZRNUHjPdQ9eypkKytycMwMiemSoatfBOiP1NZILC+3kupuhMrRydQWXtYpeVAZ RYmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=xCNRn2CIAnTHo9UxBJEx7xAGfNa9hKnwX3RpbP1l3F0=; b=VbSBA6dvg6j3Y6Jn69ePgnMpTcTT1HxLp2u2VxOlIDrRQd4VYcMkAs/RVzPOCes4RE /5fO0LYHcj0UpGKand1KAXr91j3ptRFUiVGF/e4DgpWohsL3OUSxme6vzrnH1PxZ7PxO Jxwy5jxQ9NFjgpG/u+4JMMAlijH5RJ4nGsYIZICVld3O2UZO1Q3bwkTwj84TxyDuAxTs J+at/kFcfJMuExVDFsNOFhIhgPK7hGRyspcEkwLtxVOwvVMy0WQo2QNLst7Ivsn8Yrpj QXn0gw4ul5TGwMk5q3gc9Mog+zGaM7VJOu5/vdqyYWi3Vi+nERVFdxElBlNZHhNEt3J6 AfFg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f11si6819682pgk.584.2019.03.17.09.31.49; Sun, 17 Mar 2019 09:32:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726844AbfCQQ3E (ORCPT + 99 others); Sun, 17 Mar 2019 12:29:04 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:48273 "EHLO relay5-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726349AbfCQQ3D (ORCPT ); Sun, 17 Mar 2019 12:29:03 -0400 X-Originating-IP: 79.86.19.127 Received: from alex.numericable.fr (127.19.86.79.rev.sfr.net [79.86.19.127]) (Authenticated sender: alex@ghiti.fr) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 811461C0004; Sun, 17 Mar 2019 16:28:50 +0000 (UTC) From: Alexandre Ghiti To: aneesh.kumar@linux.ibm.com, mpe@ellerman.id.au, Andrew Morton , Vlastimil Babka , Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , Paul Mackerras , Martin Schwidefsky , Heiko Carstens , Yoshinori Sato , Rich Felker , "David S . Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , x86@kernel.org, Dave Hansen , Andy Lutomirski , Peter Zijlstra , Mike Kravetz , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org Cc: Alexandre Ghiti Subject: [PATCH v7 0/4] Fix free/allocation of runtime gigantic pages Date: Sun, 17 Mar 2019 12:28:43 -0400 Message-Id: <20190317162847.14107-1-alex@ghiti.fr> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org his series fixes sh and sparc that did not advertise their gigantic page support and then were not able to allocate and free those pages at runtime. It renames MEMORY_ISOLATION && COMPACTION || CMA condition into the more accurate CONTIG_ALLOC, since it allows the definition of alloc_contig_range function. Finally, it then fixes the wrong definition of ARCH_HAS_GIGANTIC_PAGE config that, without MEMORY_ISOLATION && COMPACTION || CMA defined, did not allow architectures to free boottime allocated gigantic pages although unrelated. Changes in v7: I thought gigantic page support was settled at compile time, but Aneesh and Michael have just come up with a patch proving me wrong for powerpc: https://patchwork.ozlabs.org/patch/1047003/. So this version: - reintroduces gigantic_page_supported renamed into gigantic_page_runtime_supported - reintroduces gigantic page page support corresponding checks (not everywhere though: set_max_huge_pages check was redundant with __nr_hugepages_store_common) - introduces the possibility for arch to override this function by using asm-generic/hugetlb.h current semantics although Aneesh proposed something else. Changes in v6: - Remove unnecessary goto since the fallthrough path does the same and is the 'normal' behaviour, as suggested by Dave Hensen - Be more explicit in comment in set_max_huge_page: we return an error if alloc_contig_range is not defined and the user tries to allocate a gigantic page (we keep the same behaviour as before this patch), but we now let her free boottime gigantic page, as suggested by Dave Hensen - Add Acked-by, thanks. Changes in v5: - Fix bug in previous version thanks to Mike Kravetz - Fix block comments that did not respect coding style thanks to Dave Hensen - Define ARCH_HAS_GIGANTIC_PAGE only for sparc64 as advised by David Miller - Factorize "def_bool" and "depends on" thanks to Vlastimil Babka Changes in v4 as suggested by Dave Hensen: - Split previous version into small patches - Do not compile alloc_gigantic** functions for architectures that do not support those pages - Define correct ARCH_HAS_GIGANTIC_PAGE in all arch that support them to avoid useless runtime check - Add comment in set_max_huge_pages to explain that freeing is possible even without CONTIG_ALLOC defined - Remove gigantic_page_supported function across all archs Changes in v3 as suggested by Vlastimil Babka and Dave Hansen: - config definition was wrong and is now in mm/Kconfig - COMPACTION_CORE was renamed in CONTIG_ALLOC Changes in v2 as suggested by Vlastimil Babka: - Get rid of ARCH_HAS_GIGANTIC_PAGE - Get rid of architecture specific gigantic_page_supported - Factorize CMA or (MEMORY_ISOLATION && COMPACTION) into COMPACTION_CORE Alexandre Ghiti (4): sh: Advertise gigantic page support sparc: Advertise gigantic page support mm: Simplify MEMORY_ISOLATION && COMPACTION || CMA into CONTIG_ALLOC hugetlb: allow to free gigantic pages regardless of the configuration arch/arm64/Kconfig | 2 +- arch/arm64/include/asm/hugetlb.h | 4 -- arch/powerpc/include/asm/book3s/64/hugetlb.h | 7 --- arch/powerpc/platforms/Kconfig.cputype | 2 +- arch/s390/Kconfig | 2 +- arch/s390/include/asm/hugetlb.h | 3 -- arch/sh/Kconfig | 1 + arch/sparc/Kconfig | 1 + arch/x86/Kconfig | 2 +- arch/x86/include/asm/hugetlb.h | 4 -- arch/x86/mm/hugetlbpage.c | 2 +- include/asm-generic/hugetlb.h | 14 +++++ include/linux/gfp.h | 4 +- mm/Kconfig | 3 ++ mm/hugetlb.c | 54 ++++++++++++++------ mm/page_alloc.c | 7 ++- 16 files changed, 67 insertions(+), 45 deletions(-) -- 2.20.1