Received: by 2002:ac0:950e:0:0:0:0:0 with SMTP id f14csp1532232imc; Sun, 17 Mar 2019 17:30:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqxl6cLkb1CwgIiYKBsOjQlUW1b6SH+WIov/YVR5hQo0zVORjoSnFTSGvcJgFwcWQzhOQ+KF X-Received: by 2002:a62:168a:: with SMTP id 132mr16403870pfw.155.1552869056114; Sun, 17 Mar 2019 17:30:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552869056; cv=none; d=google.com; s=arc-20160816; b=0smHgPOPW9kUHWtfN+hxYUG6veLBIzAQI2e561eLqAMhioWpZTkDSsrlNVpar++/GV 59fUrGM6Pq5oziZm5zlq4bSgjE3CroxY2F/mmGyvEHov0gsmPVzVZRVgzHp34ho3ymsn amfV6jZ58P1nITnnc1Fs0lGD3pADjdRYKpVCt+/4ErTAG8Y78GofVgnl20XcwZOOHQQY O6Ltco95xwoiaR1ft9zD60Fl5nU3R1jRzorR8eSVPjOHSAp9rpjhskmVBCcihhmy5kzU TW99mzRufBcV8qTya3f/YgC2+kVH7MZc9Ahxh9I7CcxqOTT902CVuW0LGhIpCOmcBlo3 sOcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=UKOWX6nRrEJIRPW41Nd5NVckoQAF65pq89yg8IuyZtw=; b=qXyFJiWh0uuLD+plEcuK6ZHSREGzbVjErMTbh0vw1UOb/tXOXO0Xu4oXe931AaMQSP cW1391SqnTNFDLjkwuJlpTh7n+gZBAGltzcrpBOv9fUZ6om3bQv+exmtAiITZS7yCbwz h5aJZ4ABZGYMgcr/zdLKk9+aGsX4Jri4V+4uCj4rh4h2TzSo+uc0SrhWztj8ovTDpOry fzGxXVsL6NyfcVtui+qvunrwMYezYl8DbQ381OEc4WhHBtU2AXi+kIpzPwIdul+eSgA9 SHQDkFTuaUUpBBv4rBAad3ciUhxT8f3DxnrpCjj09S/LuxG8BEbLwpF/SufTu9BzLAAT gvHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@brauner.io header.s=google header.b=dIFIuKin; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m24si8112412pls.211.2019.03.17.17.30.38; Sun, 17 Mar 2019 17:30:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@brauner.io header.s=google header.b=dIFIuKin; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727562AbfCRAaC (ORCPT + 99 others); Sun, 17 Mar 2019 20:30:02 -0400 Received: from mail-it1-f195.google.com ([209.85.166.195]:38469 "EHLO mail-it1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727276AbfCRAaB (ORCPT ); Sun, 17 Mar 2019 20:30:01 -0400 Received: by mail-it1-f195.google.com with SMTP id m18so1067325ita.3 for ; Sun, 17 Mar 2019 17:30:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brauner.io; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=UKOWX6nRrEJIRPW41Nd5NVckoQAF65pq89yg8IuyZtw=; b=dIFIuKin1hbg1PW6Uyq63NtDCUPKhr/f6WT93VBHjSgxjn+WY5O6pCBOnwPCFg5LfH RM/khLaSyP72FrJFUYtpVnCUW49NVQsK6WjcRr552l1Z1Xh/oI7o/92EzeqL6waxjzWl WaKTQXIqhPG98TmArP2wFH7pewlmgIRnO+2VFQAOdTQrUDzuKaT0VcwbDgSqCIkvk6sa UZ6uK5pZVHb7TSnJ9/P5A+96v9HXvzqv7uwSpFU/P2e7HvEF8wz2b1M0m5mp8W0m+1Ma jDXM4JEHaYvcQdjkxjDuo+HCXXI5UvFrhYYgyEykafCszC7YwaArsOMxU+l2tr3G6ccK WPwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=UKOWX6nRrEJIRPW41Nd5NVckoQAF65pq89yg8IuyZtw=; b=cLFQf224al4KiKaOzwQy/ddr/wd34Z6Mr3JR27lkTQJB5+kw/hl7rYP/X3TSub2CpX PXc35g7fP6za+jUSccNRmkAfTqSVUV/JW5496w3qm54cG4r3gEvLgJ1hJi8d9YScZ2lj 4+/DS8PvGhvhOLjiuc/n6SitCveclPNLEaStppMbhBkkCpm98JtLvdw4/JbbaA6PhFxw 2QhUSD9EmzNvXtctih9OTYlcG+FVpXqY0bGGml1Q1fJWzSZ0Kud71HfnwjajkAp/SPJZ AvFO3PcReGjyNLwn/EDlKhp0MZqEWM8WrDbS6DgWBIsM69ejtNyGr0O7O5LUVCBYxyxC E9YQ== X-Gm-Message-State: APjAAAXE5oMwBdgOseppt7lMYIzweD8cge68RzIj6l+JYJmeQMfNjSBZ TuwYrlSn3twQxkrfFFhksvRwSw== X-Received: by 2002:a24:d14:: with SMTP id 20mr1085045itx.0.1552868999848; Sun, 17 Mar 2019 17:29:59 -0700 (PDT) Received: from brauner.io ([67.133.97.99]) by smtp.gmail.com with ESMTPSA id y18sm3308253ioa.56.2019.03.17.17.29.57 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sun, 17 Mar 2019 17:29:59 -0700 (PDT) Date: Mon, 18 Mar 2019 01:29:51 +0100 From: Christian Brauner To: Daniel Colascione Cc: Joel Fernandes , Suren Baghdasaryan , Steven Rostedt , Sultan Alsawaf , Tim Murray , Michal Hocko , Greg Kroah-Hartman , Arve =?utf-8?B?SGrDuG5uZXbDpWc=?= , Todd Kjos , Martijn Coenen , Ingo Molnar , Peter Zijlstra , LKML , "open list:ANDROID DRIVERS" , linux-mm , kernel-team , Oleg Nesterov , Andy Lutomirski , "Serge E. Hallyn" Subject: Re: [RFC] simple_lmk: Introduce Simple Low Memory Killer for Android Message-ID: <20190318002949.mqknisgt7cmjmt7n@brauner.io> References: <20190315181324.GA248160@google.com> <20190315182426.sujcqbzhzw4llmsa@brauner.io> <20190315184903.GB248160@google.com> <20190316185726.jc53aqq5ph65ojpk@brauner.io> <20190317015306.GA167393@google.com> <20190317114238.ab6tvvovpkpozld5@brauner.io> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 17, 2019 at 08:40:19AM -0700, Daniel Colascione wrote: > On Sun, Mar 17, 2019 at 4:42 AM Christian Brauner wrote: > > > > On Sat, Mar 16, 2019 at 09:53:06PM -0400, Joel Fernandes wrote: > > > On Sat, Mar 16, 2019 at 12:37:18PM -0700, Suren Baghdasaryan wrote: > > > > On Sat, Mar 16, 2019 at 11:57 AM Christian Brauner wrote: > > > > > > > > > > On Sat, Mar 16, 2019 at 11:00:10AM -0700, Daniel Colascione wrote: > > > > > > On Sat, Mar 16, 2019 at 10:31 AM Suren Baghdasaryan wrote: > > > > > > > > > > > > > > On Fri, Mar 15, 2019 at 11:49 AM Joel Fernandes wrote: > > > > > > > > > > > > > > > > On Fri, Mar 15, 2019 at 07:24:28PM +0100, Christian Brauner wrote: > > > > > > > > [..] > > > > > > > > > > why do we want to add a new syscall (pidfd_wait) though? Why not just use > > > > > > > > > > standard poll/epoll interface on the proc fd like Daniel was suggesting. > > > > > > > > > > AFAIK, once the proc file is opened, the struct pid is essentially pinned > > > > > > > > > > even though the proc number may be reused. Then the caller can just poll. > > > > > > > > > > We can add a waitqueue to struct pid, and wake up any waiters on process > > > > > > > > > > death (A quick look shows task_struct can be mapped to its struct pid) and > > > > > > > > > > also possibly optimize it using Steve's TIF flag idea. No new syscall is > > > > > > > > > > needed then, let me know if I missed something? > > > > > > > > > > > > > > > > > > Huh, I thought that Daniel was against the poll/epoll solution? > > > > > > > > > > > > > > > > Hmm, going through earlier threads, I believe so now. Here was Daniel's > > > > > > > > reasoning about avoiding a notification about process death through proc > > > > > > > > directory fd: http://lkml.iu.edu/hypermail/linux/kernel/1811.0/00232.html > > > > > > > > > > > > > > > > May be a dedicated syscall for this would be cleaner after all. > > > > > > > > > > > > > > Ah, I wish I've seen that discussion before... > > > > > > > syscall makes sense and it can be non-blocking and we can use > > > > > > > select/poll/epoll if we use eventfd. > > > > > > > > > > > > Thanks for taking a look. > > > > > > > > > > > > > I would strongly advocate for > > > > > > > non-blocking version or at least to have a non-blocking option. > > > > > > > > > > > > Waiting for FD readiness is *already* blocking or non-blocking > > > > > > according to the caller's desire --- users can pass options they want > > > > > > to poll(2) or whatever. There's no need for any kind of special > > > > > > configuration knob or non-blocking option. We already *have* a > > > > > > non-blocking option that works universally for everything. > > > > > > > > > > > > As I mentioned in the linked thread, waiting for process exit should > > > > > > work just like waiting for bytes to appear on a pipe. Process exit > > > > > > status is just another blob of bytes that a process might receive. A > > > > > > process exit handle ought to be just another information source. The > > > > > > reason the unix process API is so awful is that for whatever reason > > > > > > the original designers treated processes as some kind of special kind > > > > > > of resource instead of fitting them into the otherwise general-purpose > > > > > > unix data-handling API. Let's not repeat that mistake. > > > > > > > > > > > > > Something like this: > > > > > > > > > > > > > > evfd = eventfd(0, EFD_NONBLOCK | EFD_CLOEXEC); > > > > > > > // register eventfd to receive death notification > > > > > > > pidfd_wait(pid_to_kill, evfd); > > > > > > > // kill the process > > > > > > > pidfd_send_signal(pid_to_kill, ...) > > > > > > > // tend to other things > > > > > > > > > > > > Now you've lost me. pidfd_wait should return a *new* FD, not wire up > > > > > > an eventfd. > > > > > > > > > > > > > > Ok, I probably misunderstood your post linked by Joel. I though your > > > > original proposal was based on being able to poll a file under > > > > /proc/pid and then you changed your mind to have a separate syscall > > > > which I assumed would be a blocking one to wait for process exit. > > > > Maybe you can describe the new interface you are thinking about in > > > > terms of userspace usage like I did above? Several lines of code would > > > > explain more than paragraphs of text. > > > > > > Hey, Thanks Suren for the eventfd idea. I agree with Daniel on this. The idea > > > from Daniel here is to wait for process death and exit events by just > > > referring to a stable fd, independent of whatever is going on in /proc. > > > > > > What is needed is something like this (in highly pseudo-code form): > > > > > > pidfd = opendir("/proc/",..); > > > wait_fd = pidfd_wait(pidfd); > > > read or poll wait_fd (non-blocking or blocking whichever) > > > > > > wait_fd will block until the task has either died or reaped. In both these > > > cases, it can return a suitable string such as "dead" or "reaped" although an > > > integer with some predefined meaning is also Ok. > > I want to return a siginfo_t: we already use this structure in other > contexts to report exit status. > > > > What that guarantees is, even if the task's PID has been reused, or the task > > > has already died or already died + reaped, all of these events cannot race > > > with the code above and the information passed to the user is race-free and > > > stable / guaranteed. > > > > > > An eventfd seems to not fit well, because AFAICS passing the raw PID to > > > eventfd as in your example would still race since the PID could have been > > > reused by another process by the time the eventfd is created. > > > > > > Also Andy's idea in [1] seems to use poll flags to communicate various tihngs > > > which is still not as explicit about the PID's status so that's a poor API > > > choice compared to the explicit syscall. > > > > > > I am planning to work on a prototype patch based on Daniel's idea and post something > > > soon (chatted with Daniel about it and will reference him in the posting as > > > well), during this posting I will also summarize all the previous discussions > > > and come up with some tests as well. I hope to have something soon. > > Thanks. > > > Having pidfd_wait() return another fd will make the syscall harder to > > swallow for a lot of people I reckon. > > What exactly prevents us from making the pidfd itself readable/pollable > > for the exit staus? They are "special" fds anyway. I would really like > > to avoid polluting the api with multiple different types of fds if possible. > > If pidfds had been their own file type, I'd agree with you. But pidfds > are directories, which means that we're beholden to make them behave > like directories normally do. I'd rather introduce another FD than > heavily overload the semantics of a directory FD in one particular > context. In no other circumstances are directory FDs also weird > IO-data sources. Our providing a facility to get a new FD to which we > *can* give pipe-like behavior does no harm and *usage* cleaner and > easier to reason about. I have two things I'm currently working on: - hijacking translate_pid() - pidfd_clone() essentially My first goal is to talk to Eric about taking the translate_pid() syscall that has been sitting in his tree and expanding it. translate_pid() currently allows you to either get an fd for the pid namespace a pid resides in or the pid number of a given process in another pid namespace relative to a passed in pid namespace fd. I would like to make it possible for this syscall to also give us back pidfds. One question I'm currently struggling with is exactly what you said above: what type of file descriptor these are going to give back to us. It seems that a regular file instead of directory would make the most sense and would lead to a nicer API and I'm very much leaning towards that. Christian