Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp217990img; Mon, 18 Mar 2019 01:19:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqyCvfjCUerpJUPpt0jPjxE1Ru5K4HAeempnWCprFBb76fiCLmXJsw2J/6WPdC1JhjTKJ2Q2 X-Received: by 2002:a65:6259:: with SMTP id q25mr16593174pgv.235.1552897184998; Mon, 18 Mar 2019 01:19:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552897184; cv=none; d=google.com; s=arc-20160816; b=k2WwdiByTZH4E8iyBY5O5Ij9pyHWOoSYk9ieH/iZc5fXMLZ2Vu6tbDHBm46qrm/YMr nGDHD0tJmPy4vH63P6W8IRcxYm7CPHpPfPWo+gsQ4hoZeLWGRy1+ThG6+YgI1iiiFCtU B+jYkups9mGI2w87sWDfMZvgU7cZ/owiDp5PXbft76UjXe0klAk6/LdF4wsod7BqYYsl tGby5sKvKoBgk8qSMrqIafsoj2Y7VL/DTgX4hDT9KsFLxZzD5vGmrHbv37EoSzkgrlS2 FAbxLtc4I1IzGncqcFQWZBvHr7EeP7qb+QePrvC9idB0AAUyyw/PK8Whu4uBbfQ873pX 65aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:from:references:cc:to:subject :dkim-signature; bh=CIQLRgXhEYZ+LxBRASvoXCmRz/2o6wCcqEisJk24XyE=; b=buWGRCclK1zuIPxE8/GRhBKeJud/bcBd9X/pBmJSKOM2JPYQYXt/bDQknROd4QdaP+ pm2rqD/f/nNCoKslNuBeHSeIc60awVLCj4o5TwOb3hr5vhtL3J78ln62E3e7LG5R5VFf odsNB/W7Ksk5CK5h37Q2XCnheONEEcTIptvUu4lxFSKO+b1LD3AsREgZWohr4wPQRhwq itEI/Fjtv9fOTmoK0p1YJRSDgfS8SRgxlVt1fpFEczh1/nth9oUKsb25A4sTY3a2NSCm LKn9T5y3L/vhuPVL99spYuRCVD4K8GdYl672u0fvZbBbnAlnJpIKezdPcEZQwLJ+Re9v AUDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@scalemp.com header.s=default header.b=hiP3Cy11; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=scalemp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o19si8063556pgv.142.2019.03.18.01.19.30; Mon, 18 Mar 2019 01:19:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@scalemp.com header.s=default header.b=hiP3Cy11; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=scalemp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726915AbfCRISy (ORCPT + 99 others); Mon, 18 Mar 2019 04:18:54 -0400 Received: from www.scalemp.com ([169.44.78.149]:45930 "EHLO scalemp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726875AbfCRISv (ORCPT ); Mon, 18 Mar 2019 04:18:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=scalemp.com ; s=default; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=CIQLRgXhEYZ+LxBRASvoXCmRz/2o6wCcqEisJk24XyE=; b=hiP3Cy110mH6C+q7Qlpkid1uYT hyAPCrqNzaDxADwOl3rVgLBHjZijHdbE7VFTtOBvk1wBFTXbgIp44LUaXXryxmcDZ48eAiihPjqh7 jwMqKbHDB3hDmIW1fJTKFBbamDvMNuC7rPoxD4NoYRNjpqG8Y9KV7goTBI/RrTscKyKU=; Received: from bzq-80-45-146.static.bezeqint.net ([82.80.45.146]:30257 helo=[10.100.0.120]) by hosting.virtualsmp.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1h5nTu-000gmN-JY; Mon, 18 Mar 2019 04:18:50 -0400 Subject: Re: [PATCH] percpu/module resevation: change resevation size iff X86_VSMP is set To: paulmck@linux.ibm.com Cc: Tejun Heo , Barret Rhoden , Christopher Lameter , Dennis Zhou , linux-kernel@vger.kernel.org, Shai Fultheim , Oren Twaig References: <20190301203455.GA97188@dennisz-mbp.dhcp.thefacebook.com> <010001693b404440-248fa987-624c-4587-940b-56e2ed4226d9-000000@email.amazonses.com> <85726648-82f3-6b6b-a749-03c4159e78f3@google.com> <20190313202640.GJ50184@devbig004.ftw2.facebook.com> <20190313212255.GY13351@linux.ibm.com> <20190313212912.GK50184@devbig004.ftw2.facebook.com> <20190313231155.GC13351@linux.ibm.com> <20190314173619.GL50184@devbig004.ftw2.facebook.com> <20190314221943.GQ4102@linux.ibm.com> From: Eial Czerwacki Organization: ScaleMP Message-ID: Date: Mon, 18 Mar 2019 10:18:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190314221943.GQ4102@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hosting.virtualsmp.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - scalemp.com X-Get-Message-Sender-Via: hosting.virtualsmp.com: authenticated_id: eial@scalemp.com X-Authenticated-Sender: hosting.virtualsmp.com: eial@scalemp.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Greetings Paul, On 3/15/19 12:19 AM, Paul E. McKenney wrote: > On Thu, Mar 14, 2019 at 10:36:19AM -0700, Tejun Heo wrote: >> On Wed, Mar 13, 2019 at 04:11:55PM -0700, Paul E. McKenney wrote: >>> commit 34f67df09cc0c6bf082a7cfca435373caeeb8d82 >>> Author: Paul E. McKenney >>> Date: Wed Mar 13 16:06:22 2019 -0700 >>> >>> srcu: Forbid DEFINE{,_STATIC}_SRCU() from modules >>> >>> Adding DEFINE_SRCU() or DEFINE_STATIC_SRCU() to a loadable module >>> requires that the size of the reserved region be increased, which is >>> not something we want to be doing all that often. Instead, loadable >>> modules should define an srcu_struct and invoke init_srcu_struct() >>> from their module_init function and cleanup_srcu_struct() from their >>> module_exit function. Note that modules using call_srcu() will also >>> need to invoke srcu_barrier() from their module_exit function. >>> >>> This commit enforces this advice by refusing to define DEFINE_SRCU() >>> and DEFINE_STATIC_SRCU() within loadable modules. >>> >>> Suggested-by: Barret Rhoden >>> Signed-off-by: Paul E. McKenney >> >> Looks-great-to-me-by: Tejun Heo > > Applied. ;-) > > Thanx, Paul > >> Thanks. :) >> >> -- >> tejun >> > > when can this patch be found in the kernel mainline git repo? I'd like to test and see if the patch that started this mail thread still occurs. Thanks, Eial.