Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp258315img; Mon, 18 Mar 2019 02:26:12 -0700 (PDT) X-Google-Smtp-Source: APXvYqxeKY4D4XA2+dAGsffD4uVMxMoEIDeFh1wTJMuqUfP2daaWvmz6OHfzwSmHrnT/JW+SkCts X-Received: by 2002:a62:b502:: with SMTP id y2mr18125197pfe.212.1552901172118; Mon, 18 Mar 2019 02:26:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552901172; cv=none; d=google.com; s=arc-20160816; b=dv4q1WKOCrR62ioX4GEkg7nJnvyCEgPgproABselrcC56DWd9Zt1MW7X9Ynx9jrzgU 598bErq0uG41PA0DT7gKu5trnzvyJMAN15OSqIwIJ/rfzgkA9mIRsgFGPoY2z3+M+Vbw OZePz+s9qHPgRPRekiDDPD8AWP4x61fUHzK4///8hAnUvN7CfNapAaVZJuyuGOvfKIF8 irK6R0z93PplaCRmwUUDrLYE+BiKAJjlXRPNYiH4W1bqPy6xinh5CFEA6AKXEjrika+b EP6YuMBLEI/E266AvMHG7ZsptX0JRSZ8bhglf2REJOObrmAg93xQH1TrnFZLWOU88y/E BVyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:in-reply-to:date :references:subject:cc:to:from; bh=nEszTdjweEhJwX5XWKwNA/5P4bMRBur4x2SzxlPty80=; b=A2mTsQvxkWqc0PEfmpVz3mnSU7cHzYIn0+RudWd1xKHnIudJWxOCcw2M0GrM5L7U3g 98VNkp5hE+q7rnr8ol2dDFs0azSZ1VkIVgK0hGITR2OnG78u9ceQgyYuHRQK0j2Z8StD qKphPw6RFzioE+bLghv5Y8aFAx9Y+LmkIxxlL/qJZafB+Dmse+NGInu+9ajF9PEMHQ0Q t+sZOkKcwZBjTpR2X28GqlvXWKya7wLeCeZwXcaqgsZOR9gFmd5tT+Ldts9L+I64sfE/ D7uYd0zcrAeBTFtkG2oBMQqSp1rr9d+AJgZcpvZ+RoimvkjqWU4HD+QxeVw+I+LR3k2K nwyA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i29si8789705pgi.95.2019.03.18.02.25.56; Mon, 18 Mar 2019 02:26:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727362AbfCRJZK (ORCPT + 99 others); Mon, 18 Mar 2019 05:25:10 -0400 Received: from albireo.enyo.de ([5.158.152.32]:51904 "EHLO albireo.enyo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726763AbfCRJZJ (ORCPT ); Mon, 18 Mar 2019 05:25:09 -0400 Received: from [172.17.203.2] (helo=deneb.enyo.de) by albireo.enyo.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) id 1h5oVx-0000eE-QH; Mon, 18 Mar 2019 09:25:01 +0000 Received: from fw by deneb.enyo.de with local (Exim 4.89) (envelope-from ) id 1h5oSW-0007fc-Oe; Mon, 18 Mar 2019 10:21:28 +0100 From: Florian Weimer To: Arnd Bergmann Cc: Deepa Dinamani , "David S . Miller" , Willem de Bruijn , alpha , linux-arch , linux-mips@vger.kernel.org, Parisc List , sparclinux , Laura Abbott , Networking , Linux Kernel Mailing List , Linux API , Josh Boyer , Linus Torvalds , Jeff Law Subject: Re: [PATCH] y2038: fix socket.h header inclusion References: <20190311153857.563743-1-arnd@arndb.de> <87k1h1fgkk.fsf@mid.deneb.enyo.de> <87a7hvded7.fsf@mid.deneb.enyo.de> Date: Mon, 18 Mar 2019 10:21:28 +0100 In-Reply-To: (Arnd Bergmann's message of "Mon, 18 Mar 2019 09:27:46 +0100") Message-ID: <87o968y1uv.fsf@mid.deneb.enyo.de> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Arnd Bergmann: > Should we just remove __kernel_fd_set from the exported headers and > define the internal fd_set directly in include/linux/types.h? (Adding the > folks from the old thread to Cc). The type is used in the sanitizers, but incorrectly. They assume that FD_SETSIZE is always 1024. (The existence of __kernel_fd_set is itself somewhat questionable because it leads to such bugs.) Moving around the type could cause a build failure in the sanitizers, but I'm not entirely clear how the UAPI headers are included there. Otherwise, I couldn't find any uses.