Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <494746a793619dd9b43fb152de811a6e7de77cce.camel@perches.com>
Subject: Re: [PATCH v2 01/19] locking/lockdep: Change all print_*() return
 type to void
From:   Joe Perches <joe@perches.com>
To:     Yuyang Du <duyuyang@gmail.com>, peterz@infradead.org,
        will.deacon@arm.com, mingo@kernel.org
Cc:     bvanassche@acm.org, ming.lei@redhat.com,
        linux-kernel@vger.kernel.org
Date:   Mon, 18 Mar 2019 02:45:05 -0700
In-Reply-To: <20190318085733.3143-2-duyuyang@gmail.com>
References: <20190318085733.3143-1-duyuyang@gmail.com>
         <20190318085733.3143-2-duyuyang@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.30.1-1build1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 2019-03-18 at 16:57 +0800, Yuyang Du wrote:
> Since none of the print_*() function's return value is necessary, change
> their return type to void. No functional change.
> 
> In cases where an invariable return value is used, this change slightly
> improves readability, i.e.:
[]
> diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
[]
> @@ -1430,23 +1430,20 @@ static inline int __bfs_backwards(struct lock_list *src_entry,
[]
> -static void
> -print_circular_lock_scenario(struct held_lock *src,
> -			     struct held_lock *tgt,
> -			     struct lock_list *prt)
> +static void print_circular_lock_scenario(struct held_lock *src,
> +					 struct held_lock *tgt,
> +					 struct lock_list *prt)

trivia:

This style change seems superfluous as many
other existing functions use the previous style.