Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp272232img; Mon, 18 Mar 2019 02:48:30 -0700 (PDT) X-Google-Smtp-Source: APXvYqzUaLWlqnFvdgatg5wdPsHzs0Sv0djulF1a+iT2S3xBexjUTPrRRVVLuH20skoUb9c1g9cf X-Received: by 2002:a63:f914:: with SMTP id h20mr16884295pgi.322.1552902510770; Mon, 18 Mar 2019 02:48:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552902510; cv=none; d=google.com; s=arc-20160816; b=QlilvMpK4ELz07pWSeB2n91npv0yd4yVzzg3J5ugQUWuetTn4bBsYZx/2KURcEmZx0 vVBBbeOnwK1hR+Dy+iYoxrH4POzw4tp6fsILp6Tj3WQ3rbSyGnBqiLQLOCGP6BRVrjO1 Umju8JrW3s6SjfjlL+pxcva97ZiR+0zEzoBeczV99H1L1X8bffGMZKUqO+S7zcey6r5P nYGN/iWIUoUlWeWKcFaXr0mIKWrNw+boqygLNwkNhfmrDLabTWrkc0URIRvIgM9qR5Oc wRC8HH5fPFoiO5K1bleFNLnVdLUrMTlqQ/mtqztHgpfdaaQ2+B+oqNYAJj6SwTup79E0 xRow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:content-transfer-encoding :mime-version:message-id:date:cc:to:from; bh=1iwZ5iMYMBwqElmvK8iM8UlnFpkkIc9QKGYvYqS776U=; b=K5kZfuMtw84GYZKItmgyAwMa/rrybPh85lEufM9iZXHBYqdvK8yjgkWhqWF4nvZ9mw +fjlD6RZirRlApwhcttJ05mNtqQXI+w7YfJdUzzC89QRkN40B2nbQykfExLpCcDKcOzP 1l82oIuJuBJhOxZUwD78wDICV5dLI42g2DXFqMc13gfhHrLrybn5xF/+GzhobGjg+OdE hbqYBgXen08shUi0/1md6B4TqLsrbZjjZgXagU5pJ6JeRL1degsZHpUrZlaCyxFAe13M v3APztSzdiK9Zbq8DsNjL6UBqKSgEj/XVp+9WDU+dGrnQ+rhqZJaoL6f+2re7WDybPRv jtug== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=REJECT dis=NONE) header.from=skyboo.net Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d9si9296346pln.403.2019.03.18.02.48.16; Mon, 18 Mar 2019 02:48:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=REJECT dis=NONE) header.from=skyboo.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727988AbfCRJ2E (ORCPT + 99 others); Mon, 18 Mar 2019 05:28:04 -0400 Received: from skyboo.net ([94.40.87.198]:39026 "EHLO skyboo.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727944AbfCRJ1z (ORCPT ); Mon, 18 Mar 2019 05:27:55 -0400 Received: from manio by skyboo.net with local (Exim 4.91) (envelope-from ) id 1h5oYc-0002HH-KC; Mon, 18 Mar 2019 10:27:52 +0100 From: Mariusz Bialonczyk To: linux-kernel@vger.kernel.org, Evgeniy Polyakov , Greg Kroah-Hartman , Jean-Francois Dagenais Cc: Mariusz Bialonczyk Date: Mon, 18 Mar 2019 10:27:35 +0100 Message-Id: <20190318092737.8170-1-manio@skyboo.net> X-Mailer: git-send-email 2.19.0.rc1 MIME-Version: 1.0 Content-Type: text/plain; charset=y Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: X-SA-Exim-Rcpt-To: linux-kernel@vger.kernel.org, zbr@ioremap.net, greg@kroah.com, jeff.dagenais@gmail.com, manio@skyboo.net X-SA-Exim-Mail-From: manio@skyboo.net X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on nemesis.skyboo.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NO_RELAYS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.1 Subject: [PATCH 0/2] w1: DS2408 fixes X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on skyboo.net) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, I prepared a two fixes related with 1wire and DS2408. In short the problem was that a single DS2408 slave was properly setting the output value to a channel access write but the command was returning error. Moreover when there was a write of a 0xff value (all inputs off, there was also no problem - it's now also understandable for me after looking at the transmission log) ;) This problem doesn't occur on a multidrop bus. Finally I was able to catch the problems recently after analyzing the oscilloscope waveforms in PulseView. After those fixes all is now working perfectly fine - no matter if it is multidrop or single slave bus :) ps. if you are merging this please also take into account a patch which I've sent recently but it is still not merged: https://lore.kernel.org/lkml/20190304112336.21397-1-manio@skyboo.net/ regards, Mariusz Białończyk | xmpp/e-mail: manio@skyboo.net https://skyboo.net | https://github.com/manio Mariusz Bialonczyk (2): w1: ds2408: add a missing reset when retrying in output_write() w1: fix the resume command API drivers/w1/slaves/w1_ds2408.c | 13 ++++++++----- drivers/w1/w1_io.c | 11 +++++++++-- 2 files changed, 17 insertions(+), 7 deletions(-) -- 2.19.0.rc1