Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp377115img; Mon, 18 Mar 2019 05:19:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqwMTjPQEW2fduJ+kKtCIiOaM3tn+pb4twkbRePvve+dd/LL70A77CugRDa1eTDXMNWUZ6A1 X-Received: by 2002:a63:c04e:: with SMTP id z14mr17116418pgi.20.1552911548423; Mon, 18 Mar 2019 05:19:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552911548; cv=none; d=google.com; s=arc-20160816; b=ETTxpjtgmv2Dgod5vASWuvWFJpcOJTYGdlg8opqWw9PJhTR9DIHuJfzyUsY9qeDt5/ RkUlXRqxBbNkDxul8lZ7V9Gvppovw5peLS8EYwn07sGIo2g5Q/WAFRO/pgLcmexoqJ6a zr1hTJ23t6eWN0QFygAY6Q58in7uvG1MVLFN001RrQWl7lwSRDMjKHTyT3Uk3pxQCfdG k65lYCVyI30vBiYKmoa0AP4fCgm6NvB0n7BOxkQHYK+6e74ykj4G7XJklLqoJZAn/u1m FtpSN3e+rWem9Ar6YGoh5VA9gVucjXOh6mk2XZybflq9DqLGpt8np8f/YVGhMgL2/xX4 Lpgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=p6bxH2mBv+/ugGCJCuAzkV2gYrXnZDYOFtogSt22uAY=; b=LS+B0j4DVFIthwFm6ZJZymtrtDeTra++lFWdu+HpHnKfGdBcCfz9g4XtvcYoFOi34k B8+oD1mWPqHqV80rMJr7FC1zJpNZcDMEbJEv5Ww5+CYpFaP0jegR+DkUAcNmS+D6KbsI XkxWOHJyBSw7i0iql5HHCe0FOMQqHWNfYpeF1Y2rztTYVhy9nLktZJbh6/J7eIcX7YmI 2ST+DjyTSNAy0/UfYRXrRY43ZuXBrjnu0j65J1RaB24LP247GsmUB3pRQ4LxlQN9Z/7S d2l63DNA4+QEgoI3eaKnnO9/aAU+Sltb+0XD35XXRwwgRbib77m1Es0Mb/JzZx2MZuSc acXA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g5si8792523pgc.122.2019.03.18.05.18.52; Mon, 18 Mar 2019 05:19:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727251AbfCRMSO (ORCPT + 99 others); Mon, 18 Mar 2019 08:18:14 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:33200 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726435AbfCRMSO (ORCPT ); Mon, 18 Mar 2019 08:18:14 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A9FF180D; Mon, 18 Mar 2019 05:18:13 -0700 (PDT) Received: from e110439-lin (e110439-lin.cambridge.arm.com [10.1.194.43]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B5EA43F71A; Mon, 18 Mar 2019 05:18:10 -0700 (PDT) Date: Mon, 18 Mar 2019 12:18:04 +0000 From: Patrick Bellasi To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-api@vger.kernel.org, Ingo Molnar , Tejun Heo , "Rafael J . Wysocki" , Vincent Guittot , Viresh Kumar , Paul Turner , Quentin Perret , Dietmar Eggemann , Morten Rasmussen , Juri Lelli , Todd Kjos , Joel Fernandes , Steve Muckle , Suren Baghdasaryan Subject: Re: [PATCH v7 03/15] sched/core: uclamp: Add system default clamps Message-ID: <20190318121804.tr3myhtgczvovmkq@e110439-lin> References: <20190208100554.32196-1-patrick.bellasi@arm.com> <20190208100554.32196-4-patrick.bellasi@arm.com> <20190313201821.GW2482@worktop.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190313201821.GW2482@worktop.programming.kicks-ass.net> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13-Mar 21:18, Peter Zijlstra wrote: > On Fri, Feb 08, 2019 at 10:05:42AM +0000, Patrick Bellasi wrote: > > +static void uclamp_fork(struct task_struct *p) > > +{ > > + unsigned int clamp_id; > > + > > + if (unlikely(!p->sched_class->uclamp_enabled)) > > + return; > > + > > + for (clamp_id = 0; clamp_id < UCLAMP_CNT; ++clamp_id) > > + p->uclamp[clamp_id].active = false; > > +} > > Because in that case .active == false, and copy_process() will have done > thr right thing? Don't really get what you mean here? :/ -- #include Patrick Bellasi