Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 18 Mar 2019 09:54:36 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Daniel Thompson <daniel.thompson@linaro.org>
Cc:     Douglas Anderson <dianders@chromium.org>,
        Ingo Molnar <mingo@redhat.com>,
        Jason Wessel <jason.wessel@windriver.com>,
        kgdb-bugreport@lists.sourceforge.net,
        Brian Norris <briannorris@chromium.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/3] tracing: kdb: Allow ftdump to skip all but the
 last few entries
Message-ID: <20190318095436.7f09a371@gandalf.local.home>
In-Reply-To: <20190318030238.GD27232@oak.lan>
References: <20190315230906.250598-1-dianders@chromium.org>
        <20190315230906.250598-3-dianders@chromium.org>
        <20190318030238.GD27232@oak.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 18 Mar 2019 03:02:38 +0000
Daniel Thompson <daniel.thompson@linaro.org> wrote:

> > diff --git a/kernel/trace/trace_kdb.c b/kernel/trace/trace_kdb.c
> > index 4b666643d69f..996e1e9cd9a6 100644
> > --- a/kernel/trace/trace_kdb.c
> > +++ b/kernel/trace/trace_kdb.c
> > @@ -39,7 +39,8 @@ static void ftrace_dump_buf(int skip_entries, long cpu_file)
> >  	/* don't look at user memory in panic mode */
> >  	tr->trace_flags &= ~TRACE_ITER_SYM_USEROBJ;
> >  
> > -	kdb_printf("Dumping ftrace buffer:\n");
> > +	kdb_printf("Dumping ftrace buffer (skipping %d entries):\n",
> > +		   skip_entries);  
> 
> If someone *doesn't* need to skip any entries I'm not a fan of telling
> them we are "skipping 0 entries"; it is more unnerving than helpful
> ("huh? what does it need to tell me that no entried were skipped?
> what makes the tracer skip entries?... Doh... I get it").

I agree.

Probably best to have this:

	kdb_printf("Dumping ftrace buffer:\n");
	if (skip_entries)
		kdb_printf("(skipping %d entries)\n", skip_entries);

No reason to inject that skipping line in the first line.

-- Steve