Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp529449img; Mon, 18 Mar 2019 08:27:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqyFC0EYU59OCdBH8K6B4w0R8TKjjVkd6Bp+HuTkyrcrBx+tPbeU18r0TsDpN3VmUyRu71Zn X-Received: by 2002:a63:e70c:: with SMTP id b12mr2857053pgi.399.1552922861882; Mon, 18 Mar 2019 08:27:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552922861; cv=none; d=google.com; s=arc-20160816; b=Mwa04MJsQBsDzHMQuDWt50A8jguAxwOXimtaepHKCSxxp9AWTJF2uM5P03MPUamist +F49TbsM/jjIQT4VmMfiSpUCme/xf/cnLQN2R1MltiAaquZBxilDXH8aLBKFiq1KQjRW c83hP4EdMBTBMvbvNZHhc9PABu3jheAfYkGLBo9s6XlTXwRCHPuFrwx3fNwEBHecr+U5 LMtYSbfjGIzR6UiDImlRLbR45wQegtNL4L4wEG/Q97enF3p096mj13melhWEW8zw0sjt d7QGo5S6RBvR37/L7g3Jo3BfIYFylW287+PIIGU22G+p2a8xKrg8XbA3jf3U0OncO0hW TXbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=MHGt+LzRHBTvS2+yaZ6xgGqbWb9C+Fj22fKXQoahE04=; b=VlO9kZYiGogFDQWCEnqFifr18al6IxnqIXoomVIJ30D05KtHvhhiweVS6kzutFUo50 r+NvlIlCnm/PaeerTu3yqL7ySCiWvh/MGSgn1FPUV2X8/gj49tGx//+pB/GJzov8NLu1 FGMclJggxxeIDctI4Sw/wjce7JcFyLGkX3xQfuWEfuZyrBPnCmH7YFGDlbDOJOSPKVm0 dpCc8+oBUsfNGpuBbPgM7tX8MdhGgwgQkQodNgkxO13jBy6d1JiNFwSX8PRD91avf5VW gVaAs1WybfRoTHtgwfCzgWgH1L0f666Mk7S2/Bdxqj98tmRssDzmTR0E5JdSTr0fSGE0 7H9Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o3si9250895pgh.189.2019.03.18.08.27.26; Mon, 18 Mar 2019 08:27:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727087AbfCRP0s (ORCPT + 99 others); Mon, 18 Mar 2019 11:26:48 -0400 Received: from ganesha.gnumonks.org ([213.95.27.120]:52946 "EHLO ganesha.gnumonks.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726837AbfCRP0s (ORCPT ); Mon, 18 Mar 2019 11:26:48 -0400 Received: from [195.39.71.253] (helo=gnumonks.org) by ganesha.gnumonks.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1h5tld-0001cF-1A; Mon, 18 Mar 2019 16:01:34 +0100 Date: Mon, 18 Mar 2019 16:01:32 +0100 From: Pablo Neira Ayuso To: Kangjie Lu Cc: pakki001@umn.edu, Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Alexey Kuznetsov , Hideaki YOSHIFUJI , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ipv6: ip6t_srh: fix NULL pointer dereferences Message-ID: <20190318150132.3qeqvxpbygvwt237@salvia> References: <20190314075818.29951-1-kjlu@umn.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190314075818.29951-1-kjlu@umn.edu> User-Agent: NeoMutt/20170113 (1.7.2) X-Spam-Score: -2.7 (--) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 14, 2019 at 02:58:18AM -0500, Kangjie Lu wrote: > skb_header_pointer may return NULL. The current code dereference > its return values without a NULL check. > > The fix inserts the checks to avoid NULL pointer dereferences. Applied, thanks.