Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190318153840.906404905@infradead.org> <20190318155139.963285969@infradead.org>
In-Reply-To: <20190318155139.963285969@infradead.org>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Mon, 18 Mar 2019 09:58:20 -0700
Message-ID: <CAHk-=wgYUTJ33ANOF5=5AKafzgqCi4Xe9iRCdgUV4s05HrH_Pw@mail.gmail.com>
Subject: Re: [PATCH 01/25] x86: Make SMAP 64-bit only
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Thomas Gleixner <tglx@linutronix.de>, Peter Anvin <hpa@zytor.com>,
        Julien Thierry <julien.thierry@arm.com>,
        Will Deacon <will.deacon@arm.com>,
        Andy Lutomirski <luto@amacapital.net>,
        Ingo Molnar <mingo@kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        James Morse <james.morse@arm.com>, valentin.schneider@arm.com,
        Brian Gerst <brgerst@gmail.com>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Andrew Lutomirski <luto@kernel.org>,
        Borislav Petkov <bp@alien8.de>,
        Denys Vlasenko <dvlasenk@redhat.com>,
        Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
        Dmitry Vyukov <dvyukov@google.com>,
        Steven Rostedt <rostedt@goodmis.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Mar 18, 2019 at 8:54 AM Peter Zijlstra <peterz@infradead.org> wrote:
>
> We rely on objtool to verify AC=1 doesn't escape. However there is no
> objtool support for x86_32, and thus we cannot guarantee the
> correctness of the 32bit code.

Absolutely not.

This is just crazy. We had working SMAP long before objtool, and we
will have it regardless of objtool.

This is like saying "ok, I don't have an oxygen sensor, so I don't
know that the air I'm breathing is sufficient to maintain life, so
I'll just stop breathing".

So no way in hell do we make SMAP go away on 32-bit for no sane reason
what-so-ever.

Besides, the x86-64 objtool coverage will cover 99% of all 32-bit code
too, simply because we share it. In fact, it will cover most of the
code for other architectures too.

                  Linus