Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 19 Mar 2019 10:29:14 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To:     Stanislav Fomichev <sdf@fomichev.me>
Cc:     Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Eric Dumazet <edumazet@google.com>,
        netdev <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tcp: don't use __constant_cpu_to_be32
Message-ID: <20190319012914.GA9313@jagdpanzerIV>
References: <20190314061514.19586-1-sergey.senozhatsky@gmail.com>
 <CANn89iJMFfh1Pkvk9LOn3FwgAfpVjwS7q5x_8Y9zo2rzpy7w9g@mail.gmail.com>
 <20190315012012.GA748@jagdpanzerIV>
 <20190315172428.GB5481@mini-arch.hsd1.ca.comcast.net>
 <20190316051902.GA27630@tigerII.localdomain>
 <20190316142646.GA10815@tigerII.localdomain>
 <20190318163208.GC7431@mini-arch.hsd1.ca.comcast.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190318163208.GC7431@mini-arch.hsd1.ca.comcast.net>
User-Agent: Mutt/1.11.4 (2019-03-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On (03/18/19 09:32), Stanislav Fomichev wrote:
[..]
> > -#define bpf_htons(x)				\
> > -	(__builtin_constant_p(x) ?		\
> > -	 __bpf_constant_htons(x) : __bpf_htons(x))
> > -#define bpf_ntohs(x)				\
> > -	(__builtin_constant_p(x) ?		\
> > -	 __bpf_constant_ntohs(x) : __bpf_ntohs(x))
> > -#define bpf_htonl(x)				\
> > -	(__builtin_constant_p(x) ?		\
> > -	 __bpf_constant_htonl(x) : __bpf_htonl(x))
> > -#define bpf_ntohl(x)				\
> > -	(__builtin_constant_p(x) ?		\
> > -	 __bpf_constant_ntohl(x) : __bpf_ntohl(x))
> > +#define bpf_htons(x)	__bpf_htons((x))
> > +#define bpf_ntohs(x)	__bpf_ntohs((x))
> > +#define bpf_htonl(x)	__bpf_htonl((x))
> > +#define bpf_ntohl(x)	__bpf_ntohl((x))
> At this point we can probably drop __bpf_xxx as well?
> Care to resend with proper description when bpf-next opens?

OK.

	-ss