Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <cover.f011581516bfe7650c9d4c6054bb828e6227e309.1551964740.git-series.maxime.ripard@bootlin.com>
 <1d374e71ffcc396b71461ea916cac3d957f8d86c.1551964740.git-series.maxime.ripard@bootlin.com>
 <CAAFQd5AKXz5QmqnSEkChf8DqPkhEuUQg--q9dZKPmB1kBR1hzA@mail.gmail.com>
 <20190313153130.hnp5eybcgjm34i4n@flea> <CAAFQd5BeiGVvDcZTFVYg_Qbw1NxRcWFybW2FcDGE=ohFWHFbYA@mail.gmail.com>
 <20190318154700.4qks2qfxown2frgk@flea>
In-Reply-To: <20190318154700.4qks2qfxown2frgk@flea>
From:   Tomasz Figa <tfiga@chromium.org>
Date:   Tue, 19 Mar 2019 13:03:58 +0900
Message-ID: <CAAFQd5D29vnxoX7Xd890_KYHdptL7NpMbhv1Jmbzibt1T4cx0g@mail.gmail.com>
Subject: Re: [PATCH v5 1/2] media: uapi: Add H264 low-level decoder API
 compound controls.
To:     Maxime Ripard <maxime.ripard@bootlin.com>
Cc:     Hans Verkuil <hans.verkuil@cisco.com>,
        Alexandre Courbot <acourbot@chromium.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Pawel Osciak <posciak@chromium.org>,
        Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
        Chen-Yu Tsai <wens@csie.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "list@263.net:IOMMU DRIVERS <iommu@lists.linux-foundation.org>, Joerg
        Roedel <joro@8bytes.org>," <linux-arm-kernel@lists.infradead.org>,
        Linux Media Mailing List <linux-media@vger.kernel.org>,
        Nicolas Dufresne <nicolas.dufresne@collabora.com>,
        jenskuske@gmail.com, Jernej Skrabec <jernej.skrabec@gmail.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Ezequiel Garcia <ezequiel@collabora.com>,
        linux-sunxi@googlegroups.com,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        Guenter Roeck <groeck@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Mar 19, 2019 at 12:47 AM Maxime Ripard
<maxime.ripard@bootlin.com> wrote:
>
> On Thu, Mar 14, 2019 at 01:13:33PM +0900, Tomasz Figa wrote:
> > On Thu, Mar 14, 2019 at 12:31 AM Maxime Ripard
> > <maxime.ripard@bootlin.com> wrote:
> > >
> > > Hi Tomasz,
> > >
> > > On Fri, Mar 08, 2019 at 03:12:18PM +0900, Tomasz Figa wrote:
> > > > > +.. _v4l2-mpeg-h264:
> > > > > +
> > > > > +``V4L2_CID_MPEG_VIDEO_H264_SPS (struct)``
> > > > > +    Specifies the sequence parameter set (as extracted from the
> > > > > +    bitstream) for the associated H264 slice data. This includes=
 the
> > > > > +    necessary parameters for configuring a stateless hardware de=
coding
> > > > > +    pipeline for H264.  The bitstream parameters are defined acc=
ording
> > > > > +    to :ref:`h264`. Unless there's a specific comment, refer to =
the
> > > > > +    specification for the documentation of these fields, section=
 7.4.2.1.1
> > > > > +    "Sequence Parameter Set Data Semantics".
> > > >
> > > > I don't see this section being added by this patch. Where does it c=
ome from?
> > >
> > > This is referring to the the H264 spec itself, as I was trying to
> > > point out with the reference in that paragraph. How would you write
> > > this down to make it more obvious?
> > >
> >
> > Aha, somehow it didn't come to my mind when reading it. How about
> > something like below?
> >
> > Unless there is a specific comment, refer to the ITU-T Rec. H.264
> > specification, section "7.4.2.1.1 Sequence parameter set data semantics=
"
> > (as of the 04/2017 edition).
>
> The :ref:`h264` currently expands to "ITU H.264", which means in the
> documentation, in the case above, it ends up as
>
>  The bitstream parameters are defined according to ITU H.264. Unless
>  there=E2=80=99s a specific comment, refer to the specification for the
>  documentation of these fields, section 7.4.2.1.1 =E2=80=9CSequence Param=
eter
>  Set Data Semantics=E2=80=9D.
>
> I could change the reference to have "ITU-T Rec. H.264 Specification
> (04/2017 Edition)". Would that work for you?
>

Sounds good to me.

How about tweaking the text a bit too?

The bitstream parameters are defined according to ITU-T Rec. H.264
Specification (04/2017 Edition), section 7.4.2.1.1 =E2=80=9CSequence Parame=
ter
Set Data Semantics=E2=80=9D. For further documentation, refer to the above
specification, unless there is an explicit comment stating otherwise.

Best regards,
Tomasz