Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp1082587img; Mon, 18 Mar 2019 23:19:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqzaJwA1wi6Z940RBpX6Zkfg/BBkN9bSxgjvIgYf8YPJ7dcyfVbT558mAg4qKbtCyxcBPjcw X-Received: by 2002:a17:902:8697:: with SMTP id g23mr816257plo.30.1552976386924; Mon, 18 Mar 2019 23:19:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552976386; cv=none; d=google.com; s=arc-20160816; b=q9tGLMyPZhmFnbz/F4GloVwby/8aue5cSHZxQK5TH+CqD/sIkV/HdlnVUqEJfpjjzf m1DANSkjwDNzaVsDC0/WCzOetFQeWOQXA+XSkUxPS0EmoLBwKTS+WmoZxP9/89nqD9Yv o7CPgxkVdgbXiou2mKmXwDtMPLxav5ppoyi/qsLPB+VwKPA4w2lhY8Y+CeehlEA7Fkvb v1CEgrw2lt2nip3VLzZyHa03rF9kgq8vDVOeeNJEfLWT+X6BdkQ5cUpPsW7B4kJvNrDE c11rxOTqiTwznQ2ouQKfUM55Jk2p/zCZGXhorCfn6KpRBqGnXA4418ZbTTLHY+7ifQ37 cHVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:message-id:date:cc:to:from:subject; bh=FB0atdn7R++ugffBKRe/aeRZsHSzjTaqw35cG7VfnPE=; b=OJfDxDsGaG8G7fXIfDf3IY6pPAggFwIVyQsy4QprRVuIb8tu0sSkN0hR/pA1VXhqhH GRC4sdkbqSMUU6BSxwsxGpXi7yHsw03U56SmC9ZbUOPhGHifMGFmIjPAcdB0IPLhIWxz RZcBGyC7EG267vI127jvsEK1uBvdFOcyijUEMg8YpxxDwZ+RfMUvO7A/UpEN6wRvD4cU Kdb1YhXbFCuolawNJaSsn1O7DAlMElIkmKLh9aDDEKahtbgiwLN/yUvZTGrSNQjRyO7d MH/4VKdptQRWHVrA9DPkk+tixN0BRCFNsrs59S4Tjkk0qOzDT3j7dNrXz2Yc7Oa+W1kg CtNg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i10si11840148plb.384.2019.03.18.23.19.30; Mon, 18 Mar 2019 23:19:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726697AbfCSGSz (ORCPT + 99 others); Tue, 19 Mar 2019 02:18:55 -0400 Received: from mga18.intel.com ([134.134.136.126]:25636 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725996AbfCSGSz (ORCPT ); Tue, 19 Mar 2019 02:18:55 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Mar 2019 23:18:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,496,1544515200"; d="scan'208";a="128177379" Received: from dwillia2-desk3.jf.intel.com (HELO dwillia2-desk3.amr.corp.intel.com) ([10.54.39.16]) by orsmga006.jf.intel.com with ESMTP; 18 Mar 2019 23:18:54 -0700 Subject: [PATCH 0/6] security/keys/encrypted: Break module dependency chain From: Dan Williams To: keyrings@vger.kernel.org Cc: Ira Weiny , Dave Jiang , Tyler Hicks , Keith Busch , Jarkko Sakkinen , David Howells , Vishal Verma , James Bottomley , Mimi Zohar , linux-integrity@vger.kernel.org, ecryptfs@vger.kernel.org, Roberto Sassu , linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org Date: Mon, 18 Mar 2019 23:06:15 -0700 Message-ID: <155297557534.2276575.16264199708584900090.stgit@dwillia2-desk3.amr.corp.intel.com> User-Agent: StGit/0.18-2-gc94f MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org With v5.1-rc1 all the nvdimm sub-system regression tests started failing because the libnvdimm module failed to load in the qemu-kvm test environment. Critically that environment does not have a TPM. Commit 240730437deb "KEYS: trusted: explicitly use tpm_chip structure..." started to require a TPM to be present for the trusted.ko module to load where there was no requirement for that before. Rather than undo the "fail if no hardware" behavior James points out that the module dependencies can be broken by looking up the key-type by name. Remove the dependencies on the "key_type_trusted" and "key_type_encrypted" symbol exports, and clean up other boilerplate that supported those exports in different configurations. --- Dan Williams (6): security/keys/encrypted: Allow operation without trusted.ko security/keys/encrypted: Clean up request_trusted_key() libnvdimm/security: Drop direct dependency on key_type_encrypted security/keys/ecryptfs: Drop direct dependency on key_type_encrypted security/integrity/evm: Drop direct dependency on key_type_encrypted security/keys/encrypted: Drop export of key_type_encrypted drivers/nvdimm/security.c | 11 ++++- fs/ecryptfs/ecryptfs_kernel.h | 22 ----------- fs/ecryptfs/keystore.c | 12 ++++++ include/keys/encrypted-type.h | 2 - include/linux/key.h | 1 security/integrity/evm/evm_crypto.c | 9 ++++ security/keys/encrypted-keys/Makefile | 3 - security/keys/encrypted-keys/encrypted.c | 35 ++++++++++++++++- security/keys/encrypted-keys/encrypted.h | 12 ------ security/keys/encrypted-keys/masterkey_trusted.c | 46 ---------------------- security/keys/internal.h | 2 - security/keys/key.c | 1 12 files changed, 65 insertions(+), 91 deletions(-) delete mode 100644 security/keys/encrypted-keys/masterkey_trusted.c