Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp1083491img; Mon, 18 Mar 2019 23:21:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqwf4F1qwEhhWdbVAMojgNihLtQ48UkKMwniiO1Z1iaSojjElN75H7etqcrA/uXQx8p05JiO X-Received: by 2002:a17:902:8697:: with SMTP id g23mr822723plo.30.1552976483472; Mon, 18 Mar 2019 23:21:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552976483; cv=none; d=google.com; s=arc-20160816; b=oJBfHcVQzh30eW/qhhxRcFfAaaEKGtS3WKN8mTlCc80OyemOAI1fzu6QwRrsyt2W0b 9b0OLZe3Z1QU3HX56zlqQU2gYz+1zCLGFV5VOGSITlu8AiJXx96KhZTDOPITBjsYv3y8 iOvR+68ySSYO1gzqdd1IMMsHpZbhcXDuzZPKcLT68tdZSjxu/NLsiSsKp1YShnvBcAf9 hoWqPvm9g+9PuSY5vfkF0UaHCTs4Yxh4COeFwvNJvgW/QwIm4khyJeSOeZUZ7KbImufi 415YjlEx0fBXjfQfbg2/qbDr9be6TlTJ8Le+idn7lrQSrKloe0rqPm5O0T/CuhwZJUWe RUsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:cc:to:from :subject; bh=U7Q2QZ9gx+LtucyoEabWLihY2E1Ek6B+450Mz6RZtsM=; b=QOEaW0/P7+y1rzaxceEC9yYsYSmW1quBb0sxxTYRWCt1KnP4xaF//l38I0O+UwbDFn uRLbNZGjX4jPeVil0CnUzouYYSj5o7N5RfSYeOI8pazY7fkikGEfeelrX27mWKupUhwZ 21cnGgqhhSTP+jU4ugbvwOymy0vdbYvxTiH8iAtOc0/3uECTO4zfloz+mutXsEMjIDMW W8m7w0CHUhycyCSv3j4gJcN3BayTTPTgAby3v0A4JOdRfDzsoQR3ceEsKYdmJla9emF4 FWFubaFv41gkH+wXzeDM8a+bfsPkJKGv83NUClQLI/Kl1YZiURnqwR2hixaS1Q64POvG hCmA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s194si10816977pgs.47.2019.03.18.23.21.08; Mon, 18 Mar 2019 23:21:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726093AbfCSGT3 (ORCPT + 99 others); Tue, 19 Mar 2019 02:19:29 -0400 Received: from mga03.intel.com ([134.134.136.65]:14405 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725996AbfCSGT1 (ORCPT ); Tue, 19 Mar 2019 02:19:27 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Mar 2019 23:19:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,496,1544515200"; d="scan'208";a="156246127" Received: from dwillia2-desk3.jf.intel.com (HELO dwillia2-desk3.amr.corp.intel.com) ([10.54.39.16]) by fmsmga001.fm.intel.com with ESMTP; 18 Mar 2019 23:19:26 -0700 Subject: [PATCH 6/6] security/keys/encrypted: Drop export of key_type_encrypted From: Dan Williams To: keyrings@vger.kernel.org Cc: Mimi Zohar , David Howells , vishal.l.verma@intel.com, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org Date: Mon, 18 Mar 2019 23:06:47 -0700 Message-ID: <155297560738.2276575.13044997734939158888.stgit@dwillia2-desk3.amr.corp.intel.com> In-Reply-To: <155297557534.2276575.16264199708584900090.stgit@dwillia2-desk3.amr.corp.intel.com> References: <155297557534.2276575.16264199708584900090.stgit@dwillia2-desk3.amr.corp.intel.com> User-Agent: StGit/0.18-2-gc94f MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Now that all users lookup the key type by name, drop the export and the direct module dependency. Cc: Mimi Zohar Cc: David Howells Signed-off-by: Dan Williams --- include/keys/encrypted-type.h | 2 -- security/keys/encrypted-keys/encrypted.c | 3 +-- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/include/keys/encrypted-type.h b/include/keys/encrypted-type.h index 1d4541370a64..dd509835b4a4 100644 --- a/include/keys/encrypted-type.h +++ b/include/keys/encrypted-type.h @@ -33,6 +33,4 @@ struct encrypted_key_payload { u8 payload_data[0]; /* payload data + datablob + hmac */ }; -extern struct key_type key_type_encrypted; - #endif /* _KEYS_ENCRYPTED_TYPE_H */ diff --git a/security/keys/encrypted-keys/encrypted.c b/security/keys/encrypted-keys/encrypted.c index 06925d3b30c9..c3999d5e2a19 100644 --- a/security/keys/encrypted-keys/encrypted.c +++ b/security/keys/encrypted-keys/encrypted.c @@ -1012,7 +1012,7 @@ static void encrypted_destroy(struct key *key) kzfree(key->payload.data[0]); } -struct key_type key_type_encrypted = { +static struct key_type key_type_encrypted = { .name = "encrypted", .instantiate = encrypted_instantiate, .update = encrypted_update, @@ -1020,7 +1020,6 @@ struct key_type key_type_encrypted = { .describe = user_describe, .read = encrypted_read, }; -EXPORT_SYMBOL_GPL(key_type_encrypted); static int __init init_encrypted(void) {