Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp1197557img; Tue, 19 Mar 2019 02:32:57 -0700 (PDT) X-Google-Smtp-Source: APXvYqwI4ggaVL4ct/+00JK692le7uQ89CbO/mh2nfPgQPOC3mae7NJl0qTPVUpk5BlBMDF5DWfO X-Received: by 2002:a62:2ec5:: with SMTP id u188mr961179pfu.99.1552987977019; Tue, 19 Mar 2019 02:32:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552987977; cv=none; d=google.com; s=arc-20160816; b=z7g+ky/TqePksEhz9/fiQpX/sO9weieLENxOJNYt72qs2OU2VjSNVL8H+YbRTp6fvn 7aHvbFnMLWhzaX4+bmijCrBvqQN+020k/cztDfWR5MSotk52IfOsayPJP0kPz9ZPGe2b DjOjN8AtjEhZ9QzzHt7PRnyeSK0szKVxSV9CjZ1w2inIvIdv4oQJA5joa3RHvlnwemrh hRCtz2BZqOZxlKK+6r622LpVJZJdJGs4v/HuFdb/d+Dzraqbynq16ZQimBX8Ob09NaUm 8HBvof9M0hNKPatW4yhbdkayq49TBcZj3oQwQnHvPy8VBJHoumH+g2caX9CkVQye+Cth Y5og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=iqS0mD2DkpD+ki4OIwDG5Tufv1Vltf3JG5TtzYwAJaQ=; b=s8f//hbR9mPD0ZW2tuDyJdQq0tCeu/HnP0G9n7dqjCdYOdRQw7TWrV4lW0YJthqtk2 Un1ZBat+zjZmxfT2H6FvMYj5ejRcxgn1P8hYGZlEk2XAGP+poUVMVuZt3ruIpE1v0D9a X0FYlS8tE+7ap74w8eZHjFpduylDoLWHPnVsyQULNcWSwTj36mV7li0ZSTe1NZ8KfEuu bOgdS4oICzpZA2ySIixW9UKam2urSGoUn1QkpMexBf3XnWICRnWmvgnL5Fjlt4QOmoLS fzO7b9k+DDSdEOQKGf7DTMQPKSvCK8BfZIRuf+RkMxzLdeMXB6vgxKzX9kCiKIMgqdPF V10w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=IQDjPx98; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s14si10916882pgs.98.2019.03.19.02.32.40; Tue, 19 Mar 2019 02:32:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=IQDjPx98; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726776AbfCSJcC (ORCPT + 99 others); Tue, 19 Mar 2019 05:32:02 -0400 Received: from mail-ot1-f67.google.com ([209.85.210.67]:38671 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725862AbfCSJcC (ORCPT ); Tue, 19 Mar 2019 05:32:02 -0400 Received: by mail-ot1-f67.google.com with SMTP id e80so11946613ote.5 for ; Tue, 19 Mar 2019 02:32:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=iqS0mD2DkpD+ki4OIwDG5Tufv1Vltf3JG5TtzYwAJaQ=; b=IQDjPx98/it3WTI1P1wn4ptXAPDKpO99H8tMiZ5yS0rw6fQtDerjKjLOVE3OcB6/H7 Y0hsSPTXZHutkEpWqLyt6pPWK7DlGrVwlQAIVFY4qle4XiMCen64rfv/kAheuvIi/KsH T/yq07jkbU1nPaLUtuV+QgZ1WSQoR1tFZX9VKdi7L62nuhBZUvwHnPfEW/f4ozg+z16k ZgaHhoEsmsR4qMEBi1ieBFuSfFytN/1ObzcyQtt2Y1TeUbCiEX/DJD0BO3B39++nIj6n iD6khJ4zb4g2GbBuWfilu9iMpvKBEIEN/9tip+Nu6SgdEgkxSdLhYo5O+4E+/i7EmLkl Cy0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=iqS0mD2DkpD+ki4OIwDG5Tufv1Vltf3JG5TtzYwAJaQ=; b=ctHTxAWUIhoyhTe6/rK+CFQtnglOqKdhm4DAPeoBi6HqCX6mwVJG26HRZx+6wal7+e A4mhOHxZN6n8ZzBBm0yEjcdvtOPjrgqGiAHvHzgZpsF1xIiI238hct1/2E/xClYs682E nlKk1klZKsk7LUjlvTAHECFqdzT4WJOYFUjlvxQpnK2X3gV2IlVmDjgCquQhNH+xQMuY KTcTiTjHO6gv45EKHSZWDIGw671ZnUhK38eKKAl/xV6lYEry8mYGjhh5r+cK0mpm15dT xeGo8sEmdeDKecbaW+sAr2wmFKubys19tDG0g8wlg8zme9J033OKxnkOqIOVRSZxkJS9 /XzA== X-Gm-Message-State: APjAAAUH/OshAZ8F8T/WjxJqCLIRCwboJEcy/70xCBDTC/KMmkzp2mvW tR9qvt+KgRFJIaLo8JYtUvs6yA== X-Received: by 2002:a9d:6857:: with SMTP id c23mr923448oto.62.1552987921852; Tue, 19 Mar 2019 02:32:01 -0700 (PDT) Received: from localhost.localdomain (li808-42.members.linode.com. [104.237.132.42]) by smtp.gmail.com with ESMTPSA id n12sm4864065otl.22.2019.03.19.02.31.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Mar 2019 02:32:01 -0700 (PDT) From: Leo Yan To: Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Leo Yan , stable@vger.kernel.org, Zhong Kaihua , John Stultz , Zhangfei Gao Subject: [RESEND PATCH] clk: hi3660: Mark clk_gate_ufs_subsys as critical Date: Tue, 19 Mar 2019 17:31:48 +0800 Message-Id: <20190319093148.1909-1-leo.yan@linaro.org> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org clk_gate_ufs_subsys is a system bus clock, turning off it will introduce lockup issue during system suspend flow. Let's mark clk_gate_ufs_subsys as critical clock, thus keeps it on during system suspend and resume. Fixes: d374e6fd5088 ("clk: hisilicon: Add clock driver for hi3660 SoC") Cc: stable@vger.kernel.org Cc: Zhong Kaihua Cc: John Stultz Cc: Zhangfei Gao Suggested-by: Dong Zhang Signed-off-by: Leo Yan --- drivers/clk/hisilicon/clk-hi3660.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/hisilicon/clk-hi3660.c b/drivers/clk/hisilicon/clk-hi3660.c index f40419959656..32ba80181cc6 100644 --- a/drivers/clk/hisilicon/clk-hi3660.c +++ b/drivers/clk/hisilicon/clk-hi3660.c @@ -164,7 +164,7 @@ static const struct hisi_gate_clock hi3660_crgctrl_gate_sep_clks[] = { { HI3660_CLK_GATE_ISP_SNCLK2, "clk_gate_isp_snclk2", "clk_isp_snclk_mux", CLK_SET_RATE_PARENT, 0x50, 18, 0, }, { HI3660_CLK_GATE_UFS_SUBSYS, "clk_gate_ufs_subsys", "clk_div_sysbus", - CLK_SET_RATE_PARENT, 0x50, 21, 0, }, + CLK_SET_RATE_PARENT|CLK_IS_CRITICAL, 0x50, 21, 0, }, { HI3660_PCLK_GATE_DSI0, "pclk_gate_dsi0", "clk_div_cfgbus", CLK_SET_RATE_PARENT, 0x50, 28, 0, }, { HI3660_PCLK_GATE_DSI1, "pclk_gate_dsi1", "clk_div_cfgbus", -- 2.17.1