Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 19 Mar 2019 12:32:37 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Emanuel Bennici <benniciemanuel78@gmail.com>
Cc:     linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Joe Perches <joe@perches.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Hardik Singh Rathore <hardiksingh.k@gmail.com>,
        Nathan Chancellor <natechancellor@gmail.com>
Subject: Re: [PATCH 05/10] staging: rtl8723bs: Remove unreachable Code in
 core/rtw_cmd.c
Message-ID: <20190319093237.GO2227@kadam>
References: <20190317183115.32393-1-benniciemanuel78@gmail.com>
 <20190317183115.32393-5-benniciemanuel78@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190317183115.32393-5-benniciemanuel78@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Mar 17, 2019 at 07:31:08PM +0100, Emanuel Bennici wrote:
> The `case INTEl_WIDI_WK_CID`-Statement in Function `u8 rtw_drvextra_cmd_hdl`
> wouldn't be used because of CONFIG_INTEL_WIDI.
> 
> Signed-off-by: Emanuel Bennici <benniciemanuel78@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_cmd.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index 91520ca3bbad..6c6ddf461590 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -2007,11 +2007,6 @@ u8 rtw_drvextra_cmd_hdl(struct adapter *padapter, unsigned char *pbuf)
>  	case CHECK_HIQ_WK_CID:
>  		rtw_chk_hi_queue_hdl(padapter);
>  		break;
> -#ifdef CONFIG_INTEL_WIDI
> -	case INTEl_WIDI_WK_CID:
> -		intel_widi_wk_hdl(padapter, pdrvextra_cmd->type, pdrvextra_cmd->pbuf);
> -		break;
> -#endif /* CONFIG_INTEL_WIDI */

Could you just remove all the CONFIG_INTEL_WIDI at once?  That would be
easier to review.

(I don't know where the other patches from this series are.  Maybe gmail
ate them).

regards,
dan carpenter