Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp1245490img; Tue, 19 Mar 2019 03:40:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqwLkz3j8REMZlUdj6EvIEN4ylrGwIjaVHykA3i5f+sNiVzKojt20B736sBJwD7bygSDu9zI X-Received: by 2002:a17:902:6b48:: with SMTP id g8mr1343938plt.21.1552992001059; Tue, 19 Mar 2019 03:40:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552992001; cv=none; d=google.com; s=arc-20160816; b=gQhCoboRJnd1cYnik9p9VAnckMC9fLFyHZ2qkdkm5FvM08FxFvTyCv/uIkUSaC56oK axUXuOTvEIH34fm9Id+tB5F/79UMBdNQ3L7XC4XtLIh2siQOWhT84fAONUsJTVxPrcUI +5M3xLYaKUKEngmp6zISk319XmCba08ckNHtv6a0Pjlh7HYKAOTvoy/LeRrqBIRMWIgQ 7JV75kY4gJUZl5Tqhx5seBWNJiiojJqbNIF0HcaWnQa6Bxvi48bdVbn4InIJpSIo8fwX LrnEn26LE8iOoI2xnZZ36yXhu3mPwZvLptefBc79nXunFAkSdSsERbTQoFOBl2Qa7srU jckA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=eKw4yLf1eOUBUuwHxxkhTpeRJ3crKXVYgQaXNghHQCE=; b=HbWwtg9PO7Vn8XTKuoXEqZJz4h7EwCsi4yu8D0O4cXYXAsau/wE8tiYJIV9+cX1IL/ Onn/l2wZw0IwEHcj/FCa9lFd8FPwVbYd9HcDZvpufLOKW1jFs4wiQnyC0HhCaH4EsWP/ ZMlJvlWh2DRP9WYtSBmPBqEVKvsHEvS9IY+TzXuCgj1dRz0roTkJSwAmmZ9k39OVJBW6 tVm9nhdGEgFKg/oQLhIBLVMTGDI9Wv2//1lTnFW1nU0HSwp0DjhkPec75ciMLkXUIk9u jlgLPN/7BsSGMMan0joS0asin+DoUrtr7zes9BEz7zMLA18aiZTYXp3EnL8wrVgSbv+R r1Zg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=CXfcdZ0S; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c4si11689578pfn.83.2019.03.19.03.39.45; Tue, 19 Mar 2019 03:40:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=CXfcdZ0S; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727627AbfCSKhd (ORCPT + 99 others); Tue, 19 Mar 2019 06:37:33 -0400 Received: from smtprelay.synopsys.com ([198.182.47.9]:48198 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726244AbfCSKhc (ORCPT ); Tue, 19 Mar 2019 06:37:32 -0400 Received: from mailhost.synopsys.com (dc2-mailhost2.synopsys.com [10.12.135.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtprelay.synopsys.com (Postfix) with ESMTPS id E430224E25C3; Tue, 19 Mar 2019 03:37:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1552991851; bh=6kxg2tSxEykM74vBi5zgLmyDXj9+ZFUZTCyY8+H2Wjo=; h=Subject:To:CC:References:From:Date:In-Reply-To:From; b=CXfcdZ0Si7Ta5Z6YOXJzTe4QpgidFLYE0aJbzpbCY3mwZ352uiHwDzf0wbYDNB7G0 DvdVRYyCjOuTKnSV+9ypPuO4ztpD/TmU7ka8hybqENWeiD1L2Dr/4H/MDsAmrrzaGs MFCOvlh8mzHt8P45wEhz3uqxy+cAwV1QULtAZL3Bg8fiTzYAlcEpnUAQyghj+Rou1/ QbNqk5iGT1ote4WD/hS4ezsWGw4vd4TGRDOQAUsixb5wqIu4mntNfwMIyvBpMM8TBP HWr98WzP+FJOUjP9bWUk5g8t7+BhscAGERJaZ6gpJZxgxwHo3Tv5NDa9qSbdKLA4FM i9m+UPkLSUIsg== Received: from US01WXQAHTC1.internal.synopsys.com (us01wxqahtc1.internal.synopsys.com [10.12.238.230]) (using TLSv1.2 with cipher AES128-SHA256 (128/128 bits)) (No client certificate requested) by mailhost.synopsys.com (Postfix) with ESMTPS id D7F47A0093; Tue, 19 Mar 2019 10:37:29 +0000 (UTC) Received: from DE02WEHTCB.internal.synopsys.com (10.225.19.94) by US01WXQAHTC1.internal.synopsys.com (10.12.238.230) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 19 Mar 2019 03:36:43 -0700 Received: from DE02WEHTCA.internal.synopsys.com (10.225.19.92) by DE02WEHTCB.internal.synopsys.com (10.225.19.94) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 19 Mar 2019 11:36:21 +0100 Received: from [10.107.19.176] (10.107.19.176) by DE02WEHTCA.internal.synopsys.com (10.225.19.80) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 19 Mar 2019 11:36:20 +0100 Subject: Re: [PATCH] net: stmmac: fix memory corruption with large MTUs To: Aaro Koskinen , "David S. Miller" , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , , CC: Aaro Koskinen References: <20190318213608.612-1-aaro.koskinen@iki.fi> From: Jose Abreu Message-ID: <92e465e5-0c77-e22f-d7e1-4689f3d655e7@synopsys.com> Date: Tue, 19 Mar 2019 10:36:19 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190318213608.612-1-aaro.koskinen@iki.fi> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.107.19.176] Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/18/2019 9:36 PM, Aaro Koskinen wrote: > /* Fill DES3 in case of RING mode */ > - if (priv->dma_buf_sz >= BUF_SIZE_8KiB) > + if (priv->dma_buf_sz == BUF_SIZE_16KiB) Shouldn't this be: "if (priv->dma_buf_sz > BUF_SIZE_8KiB)" ? Thanks, Jose Miguel Abreu