Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp1264921img; Tue, 19 Mar 2019 04:08:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqyMIrHKbKBQxQ6C4ZNme0RZcxDUSzVFQAlb5DjWeF6tB7vZL1stcj9U9cCKnVpgHxLRjPkq X-Received: by 2002:a63:544f:: with SMTP id e15mr1290789pgm.344.1552993724560; Tue, 19 Mar 2019 04:08:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552993724; cv=none; d=google.com; s=arc-20160816; b=dXdWBcr+GhNy0YFGtjeGmIHlNYYKtZXHU330ZYSgHdQucs7xPOrI6yaQF62iUnLIy0 jbl9J1l3ngOLQ8GqiogwLz36nwH0PWaH2JAOJlIK2H2mdFz3y4xBq2/MVfwaVhIhGIOs 4G25fMGASrmeRATuaLsmGTH17DuwqtUvY/UnuxWyIwCe9Zo1AJIHyENsicTIyDa+wHYA RkDa0FH6yEJWhMtBcRLLTHJHj5DDh1uhQI1Ljiqb3wPQNMcAI9oqPl0EwJudCCom29V6 wD7HZSdPxqDvwIYtml6zhKX/SqZ7Q2z3XlbZR0t+KxN0fGjFN/NoTDhcz2eDJppW7bPK NJDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:to:from:dkim-signature; bh=p3TbVBk+cuXGdgKmiQEXm20S4bVFa+SjKNrRqCol13E=; b=tbvyaG3hRo1dVpwcNyslTTel05ujR27vICeZ38BlPXYDCdR3CO/+wDI1Rp/m94jvPE E6eGxoQguyDqAmFqBvB0c4Q76y7lUjuMpf8M8G2c64o4yryJH41b+Zz1HI4jYzJ+F09m YZ6iJXZ5qffI0QZHMaocrjy43FBKSqyV8n99O7dfLZx8ZFnLqQIylerZmB9EWltRHPXK q2C1ws2ClAU/6YjBD5vNDsvVxCF0mt50Y7q9vcdDmHKaOlQkGeoIvBrGMky0fusTroyZ 6g3ebvnDryOIIx9peJgDczElr2ajdwa2yFWePc1Y1BT+gLa8/KpbYocUeQwjBSuxriZE p2iA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nokia.onmicrosoft.com header.s=selector1-nokia-com header.b=fBKBUJT5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nokia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j19si5759788pfh.124.2019.03.19.04.08.28; Tue, 19 Mar 2019 04:08:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nokia.onmicrosoft.com header.s=selector1-nokia-com header.b=fBKBUJT5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nokia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727535AbfCSLHi (ORCPT + 99 others); Tue, 19 Mar 2019 07:07:38 -0400 Received: from mail-eopbgr50091.outbound.protection.outlook.com ([40.107.5.91]:33967 "EHLO EUR03-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726573AbfCSLHi (ORCPT ); Tue, 19 Mar 2019 07:07:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nokia.onmicrosoft.com; s=selector1-nokia-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p3TbVBk+cuXGdgKmiQEXm20S4bVFa+SjKNrRqCol13E=; b=fBKBUJT5nrt/bELPwfWPoovSkky1mAyvrG7yResYAEhbdRDM4hFvtRzJhQgWocyb4xSSj+XbWWJi1XKaJ7nUeSNlaXs6jQDAHmIWTdLrYrErGLTLpKUwWAxhp2LWPdBvyN5uhL8QU5vwMQnDA9qoVjzSXYCji7MhYy+CdsV0f9s= Received: from DB6PR0701MB2487.eurprd07.prod.outlook.com (10.168.78.13) by DB6PR0701MB2872.eurprd07.prod.outlook.com (10.168.81.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1709.11; Tue, 19 Mar 2019 11:07:34 +0000 Received: from DB6PR0701MB2487.eurprd07.prod.outlook.com ([fe80::3102:a9c3:8cb7:a2c8]) by DB6PR0701MB2487.eurprd07.prod.outlook.com ([fe80::3102:a9c3:8cb7:a2c8%11]) with mapi id 15.20.1709.015; Tue, 19 Mar 2019 11:07:33 +0000 From: "Koskinen, Aaro (Nokia - FI/Espoo)" To: Jose Abreu , Aaro Koskinen , "David S. Miller" , Giuseppe Cavallaro , Alexandre Torgue , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] net: stmmac: fix memory corruption with large MTUs Thread-Topic: [PATCH] net: stmmac: fix memory corruption with large MTUs Thread-Index: AQHU3dLOd25OwllMM0aI7XUqGnqYlaYSw4eAgAAHX2M= Date: Tue, 19 Mar 2019 11:07:33 +0000 Message-ID: References: <20190318213608.612-1-aaro.koskinen@iki.fi>,<92e465e5-0c77-e22f-d7e1-4689f3d655e7@synopsys.com> In-Reply-To: <92e465e5-0c77-e22f-d7e1-4689f3d655e7@synopsys.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=aaro.koskinen@nokia.com; x-originating-ip: [131.228.2.23] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5099ea9f-7289-4a3c-49c0-08d6ac5b168f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7193020);SRVR:DB6PR0701MB2872; x-ms-traffictypediagnostic: DB6PR0701MB2872: x-microsoft-antispam-prvs: x-forefront-prvs: 0981815F2F x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(376002)(366004)(346002)(39860400002)(396003)(136003)(199004)(189003)(478600001)(2201001)(2906002)(8936002)(2501003)(4744005)(256004)(486006)(14454004)(26005)(186003)(446003)(86362001)(476003)(52536014)(11346002)(7696005)(6506007)(76176011)(3846002)(71190400001)(71200400001)(102836004)(53546011)(6116002)(99286004)(33656002)(55016002)(53936002)(74316002)(106356001)(6436002)(66066001)(7736002)(9686003)(6246003)(8676002)(105586002)(81156014)(81166006)(5660300002)(316002)(110136005)(229853002)(97736004)(25786009)(68736007)(305945005);DIR:OUT;SFP:1102;SCL:1;SRVR:DB6PR0701MB2872;H:DB6PR0701MB2487.eurprd07.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nokia.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: YebuLLQSfRhnhFuRxTtInhjrhHnKig1yDNt3IymKl1ov5zBNo9D4g4Kq3P8aQ5J9th+tSroKb8htaL8BC2MooCywwNmTFzpeUDUzXn/1fcilSxp74fzGqjkG7WHS0DoYUL05aJswaVgp/mHayBgQhfpcE6w0C5oxXT9mcv4wIOCNc6C8hezoxFKN+pdJh5uIwurgMmarx+Ag3ABci+V1bl87ZA1IMokKUk3ufIDuvCFvv9iB2fjP2nkmNe2cCxh2l6OQx1aiVXGe3l/u8vM+CZSA1/gHTbWAG2/IlEBjDVWjBGRNEaiBbO4mSMAboHFggv0pMdXvrha0nFvuz+9BuR8RovQgIzl+mph5OInUakRLNyvh/sgVydH9kAX3LrbAqNCyFk5uHanSQYEG3/BxdO9lhjRWw4hxlFyJgRQ8PBU= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nokia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5099ea9f-7289-4a3c-49c0-08d6ac5b168f X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Mar 2019 11:07:33.9544 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 5d471751-9675-428d-917b-70f44f9630b0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0701MB2872 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, From: Jose Abreu [jose.abreu@synopsys.com]: > On 3/18/2019 9:36 PM, Aaro Koskinen wrote: > > /* Fill DES3 in case of RING mode */ > > - if (priv->dma_buf_sz >=3D BUF_SIZE_8KiB) > > + if (priv->dma_buf_sz =3D=3D BUF_SIZE_16KiB) > > Shouldn't this be: "if (priv->dma_buf_sz > BUF_SIZE_8KiB)" ? I think it should be the same as in stmmac_init_rx_buffers(): if (priv->dma_buf_sz =3D=3D BUF_SIZE_16KiB) stmmac_init_desc3(priv, p); A.