Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.80.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com;
Envelope-to: arnd@arndb.de,
 gregkh@linuxfoundation.org,
 michal.simek@xilinx.com,
 linux-arm-kernel@lists.infradead.org,
 linux-kernel@vger.kernel.org,
 dragan.cvetic@xilinx.com,
 derek.kiernan@xilinx.com
From:   Dragan Cvetic <dragan.cvetic@xilinx.com>
To:     <arnd@arndb.de>, <gregkh@linuxfoundation.org>,
        <michal.simek@xilinx.com>, <linux-arm-kernel@lists.infradead.org>
CC:     <linux-kernel@vger.kernel.org>,
        Dragan Cvetic <dragan.cvetic@xilinx.com>,
        Derek Kiernan <derek.kiernan@xilinx.com>
Subject: [PATCH 08/12] misc: xilinx_sdfec: Add ability to get/set config
Date:   Tue, 19 Mar 2019 12:04:20 +0000
Message-ID: <1552997064-432700-9-git-send-email-dragan.cvetic@xilinx.com>
In-Reply-To: <1552997064-432700-1-git-send-email-dragan.cvetic@xilinx.com>
References: <1552997064-432700-1-git-send-email-dragan.cvetic@xilinx.com>
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2019 12:04:39.0586
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: de19e4a9-0129-4999-0b09-08d6ac631027
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.80.198];Helo=[xir-pvapexch01.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB5916
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

- Add capability to get SD-FEC config data using ioctl
XSDFEC_GET_CONFIG.

- Add capability to set SD-FEC data order using ioctl
SDFEC_SET_ORDER. The order of data blocks can change
from input to output or to be maintained.

- Add capability to set SD-FEC bypass option using ioctl
XSDFEC_SET_BYPASS. The bypass mode is when HW is
configured to skip SD-FEC engine and redirect input
directly to output.

- Add capability to set SD-FEC active state using ioctl
XSDFEC_IS_ACTIVE. Support for ioctl which puts SD-FEC
in active or non-active state.

Reviewed-by: Michal Simek <michal.simek@xilinx.com>
Tested-by: Dragan Cvetic <dragan.cvetic@xilinx.com>
Signed-off-by: Derek Kiernan <derek.kiernan@xilinx.com>
Signed-off-by: Dragan Cvetic <dragan.cvetic@xilinx.com>
---
 drivers/misc/xilinx_sdfec.c      | 86 ++++++++++++++++++++++++++++++++++++=
++++
 include/uapi/misc/xilinx_sdfec.h | 57 ++++++++++++++++++++++++++
 2 files changed, 143 insertions(+)

diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c
index 088ad9d..e980b70 100644
--- a/drivers/misc/xilinx_sdfec.c
+++ b/drivers/misc/xilinx_sdfec.c
@@ -309,6 +309,19 @@ static int xsdfec_dev_release(struct inode *iptr, stru=
ct file *fptr)
        return 0;
 }

+static int xsdfec_get_config(struct xsdfec_dev *xsdfec, void __user *arg)
+{
+       int err;
+
+       err =3D copy_to_user(arg, &xsdfec->config, sizeof(xsdfec->config));
+       if (err) {
+               dev_err(xsdfec->dev, "%s failed for SDFEC%d", __func__,
+                       xsdfec->config.fec_id);
+               err =3D -EFAULT;
+       }
+       return err;
+}
+
 static int xsdfec_set_turbo(struct xsdfec_dev *xsdfec, void __user *arg)
 {
        struct xsdfec_turbo turbo;
@@ -670,6 +683,67 @@ static int xsdfec_add_ldpc(struct xsdfec_dev *xsdfec, =
void __user *arg)
        return ret;
 }

+static int xsdfec_set_order(struct xsdfec_dev *xsdfec, void __user *arg)
+{
+       bool order_invalid;
+       enum xsdfec_order order =3D *((enum xsdfec_order *)arg);
+
+       order_invalid =3D (order !=3D XSDFEC_MAINTAIN_ORDER) &&
+                       (order !=3D XSDFEC_OUT_OF_ORDER);
+       if (order_invalid) {
+               dev_err(xsdfec->dev, "%s invalid order value %d for SDFEC%d=
",
+                       __func__, order, xsdfec->config.fec_id);
+               return -EINVAL;
+       }
+
+       /* Verify Device has not started */
+       if (xsdfec->state =3D=3D XSDFEC_STARTED) {
+               dev_err(xsdfec->dev,
+                       "%s attempting to set Order while started for SDFEC=
%d",
+                       __func__, xsdfec->config.fec_id);
+               return -EIO;
+       }
+
+       xsdfec_regwrite(xsdfec, XSDFEC_ORDER_ADDR, order);
+
+       xsdfec->config.order =3D order;
+
+       return 0;
+}
+
+static int xsdfec_set_bypass(struct xsdfec_dev *xsdfec, bool __user *arg)
+{
+       bool bypass =3D *arg;
+
+       /* Verify Device has not started */
+       if (xsdfec->state =3D=3D XSDFEC_STARTED) {
+               dev_err(xsdfec->dev,
+                       "%s attempting to set bypass while started for SDFE=
C%d",
+                       __func__, xsdfec->config.fec_id);
+               return -EIO;
+       }
+
+       if (bypass)
+               xsdfec_regwrite(xsdfec, XSDFEC_BYPASS_ADDR, 1);
+       else
+               xsdfec_regwrite(xsdfec, XSDFEC_BYPASS_ADDR, 0);
+
+       xsdfec->config.bypass =3D bypass;
+
+       return 0;
+}
+
+static int xsdfec_is_active(struct xsdfec_dev *xsdfec, bool __user *is_act=
ive)
+{
+       u32 reg_value;
+
+       reg_value =3D xsdfec_regread(xsdfec, XSDFEC_ACTIVE_ADDR);
+       /* using a double ! operator instead of casting */
+       *is_active =3D !!(reg_value & XSDFEC_IS_ACTIVITY_SET);
+
+       return 0;
+}
+
 static u32
 xsdfec_translate_axis_width_cfg_val(enum xsdfec_axis_width axis_width_cfg)
 {
@@ -771,6 +845,9 @@ static long xsdfec_dev_ioctl(struct file *fptr, unsigne=
d int cmd,
        }

        switch (cmd) {
+       case XSDFEC_GET_CONFIG:
+               rval =3D xsdfec_get_config(xsdfec, arg);
+               break;
        case XSDFEC_SET_TURBO:
                rval =3D xsdfec_set_turbo(xsdfec, arg);
                break;
@@ -780,6 +857,15 @@ static long xsdfec_dev_ioctl(struct file *fptr, unsign=
ed int cmd,
        case XSDFEC_ADD_LDPC_CODE_PARAMS:
                rval =3D xsdfec_add_ldpc(xsdfec, arg);
                break;
+       case XSDFEC_SET_ORDER:
+               rval =3D xsdfec_set_order(xsdfec, arg);
+               break;
+       case XSDFEC_SET_BYPASS:
+               rval =3D xsdfec_set_bypass(xsdfec, arg);
+               break;
+       case XSDFEC_IS_ACTIVE:
+               rval =3D xsdfec_is_active(xsdfec, (bool __user *)arg);
+               break;
        default:
                /* Should not get here */
                dev_err(xsdfec->dev, "Undefined SDFEC IOCTL");
diff --git a/include/uapi/misc/xilinx_sdfec.h b/include/uapi/misc/xilinx_sd=
fec.h
index b70dbff..c6584a4 100644
--- a/include/uapi/misc/xilinx_sdfec.h
+++ b/include/uapi/misc/xilinx_sdfec.h
@@ -310,6 +310,19 @@ xsdfec_calculate_shared_ldpc_table_entry_size(struct x=
sdfec_ldpc_params *ldpc,
 #define XSDFEC_ADD_LDPC_CODE_PARAMS                                       =
     \
        _IOW(XSDFEC_MAGIC, 5, struct xsdfec_ldpc_params *)
 /**
+ * DOC: XSDFEC_GET_CONFIG
+ * @Parameters
+ *
+ * @struct xsdfec_config *
+ *     Pointer to the &struct xsdfec_config that contains the current
+ *     configuration settings of the SD-FEC Block
+ *
+ * @Description
+ *
+ * ioctl that returns SD-FEC core configuration
+ */
+#define XSDFEC_GET_CONFIG _IOR(XSDFEC_MAGIC, 6, struct xsdfec_config *)
+/**
  * DOC: XSDFEC_GET_TURBO
  * @Parameters
  *
@@ -322,4 +335,48 @@ xsdfec_calculate_shared_ldpc_table_entry_size(struct x=
sdfec_ldpc_params *ldpc,
  * ioctl that returns SD-FEC turbo param values
  */
 #define XSDFEC_GET_TURBO _IOR(XSDFEC_MAGIC, 7, struct xsdfec_turbo *)
+/**
+ * DOC: XSDFEC_SET_ORDER
+ * @Parameters
+ *
+ * @struct unsigned long *
+ *     Pointer to the unsigned long that contains a value from the
+ *     @enum xsdfec_order
+ *
+ * @Description
+ *
+ * ioctl that sets order, if order of blocks can change from input to outp=
ut
+ *
+ * This can only be used when the driver is in the XSDFEC_STOPPED state
+ */
+#define XSDFEC_SET_ORDER _IOW(XSDFEC_MAGIC, 8, unsigned long *)
+/**
+ * DOC: XSDFEC_SET_BYPASS
+ * @Parameters
+ *
+ * @struct bool *
+ *     Pointer to bool that sets the bypass value, where false results in
+ *     normal operation and false results in the SD-FEC performing the
+ *     configured operations (same number of cycles) but output data match=
es
+ *     the input data
+ *
+ * @Description
+ *
+ * ioctl that sets bypass.
+ *
+ * This can only be used when the driver is in the XSDFEC_STOPPED state
+ */
+#define XSDFEC_SET_BYPASS _IOW(XSDFEC_MAGIC, 9, bool *)
+/**
+ * DOC: XSDFEC_IS_ACTIVE
+ * @Parameters
+ *
+ * @struct bool *
+ *     Pointer to bool that returns true if the SD-FEC is processing data
+ *
+ * @Description
+ *
+ * ioctl that determines if SD-FEC is processing data
+ */
+#define XSDFEC_IS_ACTIVE _IOR(XSDFEC_MAGIC, 10, bool *)
 #endif /* __XILINX_SDFEC_H__ */
--
2.7.4

This email and any attachments are intended for the sole use of the named r=
ecipient(s) and contain(s) confidential information that may be proprietary=
, privileged or copyrighted under applicable law. If you are not the intend=
ed recipient, do not read, copy, or forward this email message or any attac=
hments. Delete this email message and any attachments immediately.