Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.80.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com;
Envelope-to: arnd@arndb.de,
 gregkh@linuxfoundation.org,
 michal.simek@xilinx.com,
 linux-arm-kernel@lists.infradead.org,
 linux-kernel@vger.kernel.org,
 dragan.cvetic@xilinx.com,
 derek.kiernan@xilinx.com
From:   Dragan Cvetic <dragan.cvetic@xilinx.com>
To:     <arnd@arndb.de>, <gregkh@linuxfoundation.org>,
        <michal.simek@xilinx.com>, <linux-arm-kernel@lists.infradead.org>
CC:     <linux-kernel@vger.kernel.org>,
        Dragan Cvetic <dragan.cvetic@xilinx.com>,
        Derek Kiernan <derek.kiernan@xilinx.com>
Subject: [PATCH 09/12] misc: xilinx_sdfec: Support poll file operation
Date:   Tue, 19 Mar 2019 12:04:21 +0000
Message-ID: <1552997064-432700-10-git-send-email-dragan.cvetic@xilinx.com>
In-Reply-To: <1552997064-432700-1-git-send-email-dragan.cvetic@xilinx.com>
References: <1552997064-432700-1-git-send-email-dragan.cvetic@xilinx.com>
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2019 12:04:40.8757
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 82d62a43-8bb5-4991-ea94-08d6ac63115b
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.80.198];Helo=[xir-pvapexch02.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR02MB5907
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Support monitoring and detecting the SD-FEC error events
through IRQ and poll file operation.

The SD-FEC device can detect one-error or multi-error events.
An error triggers an interrupt which creates and run the ONE_SHOT
IRQ thread.
The ONE_SHOT IRQ thread detects type of error and pass that
information to the poll function.
The file_operation callback poll(), collects the events and
updates the statistics accordingly.
The function poll blocks() on waiting queue which can be
unblocked by ONE_SHOT IRQ handling thread.

Support SD-FEC interrupt set ioctl callback.
The SD-FEC can detect two type of errors: coding errors (ECC) and
a data interface errors (TLAST).
The errors are  events which can trigger an IRQ if enabled.
The driver can monitor and detect these errors through IRQ.
Also the driver updates the statistical data.

Reviewed-by: Michal Simek <michal.simek@xilinx.com>
Tested-by: Dragan Cvetic <dragan.cvetic@xilinx.com>
Signed-off-by: Derek Kiernan <derek.kiernan@xilinx.com>
Signed-off-by: Dragan Cvetic <dragan.cvetic@xilinx.com>
---
 drivers/misc/xilinx_sdfec.c      | 286 +++++++++++++++++++++++++++++++++++=
++++
 include/uapi/misc/xilinx_sdfec.h |  13 ++
 2 files changed, 299 insertions(+)

diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c
index e980b70..b48a881 100644
--- a/drivers/misc/xilinx_sdfec.c
+++ b/drivers/misc/xilinx_sdfec.c
@@ -201,8 +201,15 @@ struct xsdfec_clks {
  * @dev: pointer to device struct
  * @state: State of the SDFEC device
  * @config: Configuration of the SDFEC device
+ * @state_updated: indicates State updated by interrupt handler
+ * @stats_updated: indicates Stats updated by interrupt handler
+ * @isr_err_count: Count of ISR errors
+ * @cecc_count: Count of Correctable ECC errors (SBE)
+ * @uecc_count: Count of Uncorrectable ECC errors (MBE)
  * @open_count: Count of char device being opened
+ * @irq: IRQ number
  * @xsdfec_cdev: Character device handle
+ * @waitq: Driver wait queue
  * @irq_lock: Driver spinlock
  * @clks: Clocks managed by the SDFEC driver
  *
@@ -213,8 +220,15 @@ struct xsdfec_dev {
        struct device *dev;
        enum xsdfec_state state;
        struct xsdfec_config config;
+       bool state_updated;
+       bool stats_updated;
+       atomic_t isr_err_count;
+       atomic_t cecc_count;
+       atomic_t uecc_count;
        atomic_t open_count;
+       int irq;
        struct cdev xsdfec_cdev;
+       wait_queue_head_t waitq;
        /* Spinlock to protect state_updated and stats_updated */
        spinlock_t irq_lock;
        struct xsdfec_clks clks;
@@ -322,6 +336,93 @@ static int xsdfec_get_config(struct xsdfec_dev *xsdfec=
, void __user *arg)
        return err;
 }

+static int xsdfec_isr_enable(struct xsdfec_dev *xsdfec, bool enable)
+{
+       u32 mask_read;
+
+       if (enable) {
+               /* Enable */
+               xsdfec_regwrite(xsdfec, XSDFEC_IER_ADDR, XSDFEC_ISR_MASK);
+               mask_read =3D xsdfec_regread(xsdfec, XSDFEC_IMR_ADDR);
+               if (mask_read & XSDFEC_ISR_MASK) {
+                       dev_err(xsdfec->dev,
+                               "SDFEC enabling irq with IER failed");
+                       return -EIO;
+               }
+       } else {
+               /* Disable */
+               xsdfec_regwrite(xsdfec, XSDFEC_IDR_ADDR, XSDFEC_ISR_MASK);
+               mask_read =3D xsdfec_regread(xsdfec, XSDFEC_IMR_ADDR);
+               if ((mask_read & XSDFEC_ISR_MASK) !=3D XSDFEC_ISR_MASK) {
+                       dev_err(xsdfec->dev,
+                               "SDFEC disabling irq with IDR failed");
+                       return -EIO;
+               }
+       }
+       return 0;
+}
+
+static int xsdfec_ecc_isr_enable(struct xsdfec_dev *xsdfec, bool enable)
+{
+       u32 mask_read;
+
+       if (enable) {
+               /* Enable */
+               xsdfec_regwrite(xsdfec, XSDFEC_ECC_IER_ADDR,
+                               XSDFEC_ALL_ECC_ISR_MASK);
+               mask_read =3D xsdfec_regread(xsdfec, XSDFEC_ECC_IMR_ADDR);
+               if (mask_read & XSDFEC_ALL_ECC_ISR_MASK) {
+                       dev_err(xsdfec->dev,
+                               "SDFEC enabling ECC irq with ECC IER failed=
");
+                       return -EIO;
+               }
+       } else {
+               /* Disable */
+               xsdfec_regwrite(xsdfec, XSDFEC_ECC_IDR_ADDR,
+                               XSDFEC_ALL_ECC_ISR_MASK);
+               mask_read =3D xsdfec_regread(xsdfec, XSDFEC_ECC_IMR_ADDR);
+               if (!(((mask_read & XSDFEC_ALL_ECC_ISR_MASK) =3D=3D
+                      XSDFEC_ECC_ISR_MASK) ||
+                     ((mask_read & XSDFEC_ALL_ECC_ISR_MASK) =3D=3D
+                      XSDFEC_PL_INIT_ECC_ISR_MASK))) {
+                       dev_err(xsdfec->dev,
+                               "SDFEC disable ECC irq with ECC IDR failed"=
);
+                       return -EIO;
+               }
+       }
+       return 0;
+}
+
+static int xsdfec_set_irq(struct xsdfec_dev *xsdfec, void __user *arg)
+{
+       struct xsdfec_irq irq;
+       int err;
+       int isr_err;
+       int ecc_err;
+
+       err =3D copy_from_user(&irq, arg, sizeof(irq));
+       if (err) {
+               dev_err(xsdfec->dev, "%s failed for SDFEC%d", __func__,
+                       xsdfec->config.fec_id);
+               return -EFAULT;
+       }
+
+       /* Setup tlast related IRQ */
+       isr_err =3D xsdfec_isr_enable(xsdfec, irq.enable_isr);
+       if (!isr_err)
+               xsdfec->config.irq.enable_isr =3D irq.enable_isr;
+
+       /* Setup ECC related IRQ */
+       ecc_err =3D xsdfec_ecc_isr_enable(xsdfec, irq.enable_ecc_isr);
+       if (!ecc_err)
+               xsdfec->config.irq.enable_ecc_isr =3D irq.enable_ecc_isr;
+
+       if (isr_err < 0 || ecc_err < 0)
+               err =3D -EIO;
+
+       return err;
+}
+
 static int xsdfec_set_turbo(struct xsdfec_dev *xsdfec, void __user *arg)
 {
        struct xsdfec_turbo turbo;
@@ -848,6 +949,9 @@ static long xsdfec_dev_ioctl(struct file *fptr, unsigne=
d int cmd,
        case XSDFEC_GET_CONFIG:
                rval =3D xsdfec_get_config(xsdfec, arg);
                break;
+       case XSDFEC_SET_IRQ:
+               rval =3D xsdfec_set_irq(xsdfec, arg);
+               break;
        case XSDFEC_SET_TURBO:
                rval =3D xsdfec_set_turbo(xsdfec, arg);
                break;
@@ -874,11 +978,34 @@ static long xsdfec_dev_ioctl(struct file *fptr, unsig=
ned int cmd,
        return rval;
 }

+static unsigned int xsdfec_poll(struct file *file, poll_table *wait)
+{
+       unsigned int mask =3D 0;
+       struct xsdfec_dev *xsdfec =3D file->private_data;
+
+       if (!xsdfec)
+               return POLLNVAL | POLLHUP;
+
+       poll_wait(file, &xsdfec->waitq, wait);
+
+       /* XSDFEC ISR detected an error */
+       spin_lock_irq(&xsdfec->irq_lock);
+       if (xsdfec->state_updated)
+               mask |=3D POLLIN | POLLPRI;
+
+       if (xsdfec->stats_updated)
+               mask |=3D POLLIN | POLLRDNORM;
+       spin_unlock_irq(&xsdfec->irq_lock);
+
+       return mask;
+}
+
 static const struct file_operations xsdfec_fops =3D {
        .owner =3D THIS_MODULE,
        .open =3D xsdfec_dev_open,
        .release =3D xsdfec_dev_release,
        .unlocked_ioctl =3D xsdfec_dev_ioctl,
+       .poll =3D xsdfec_poll,
 };

 static int xsdfec_parse_of(struct xsdfec_dev *xsdfec)
@@ -979,6 +1106,146 @@ static int xsdfec_parse_of(struct xsdfec_dev *xsdfec=
)
        return 0;
 }

+static void xsdfec_count_and_clear_ecc_multi_errors(struct xsdfec_dev *xsd=
fec,
+                                                   u32 uecc)
+{
+       u32 uecc_event;
+
+       /* Update ECC ISR error counts */
+       atomic_add(hweight32(uecc), &xsdfec->uecc_count);
+       xsdfec->stats_updated =3D true;
+
+       /* Clear ECC errors */
+       xsdfec_regwrite(xsdfec, XSDFEC_ECC_ISR_ADDR,
+                       XSDFEC_ALL_ECC_ISR_MBE_MASK);
+       /* Clear ECC events */
+       if (uecc & XSDFEC_ECC_ISR_MBE_MASK) {
+               uecc_event =3D uecc >> XSDFEC_ECC_ISR_MBE_TO_EVENT_SHIFT;
+               xsdfec_regwrite(xsdfec, XSDFEC_ECC_ISR_ADDR, uecc_event);
+       } else if (uecc & XSDFEC_PL_INIT_ECC_ISR_MBE_MASK) {
+               uecc_event =3D uecc >> XSDFEC_PL_INIT_ECC_ISR_MBE_TO_EVENT_=
SHIFT;
+               xsdfec_regwrite(xsdfec, XSDFEC_ECC_ISR_ADDR, uecc_event);
+       }
+}
+
+static void xsdfec_count_and_clear_ecc_single_errors(struct xsdfec_dev *xs=
dfec,
+                                                    u32 cecc, u32 sbe_mask=
)
+{
+       /* Update ECC ISR error counts */
+       atomic_add(hweight32(cecc), &xsdfec->cecc_count);
+       xsdfec->stats_updated =3D true;
+
+       /* Clear ECC errors */
+       xsdfec_regwrite(xsdfec, XSDFEC_ECC_ISR_ADDR, sbe_mask);
+}
+
+static void xsdfec_count_and_clear_isr_errors(struct xsdfec_dev *xsdfec,
+                                             u32 isr_err)
+{
+       /* Update ISR error counts */
+       atomic_add(hweight32(isr_err), &xsdfec->isr_err_count);
+       xsdfec->stats_updated =3D true;
+
+       /* Clear ISR error status */
+       xsdfec_regwrite(xsdfec, XSDFEC_ISR_ADDR, XSDFEC_ISR_MASK);
+}
+
+static void xsdfec_update_state_for_isr_err(struct xsdfec_dev *xsdfec)
+{
+       xsdfec->state =3D XSDFEC_NEEDS_RESET;
+       xsdfec->state_updated =3D true;
+}
+
+static void xsdfec_update_state_for_ecc_err(struct xsdfec_dev *xsdfec,
+                                           u32 ecc_err)
+{
+       if (ecc_err & XSDFEC_ECC_ISR_MBE_MASK)
+               xsdfec->state =3D XSDFEC_NEEDS_RESET;
+       else if (ecc_err & XSDFEC_PL_INIT_ECC_ISR_MBE_MASK)
+               xsdfec->state =3D XSDFEC_PL_RECONFIGURE;
+
+       xsdfec->state_updated =3D true;
+}
+
+static int xsdfec_get_sbe_mask(u32 ecc_err)
+{
+       u32 sbe_mask =3D XSDFEC_ALL_ECC_ISR_SBE_MASK;
+
+       if (ecc_err & XSDFEC_ECC_ISR_MBE_MASK) {
+               sbe_mask =3D (XSDFEC_ECC_ISR_MBE_MASK - ecc_err) >>
+                          XSDFEC_ECC_ISR_MBE_TO_EVENT_SHIFT;
+       } else if (ecc_err & XSDFEC_PL_INIT_ECC_ISR_MBE_MASK)
+               sbe_mask =3D (XSDFEC_PL_INIT_ECC_ISR_MBE_MASK - ecc_err) >>
+                          XSDFEC_PL_INIT_ECC_ISR_MBE_TO_EVENT_SHIFT;
+
+       return sbe_mask;
+}
+
+static irqreturn_t xsdfec_irq_thread(int irq, void *dev_id)
+{
+       struct xsdfec_dev *xsdfec =3D dev_id;
+       irqreturn_t ret =3D IRQ_HANDLED;
+       u32 ecc_err;
+       u32 isr_err;
+       u32 err_value;
+       u32 sbe_mask;
+
+       WARN_ON(xsdfec->irq !=3D irq);
+
+       /* Mask Interrupts */
+       xsdfec_isr_enable(xsdfec, false);
+       xsdfec_ecc_isr_enable(xsdfec, false);
+
+       /* Read Interrupt Status Registers */
+       ecc_err =3D xsdfec_regread(xsdfec, XSDFEC_ECC_ISR_ADDR);
+       isr_err =3D xsdfec_regread(xsdfec, XSDFEC_ISR_ADDR);
+
+       spin_lock(&xsdfec->irq_lock);
+
+       err_value =3D ecc_err & XSDFEC_ALL_ECC_ISR_MBE_MASK;
+       if (err_value) {
+               dev_err(xsdfec->dev, "Multi-bit error on xsdfec%d",
+                       xsdfec->config.fec_id);
+               /* Count and clear multi-bit errors and associated events *=
/
+               xsdfec_count_and_clear_ecc_multi_errors(xsdfec, err_value);
+               xsdfec_update_state_for_ecc_err(xsdfec, ecc_err);
+       }
+
+       /*
+        * Update SBE mask to remove events associated with MBE if present.
+        * If no MBEs are present will return mask for all SBE bits
+        */
+       sbe_mask =3D xsdfec_get_sbe_mask(err_value);
+       err_value =3D ecc_err & sbe_mask;
+       if (err_value) {
+               dev_info(xsdfec->dev, "Correctable error on xsdfec%d",
+                        xsdfec->config.fec_id);
+               xsdfec_count_and_clear_ecc_single_errors(xsdfec, err_value,
+                                                        sbe_mask);
+       }
+
+       err_value =3D isr_err & XSDFEC_ISR_MASK;
+       if (err_value) {
+               dev_err(xsdfec->dev,
+                       "Tlast,or DIN_WORDS or DOUT_WORDS not correct");
+               xsdfec_count_and_clear_isr_errors(xsdfec, err_value);
+               xsdfec_update_state_for_isr_err(xsdfec);
+       }
+
+       if (xsdfec->state_updated || xsdfec->stats_updated)
+               wake_up_interruptible(&xsdfec->waitq);
+       else
+               ret =3D IRQ_NONE;
+
+       /* Unmaks Interrupts */
+       xsdfec_isr_enable(xsdfec, true);
+       xsdfec_ecc_isr_enable(xsdfec, true);
+
+       spin_unlock(&xsdfec->irq_lock);
+
+       return ret;
+}
+
 static int xsdfec_clk_init(struct platform_device *pdev,
                           struct xsdfec_clks *clks)
 {
@@ -1109,6 +1376,7 @@ static int xsdfec_probe(struct platform_device *pdev)
        struct device *dev_create;
        struct resource *res;
        int err;
+       bool irq_enabled =3D true;

        xsdfec =3D devm_kzalloc(&pdev->dev, sizeof(*xsdfec), GFP_KERNEL);
        if (!xsdfec)
@@ -1131,6 +1399,12 @@ static int xsdfec_probe(struct platform_device *pdev=
)
                goto err_xsdfec_dev;
        }

+       xsdfec->irq =3D platform_get_irq(pdev, 0);
+       if (xsdfec->irq < 0) {
+               dev_dbg(dev, "platform_get_irq failed");
+               irq_enabled =3D false;
+       }
+
        err =3D xsdfec_parse_of(xsdfec);
        if (err < 0)
                goto err_xsdfec_dev;
@@ -1140,6 +1414,18 @@ static int xsdfec_probe(struct platform_device *pdev=
)
        /* Save driver private data */
        platform_set_drvdata(pdev, xsdfec);

+       if (irq_enabled) {
+               init_waitqueue_head(&xsdfec->waitq);
+               /* Register IRQ thread */
+               err =3D devm_request_threaded_irq(dev, xsdfec->irq, NULL,
+                                               xsdfec_irq_thread, IRQF_ONE=
SHOT,
+                                               "xilinx-sdfec16", xsdfec);
+               if (err < 0) {
+                       dev_err(dev, "unable to request IRQ%d", xsdfec->irq=
);
+                       goto err_xsdfec_dev;
+               }
+       }
+
        cdev_init(&xsdfec->xsdfec_cdev, &xsdfec_fops);
        xsdfec->xsdfec_cdev.owner =3D THIS_MODULE;
        err =3D cdev_add(&xsdfec->xsdfec_cdev,
diff --git a/include/uapi/misc/xilinx_sdfec.h b/include/uapi/misc/xilinx_sd=
fec.h
index c6584a4..8dfada9 100644
--- a/include/uapi/misc/xilinx_sdfec.h
+++ b/include/uapi/misc/xilinx_sdfec.h
@@ -274,6 +274,19 @@ xsdfec_calculate_shared_ldpc_table_entry_size(struct x=
sdfec_ldpc_params *ldpc,
  */
 #define XSDFEC_MAGIC 'f'
 /**
+ * DOC: XSDFEC_SET_IRQ
+ * @Parameters
+ *
+ * @struct xsdfec_irq *
+ *     Pointer to the &struct xsdfec_irq that contains the interrupt setti=
ngs
+ *     for the SD-FEC core
+ *
+ * @Description
+ *
+ * ioctl to enable or disable irq
+ */
+#define XSDFEC_SET_IRQ _IOW(XSDFEC_MAGIC, 3, struct xsdfec_irq *)
+/**
  * DOC: XSDFEC_SET_TURBO
  * @Parameters
  *
--
2.7.4

This email and any attachments are intended for the sole use of the named r=
ecipient(s) and contain(s) confidential information that may be proprietary=
, privileged or copyrighted under applicable law. If you are not the intend=
ed recipient, do not read, copy, or forward this email message or any attac=
hments. Delete this email message and any attachments immediately.