Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 19 Mar 2019 13:50:04 +0100
From:   Simon Horman <horms@verge.net.au>
To:     Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc:     linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
        Lee Jones <lee.jones@linaro.org>,
        Mark Brown <broonie@kernel.org>,
        Support Opensource <support.opensource@diasemi.com>,
        Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 6/6] regulator: da9063: platform_data is gone, depend on
 OF
Message-ID: <20190319125004.bpx3jcxqiajeupiy@verge.net.au>
References: <20190318154759.21978-1-wsa+renesas@sang-engineering.com>
 <20190318154759.21978-7-wsa+renesas@sang-engineering.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190318154759.21978-7-wsa+renesas@sang-engineering.com>
Organisation: Horms Solutions BV
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Mar 18, 2019 at 04:47:58PM +0100, Wolfram Sang wrote:
> With OF being the only configuration possibility left, depend on it to
> simplify some code.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

> ---
>  drivers/regulator/Kconfig            |  2 +-
>  drivers/regulator/da9063-regulator.c | 10 ----------
>  2 files changed, 1 insertion(+), 11 deletions(-)
> 
> diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
> index b7f249ee5e68..6663cd6cb96c 100644
> --- a/drivers/regulator/Kconfig
> +++ b/drivers/regulator/Kconfig
> @@ -256,7 +256,7 @@ config REGULATOR_DA9062
>  
>  config REGULATOR_DA9063
>  	tristate "Dialog Semiconductor DA9063 regulators"
> -	depends on MFD_DA9063
> +	depends on MFD_DA9063 && OF
>  	help
>  	  Say y here to support the BUCKs and LDOs regulators found on
>  	  DA9063 PMICs.
> diff --git a/drivers/regulator/da9063-regulator.c b/drivers/regulator/da9063-regulator.c
> index c05859ad63d8..2eda8d985756 100644
> --- a/drivers/regulator/da9063-regulator.c
> +++ b/drivers/regulator/da9063-regulator.c
> @@ -681,7 +681,6 @@ static const struct regulator_init_data *da9063_get_regulator_initdata(
>  	return NULL;
>  }
>  
> -#ifdef CONFIG_OF
>  static struct of_regulator_match da9063_matches[] = {
>  	[DA9063_ID_BCORE1]           = { .name = "bcore1"           },
>  	[DA9063_ID_BCORE2]           = { .name = "bcore2"           },
> @@ -759,15 +758,6 @@ static struct da9063_regulators_pdata *da9063_parse_regulators_dt(
>  	*da9063_reg_matches = da9063_matches;
>  	return pdata;
>  }
> -#else
> -static struct da9063_regulators_pdata *da9063_parse_regulators_dt(
> -		struct platform_device *pdev,
> -		struct of_regulator_match **da9063_reg_matches)
> -{
> -	*da9063_reg_matches = NULL;
> -	return ERR_PTR(-ENODEV);
> -}
> -#endif
>  
>  static int da9063_regulator_probe(struct platform_device *pdev)
>  {
> -- 
> 2.11.0
>