Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp1355233img; Tue, 19 Mar 2019 06:05:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqxWY1xKAJ1ZrOS1YdguAhKceTxRyvd2IULqgUJOo4X62imoxltgyl3AWk+VZfS4414hF1ZO X-Received: by 2002:a62:568e:: with SMTP id h14mr2383613pfj.134.1553000699779; Tue, 19 Mar 2019 06:04:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553000699; cv=none; d=google.com; s=arc-20160816; b=nt9eHgnRYyc1Ka1gXFGqBMzIq78dThHYo1R379BYbW974lDxESN4HTYHv3HCDn5Rdq kKhVwlV7pXDkFDY1qOuJ6yho0L7mvHJiVNgu4fILX2AwAEbJaJ/ISKXnbDi3c5XODbUW YYWf/ey75x/ubtrJ9qILXGhEjKFtry3RWONL6hugdrWma/Uqbvm3yAXw1dLXhhqYqVqz cZOqwvxT/yD4unDVGFHetIbX/y7xPl++vaAeaKsOdmeAVL41xBLvtNK3wnTuW3jyEOhP Px0zC7SxGOLHsNZUae/4N91m+7muTqjtds7Q0xN3ZeIrD7K42G8sPqd2OBfW3i0vGlwY 3tWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=lmqxsl1xin+NweTXv9eP9kV2rNfl3zewBxkHmoXQW7s=; b=waaRyiCgfElTNpCCsLDfA5lYyvUIHruk2If/MAD8zsrQL/kFXY6waG+QQXEHwtiBUe hXvKDTbrOfOeFx5pOHDzrneY1QHc8O7SMVrpjL4MQhcZRcD2MJ9QpzQXVo5TET9NSExz XgLsFOF0U4VKTb4oM3l84H5kJGdU1UVtFQzOElYJ4Mfbo1jGgMINJal7I7+oNhfMCYXT 9XIY8rNBKtKPpjeq7gKQhmjzD5S6UZcEYqU9BcavrtCo0smhsD5es8/yysEKDSuXT/cm v4ymjhTAJpB8FQBKOpnZIRMBlGLcuolSXC7xjCjyoVgG+mLQyiCX7YfjDPuEKIwZcW/j Z2jg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=EhJC47jA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q1si4858932pfh.125.2019.03.19.06.04.43; Tue, 19 Mar 2019 06:04:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=EhJC47jA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727534AbfCSNBk (ORCPT + 99 others); Tue, 19 Mar 2019 09:01:40 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:56676 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726002AbfCSNBj (ORCPT ); Tue, 19 Mar 2019 09:01:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=lmqxsl1xin+NweTXv9eP9kV2rNfl3zewBxkHmoXQW7s=; b=EhJC47jA/ZDP0i4coV/EegiTp LWEea6LixjttFOA4G0UTHNADDUNjMmwKEpKmvmJgUO2ZsyOca+ezdaQZcPtq2xliWJ19nytvrLciJ 0ZOb/XPpujNBeoQ/Y/lypNPL9+E5Qfrbkd2Ku5Rye8VaXdcu+/Pj64hDGKnGX0xHFCXwo=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1h6EN5-00031P-6M; Tue, 19 Mar 2019 13:01:35 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id 8E6B611288DF; Tue, 19 Mar 2019 13:01:34 +0000 (GMT) Date: Tue, 19 Mar 2019 13:01:34 +0000 From: Mark Brown To: Wolfram Sang Cc: linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Lee Jones , Support Opensource , Liam Girdwood Subject: Re: [PATCH 4/6] regulator: da9063: move definitions out of a header into the driver Message-ID: <20190319130134.GD5514@sirena.org.uk> References: <20190318154759.21978-1-wsa+renesas@sang-engineering.com> <20190318154759.21978-5-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vni90+aGYgRvsTuO" Content-Disposition: inline In-Reply-To: <20190318154759.21978-5-wsa+renesas@sang-engineering.com> X-Cookie: PURGE COMPLETE. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --vni90+aGYgRvsTuO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Mar 18, 2019 at 04:47:56PM +0100, Wolfram Sang wrote: > Those definitions are only used within the driver meanwhile, so put them > there. Acked-by: Mark Brown --vni90+aGYgRvsTuO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlyQ6C0ACgkQJNaLcl1U h9AbAgf/dHp2suacInailmibsa6sHXFHFH3Y/YWTdj3VUHWgteCfmnSr9UpxV+Dw /lpC1r+hXzGjof9eoe4pJtHSan1GFAKz51ycikvKiAdBg4V39Rve7Rh63Yca5ks8 CXhXhGS1nEWngr5ho/x7K89I21YNxVv1o0BCERmwHHKWiJGmIZ60nO8SwL7upJyd bOXOcI4cY48MhqJYoFfSZu2GDaX1s0jU0f40MHc8MhgobUUwAdK/5hWU0tsCVF5I 91nL9iqfsgLRCRZD21xUzuvVR9mmME8NyBg5Q37PjKpA7SOUFJTlFPaIaqTdCHRS EZzMCJRxlNYoZkQQDZImZD73BlOZ2Q== =YkpE -----END PGP SIGNATURE----- --vni90+aGYgRvsTuO--