Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\))
Subject: Re: [PATCH 1/2] w1: ds2408: add a missing reset when retrying in
 output_write()
From:   Jean-Francois Dagenais <jeff.dagenais@gmail.com>
In-Reply-To: <DF2ABF87-116D-4287-8A18-89C2C59124AF@gmail.com>
Date:   Tue, 19 Mar 2019 10:25:50 -0400
Cc:     open list <linux-kernel@vger.kernel.org>,
        Evgeniy Polyakov <zbr@ioremap.net>,
        Greg Kroah-Hartman <greg@kroah.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <3E9B4A8B-6409-4102-A3A2-40853AD04DB1@gmail.com>
References: <20190318092737.8170-1-manio@skyboo.net>
 <20190318092737.8170-2-manio@skyboo.net>
 <DF2ABF87-116D-4287-8A18-89C2C59124AF@gmail.com>
To:     Mariusz Bialonczyk <manio@skyboo.net>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On Mar 19, 2019, at 10:21, Jean-Francois Dagenais =
<jeff.dagenais@gmail.com> wrote:
>=20
> I can do a proper patch submission if you guys provide positive =
response on this
> early RFC. Or better yet, you can take it and own it yourself as your =
v2
> Mariusz. ;)

Just FYI, here's what the retry loop looks like after this suggested =
patch:

	do {
		w1_buf[0] =3D W1_F29_FUNC_CHANN_ACCESS_WRITE;
		w1_buf[1] =3D *buf;
		w1_buf[2] =3D ~(*buf);
		w1_write_block(sl->master, w1_buf, 3);

		readBack =3D w1_read_8(sl->master);

		if (readBack =3D=3D W1_F29_SUCCESS_CONFIRM_BYTE &&
		    optional_read_back_valid(sl, *buf)) {
			bytes_written =3D 1;
			goto out;
		}

		if (w1_reset_resume_command(sl->master))
			goto out; /* unrecoverable error */
		/* try again, the slave is ready for a command */
	} while (--retries);


Much better on the eyes.=