Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] net: stmmac: fix memory corruption with large MTUs
To:     "Koskinen, Aaro (Nokia - FI/Espoo)" <aaro.koskinen@nokia.com>,
        Jose Abreu <jose.abreu@synopsys.com>,
        Aaro Koskinen <aaro.koskinen@iki.fi>,
        "David S. Miller" <davem@davemloft.net>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@st.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20190318213608.612-1-aaro.koskinen@iki.fi>
 <92e465e5-0c77-e22f-d7e1-4689f3d655e7@synopsys.com>
 <DB6PR0701MB2487FF2B8D4C0219DD209952F4400@DB6PR0701MB2487.eurprd07.prod.outlook.com>
From:   Jose Abreu <jose.abreu@synopsys.com>
Message-ID: <b3f61517-3d6d-dc20-fd50-6ac98e0b9dd4@synopsys.com>
Date:   Tue, 19 Mar 2019 14:42:32 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.1
MIME-Version: 1.0
In-Reply-To: <DB6PR0701MB2487FF2B8D4C0219DD209952F4400@DB6PR0701MB2487.eurprd07.prod.outlook.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 3/19/2019 11:07 AM, Koskinen, Aaro (Nokia - FI/Espoo) wrote:
> Hi,
> 
> From: Jose Abreu [jose.abreu@synopsys.com]:
>> On 3/18/2019 9:36 PM, Aaro Koskinen wrote:
>>>       /* Fill DES3 in case of RING mode */
>>> -     if (priv->dma_buf_sz >= BUF_SIZE_8KiB)
>>> +     if (priv->dma_buf_sz == BUF_SIZE_16KiB)
>>
>> Shouldn't this be: "if (priv->dma_buf_sz > BUF_SIZE_8KiB)" ?
> 
> I think it should be the same as in stmmac_init_rx_buffers():
> 
>         if (priv->dma_buf_sz == BUF_SIZE_16KiB)
>                 stmmac_init_desc3(priv, p);
> 
> A.
> 

Hmm, yeah makes sense. I was under impression that XGMAC had a >
16KB buffer but I was wrong.

This change looks okay then.

Acked-by: Jose Abreu <joabreu@synopsys.com>

Thanks,
Jose Miguel Abreu