Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp1449186img; Tue, 19 Mar 2019 07:54:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqxSFl4IrTQV91t8dyDrQiLXwTmhZNL25cn43cLlwli5opVpXYUKbgbuf5yXpyNkF17yuyAw X-Received: by 2002:a63:1d03:: with SMTP id d3mr2470503pgd.42.1553007271389; Tue, 19 Mar 2019 07:54:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553007271; cv=none; d=google.com; s=arc-20160816; b=JXEfAAmhW9Cycnkmb6DpFsoaBGzjXEFj4CJ0nmFlECuqVWjeODdliMuG0Arp90opl1 4m0AOZyEm4aMLG9vTe8+iYzJTPFAPF4JToJ3Mx/51mcwS5OmOOm2dW9jnToN/STR5VAU 10xZ9G+WyrIDK3h5RtUPRPM5p5d1K1x8D2EzE6SXU5Z40mBe1xSVKSFlOv/Ms2y/3R5e grtuR1gSvSCQ02CidbQDBzH1HgYU1EQxyFelTUmVipqwFHJ58OCMqzZZ9p4VD7ZxuFrI 61PeMROp+KQUOai6Zb6B9Vswhm/mltwhKJ1fndpaAuBglVDWovBH/jcmkEEkAqD6t8FJ IGVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :subject:cc:to:from:date; bh=df7CXa/dRv22rCVJlf0c6549r+BPK4luMPDMNaH83QM=; b=qcYe6zKwfPvECEKWZkeDrnLHDV0UlXvWKC/7Flv6F1W0z6vCiWQAutjbbY1yTL1I6J QwJAcJtFDVWe16bnTw6kzxXHCZyj2hk2Y7TALxUz8MA5xYIDW2tu3u8v2KSns9MEqVJ6 dqnVit731qNSU3x+AHuSfeHlLckDlQKhS0ntJ1Sq1B0HO33d6qO+aytj5G3ttRQYcGCs NaczsJetrjgW1v1eYFVqHAiFk72UYK8J4KI3k2RpyoQro3ATGSlAx0PAbUeqda3zMgHn e20H1PTdzq6F3C6TR15demnplFlODzTyO0pmew++WSc+ilDMuJ9VfWof6CEZBhCOvK8x ZeKw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m10si11906627pgk.386.2019.03.19.07.54.14; Tue, 19 Mar 2019 07:54:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727725AbfCSOv7 (ORCPT + 99 others); Tue, 19 Mar 2019 10:51:59 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:33111 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726466AbfCSOv6 (ORCPT ); Tue, 19 Mar 2019 10:51:58 -0400 Received: from [5.158.153.52] (helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1h6G5s-0007aQ-Hf; Tue, 19 Mar 2019 15:51:56 +0100 Date: Tue, 19 Mar 2019 15:51:56 +0100 (CET) From: Thomas Gleixner To: Roman Kiryanov cc: LKML , Sebastian Reichel , Greg KH Subject: [PATCH] drivers: power: supply: goldfish_battery: Fix bogus SPDX identifier Message-ID: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org spdxcheck.py complains: drivers/power/supply/goldfish_battery.c: 1:28 Invalid License ID: GPL which is correct because GPL is not a valid identifier. Of course this could have been caught by checkpatch.pl _before_ submitting or merging the patch. WARNING: 'SPDX-License-Identifier: GPL' is not supported in LICENSES/... #19: FILE: drivers/power/supply/goldfish_battery.c:1: +// SPDX-License-Identifier: GPL Which is absolutely hillarious as the commit introducing this wreckage says in the changelog: There was a checkpatch complain: "Missing or malformed SPDX-License-Identifier tag". Oh well. Replacing a checkpatch warning by a different checkpatch warning is a really useful exercise. Use the proper GPL-2.0 identifier which is what the boiler plate in the file had originally. Fixes: e75e3a125b40 ("drivers: power: supply: goldfish_battery: Put an SPDX tag") Signed-off-by: Thomas Gleixner --- diff --git a/drivers/power/supply/goldfish_battery.c b/drivers/power/supply/goldfish_battery.c index ad969d9fc981..c2644a9fe80f 100644 --- a/drivers/power/supply/goldfish_battery.c +++ b/drivers/power/supply/goldfish_battery.c @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL +// SPDX-License-Identifier: GPL-2.0 /* * Power supply driver for the goldfish emulator *