Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1553008222.152266.43.camel@acm.org>
Subject: Re: [PATCH 0/8]: blk-mq: use static_rqs to iterate busy tags
From:   Bart Van Assche <bvanassche@acm.org>
To:     "jianchao.wang" <jianchao.w.wang@oracle.com>, axboe@kernel.dk
Cc:     linux-block@vger.kernel.org, jsmart2021@gmail.com,
        sagi@grimberg.me, josef@toxicpanda.com,
        linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
        keith.busch@intel.com, hare@suse.de, jthumshirn@suse.de, hch@lst.de
Date:   Tue, 19 Mar 2019 08:10:22 -0700
In-Reply-To: <3cd58454-eda3-de9a-0eed-b6a7edbce28f@oracle.com>
References: <1552640264-26101-1-git-send-email-jianchao.w.wang@oracle.com>
         <1552930085.152266.36.camel@acm.org>
         <3cd58454-eda3-de9a-0eed-b6a7edbce28f@oracle.com>
Content-Type: text/plain; charset="UTF-7"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 2019-03-19 at 09:25 +-0800, jianchao.wang wrote:
+AD4 Do you mean this patch from Jens ?
+AD4 https://marc.info/?l+AD0-linux-block+ACY-m+AD0-154534605914798+ACY-w+AD0-2
+AD4 
+AD4 +-	rcu+AF8-read+AF8-lock()+ADs
+AD4  	sbitmap+AF8-for+AF8-each+AF8-set(+ACY-bt-+AD4-sb, bt+AF8-iter, +ACY-iter+AF8-data)+ADs
+AD4 +-	rcu+AF8-read+AF8-unlock()+ADs
+AD4 
+AD4 The busy+AF8-iter+AF8-fn could sleep for nvme
+AD4 blk+AF8-mq+AF8-check+AF8-expired
+AD4   -+AD4 blk+AF8-mq+AF8-rq+AF8-timed+AF8-out
+AD4     -+AD4 q-+AD4-mq+AF8-ops-+AD4-timeout
+AD4        nvme+AF8-timeout
+AD4          -+AD4 nvme+AF8-dev+AF8-disable
+AD4             -+AD4 mutex+AF8-lock dev-+AD4-shutdown+AF8-lock

Hi Jianchao,

I think that's an additional reason to rewrite NVMe error handling ...

Best regards,

Bart.